Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 595190 - app-text/mupdf fails to compile with -fsanitize=address
Summary: app-text/mupdf fails to compile with -fsanitize=address
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Virgil Dupras (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-26 12:11 UTC by Agostino Sarubbo
Modified: 2019-05-07 02:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2016-09-26 12:11:13 UTC
In the ebuild we add -Wl--no-undefined which causes the failure when -fsanitize=address is enabled (undefined reference to __asan*).
Comment 1 Michael Weber (RETIRED) gentoo-dev 2017-06-22 23:32:19 UTC
where do you specify -fsanitize=address? I'd like to reproduce fix this issue.
Comment 2 Agostino Sarubbo gentoo-dev 2017-06-23 06:36:50 UTC
in C/CXX FLAGS
Comment 3 Virgil Dupras (RETIRED) gentoo-dev 2018-11-30 02:59:38 UTC
I can reproduce the problem and I'm indeed not sure why we want to have "-Wl--no-undefined", which is a development tool, in an ebuild, but on the other hand, why do you want to have "-fsanitize=address"? To test the security of mupdf in the context of Gentoo? I'm not sure that we should take steps to accommodate this kind of activity in the ebuild: it is expected that, for this kind of stuff, you'll have to hack through ebuild a little bit. Also, this is temporary, you won't actually run systems with that flag.

What do you think?
Comment 4 Agostino Sarubbo gentoo-dev 2018-12-10 08:38:15 UTC
(In reply to Virgil Dupras from comment #3)
> I can reproduce the problem and I'm indeed not sure why we want to have
> "-Wl--no-undefined", which is a development tool, in an ebuild, but on the
> why do you want to have "-fsanitize=address"?

I don't want it as default. I just expect the a custom set of cflags works like other packages
Comment 5 Larry the Git Cow gentoo-dev 2019-05-07 02:39:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6e0b3e7722417649362c3909fbf1fc0b5c80eb93

commit 6e0b3e7722417649362c3909fbf1fc0b5c80eb93
Author:     Virgil Dupras <vdupras@gentoo.org>
AuthorDate: 2019-05-07 02:37:54 +0000
Commit:     Virgil Dupras <vdupras@gentoo.org>
CommitDate: 2019-05-07 02:38:46 +0000

    app-text/mupdf: bump to 1.15.0
    
    We remove the "curl" USE flag because upstream stopped depending on it
    with its removal of "progressive loading code".
    
    Closes: https://bugs.gentoo.org/653298
    Closes: https://bugs.gentoo.org/683490
    Closes: https://bugs.gentoo.org/595190
    Signed-off-by: Virgil Dupras <vdupras@gentoo.org>
    Package-Manager: Portage-2.3.62, Repoman-2.3.11

 app-text/mupdf/Manifest                           |   1 +
 app-text/mupdf/files/mupdf-1.15-CFLAGS.patch      |  13 +++
 app-text/mupdf/files/mupdf-1.15-Makefile.patch    |  42 ++++++++
 app-text/mupdf/files/mupdf-1.15-openssl-x11.patch |  20 ++++
 app-text/mupdf/mupdf-1.15.0.ebuild                | 122 ++++++++++++++++++++++
 5 files changed, 198 insertions(+)