Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 594758 - [youbroketheinternet] Various changes
Summary: [youbroketheinternet] Various changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Overlays Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-22 11:05 UTC by ng0
Modified: 2016-09-23 13:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ybti: change urls, change owner name+email (0001-repositories-youbroketheinternet-Batch-of-changes.patch,1.96 KB, patch)
2016-09-22 18:48 UTC, ng0
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ng0 2016-09-22 11:05:25 UTC
I will update this ticket with a patch once the new host (https://gnunet.org) has activated http-backend for git to follow your requirements.

Changes:

- Name: youbroketheinternet -> youbroketheinternet-overlay
- Maintainer Name+Email: ng0 -> N. "ng0" Gillmann, Email matches the one I use here.

delete n0.is host and its onion, add gnunet.org in place.

Patch will come soon.

Reproducible: Always
Comment 1 ng0 2016-09-22 11:06:45 UTC
Please assign this to me.

I opened this in advance to ask if there's a policy on overlay name changes.
Someone working in our team requested the change.
Comment 2 ng0 2016-09-22 18:48:02 UTC
Created attachment 447448 [details, diff]
ybti: change urls, change owner name+email

ybti: change urls, change owner name+email
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-09-23 05:37:41 UTC
(In reply to N. "ng0" Gillmann from comment #1)
> I opened this in advance to ask if there's a policy on overlay name changes.

We can change the name if you update profiles/repo_name. However, note that layman doesn't detect that in any way, so it will silently continue using the overlay with the old URL.
Comment 4 ng0 2016-09-23 08:02:48 UTC
So if the name stays the same and I change the URL like I have to now layman doesn't pick it up?
If layman doesn't pick up the changes I added in the patch, I want to add the name change as well. If layman picks up the changes and the name change would not be picked up, I don't want the name to be changed.
Comment 5 ng0 2016-09-23 08:04:34 UTC
(In reply to N. "ng0" Gillmann from comment #4)
> So if the name stays the same and I change the URL like I have to now layman
> doesn't pick it up?
> If layman doesn't pick up the changes I added in the patch, I want to add
> the name change as well. If layman picks up the changes and the name change
> would not be picked up, I don't want the name to be changed.

What I mean is, is there any damage added if I change the profiles/repo_name in addition to the changes? The url already shows the name.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-09-23 08:12:39 UTC
Just to be clear, I haven't used layman for a while, so it may changed a little but the generic considerations are:

1. If you change the URL (and name stays the same), layman can detect that and it can either warn the user or change the URL (I think it used to do the former),

2. If you change the name, then layman obviously can't guess the new name, so it just presumes the repository was removed completely.

So I suggest you keep the old name, especially that appending '-overlay' is redundant and just makes people have to type more.
Comment 7 ng0 2016-09-23 08:25:07 UTC
(In reply to Michał Górny from comment #6)
> Just to be clear, I haven't used layman for a while, so it may changed a
> little but the generic considerations are:
> 
> 1. If you change the URL (and name stays the same), layman can detect that
> and it can either warn the user or change the URL (I think it used to do the
> former),
> 
> 2. If you change the name, then layman obviously can't guess the new name,
> so it just presumes the repository was removed completely.

Okay, thanks for the clarification.

> So I suggest you keep the old name, especially that appending '-overlay' is
> redundant and just makes people have to type more.

That wasn't my idea, there are other reasons for that.. mainly future namespaces.

I'd say you can apply the patch as it is, I can explain the reasons for keeping the name
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-09-23 13:02:07 UTC
commit 3334aeaab0eff12518373bb606cd072767133427
Author: ng0 <ng0@we.make.ritual.n0.is>
Date:   Tue Sep 20 17:50:57 2016

    repositories: Update URL & owner for youbroketheinternet
    
    Bug: https://bugs.gentoo.org/594758