Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 594214 - mate-extra/caja-extensions: remove gksu support
Summary: mate-extra/caja-extensions: remove gksu support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo MATE Desktop
URL: https://github.com/mate-desktop/caja-...
Whiteboard:
Keywords:
Depends on:
Blocks: 425156
  Show dependency tree
 
Reported: 2016-09-18 11:18 UTC by Pacho Ramos
Modified: 2018-11-01 10:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2016-09-18 11:18:50 UTC
We are trying (for years) to drop gksu because it's completely dead and even with some security issues... hence, if this optional support is not really needed, I would try to disable it if possible. Other option is to use polkit as replacement as explained in parent tracker bug

Thanks
Comment 1 Adam Feldman gentoo-dev 2016-09-19 19:57:38 UTC
I'll speak with upstream about it.
Comment 2 Pacho Ramos gentoo-dev 2016-11-15 12:55:32 UTC
Only this and bug 486456 are blocking gksu removal, could you take a look to this please? Thanks!
Comment 3 Pacho Ramos gentoo-dev 2016-12-31 14:19:33 UTC
Maybe they can rely on x11-misc/ktsuss
Comment 4 Pacho Ramos gentoo-dev 2017-01-15 11:14:12 UTC
Any issues with finally disabling its gksu support? gksu is vulnerable and this is the last (also optional) requirement :|

Thanks a lot
Comment 5 Sander Sweers 2017-01-28 01:00:24 UTC
(In reply to Pacho Ramos from comment #3)
> Maybe they can rely on x11-misc/ktsuss

It just calls the binary [1] with the command so replacing the g_strdup("gksu") with g_strdup("ktsuss bin name") would probably work just fine.

[1] https://github.com/mate-desktop/caja-extensions/blob/master/gksu/libcaja-gksu.c#L162

diff --git a/gksu/libcaja-gksu.c b/gksu/libcaja-gksu.c
index 18c8db1..a4767af 100644
--- a/gksu/libcaja-gksu.c
+++ b/gksu/libcaja-gksu.c
@@ -159,7 +159,7 @@ start_gksu_thread (void *data)
   gchar **argv = (gchar**) g_malloc (sizeof (gchar*) * 3);
   gchar *full_cmd = (gchar*) data;
 
-  argv[0] = g_strdup ("gksu");
+  argv[0] = g_strdup ("ktsuss");
   argv[1] = full_cmd;
   argv[2] = NULL;
Comment 6 Sander Sweers 2017-01-28 01:06:13 UTC
or use pkexec but this then adds a dep on polkit.
Comment 7 Pacho Ramos gentoo-dev 2017-02-07 13:00:49 UTC
I added the suggestion in the upstream report:
https://github.com/mate-desktop/caja-extensions/issues/22

Some people also suggest to use this extension:
https://github.com/brunonova/nautilus-admin
Comment 8 Pacho Ramos gentoo-dev 2017-06-06 08:33:34 UTC
ktsuss option looks like the easiest, maybe it could be changed in 1.18.x cycle at least :/
Comment 9 Pacho Ramos gentoo-dev 2017-06-17 09:59:33 UTC
Looks like they prefer to move to rely on gvfs... but that never comes... then, either we drop the gksu support completely or try to use ktsuss downstream
Comment 10 Sander Sweers 2017-06-21 19:18:34 UTC
(In reply to Pacho Ramos from comment #9)
> Looks like they prefer to move to rely on gvfs... but that never comes...
> then, either we drop the gksu support completely or try to use ktsuss
> downstream

The admin backend requires code changes, I commented on the issue.

If you like to drop it I ported the nautilus-admin extension to caja which you can use as a replacement, https://github.com/infirit/caja-admin
Comment 11 Adam Feldman gentoo-dev 2017-06-21 19:23:48 UTC
(In reply to Sander Sweers from comment #10)
> (In reply to Pacho Ramos from comment #9)
> > Looks like they prefer to move to rely on gvfs... but that never comes...
> > then, either we drop the gksu support completely or try to use ktsuss
> > downstream
> 
> The admin backend requires code changes, I commented on the issue.
> 
> If you like to drop it I ported the nautilus-admin extension to caja which
> you can use as a replacement, https://github.com/infirit/caja-admin

I like the idea of using caja-admin.  I'll add my voice to upstream on them making your fork official,, but if not, I'll go ahead with adding an ebuild to your repo.

I commented in two locations on the url not being updated, but it looks like all the pot files are that way and need updating, just a FYI.
Comment 12 Sander Sweers 2017-06-21 20:18:39 UTC
Ok, gvfsd-admin appears to be broken for me. It works fine on a Debian sid VM. So if putting admin:/// in your location works this can be dropped and people can use that. It does requires gvfs 1.30 I believe
Comment 13 Pacho Ramos gentoo-dev 2017-07-26 09:47:27 UTC
Could caja-admin be included finally then, please? :)
Comment 14 Pacho Ramos gentoo-dev 2017-12-06 14:02:20 UTC
Any news? This is the only consumer of gksu
Comment 15 Larry the Git Cow gentoo-dev 2018-11-01 10:41:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5bb39a717b0a6a2850dcc32b70a897b128e140d3

commit 5bb39a717b0a6a2850dcc32b70a897b128e140d3
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2018-11-01 10:40:38 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2018-11-01 10:40:38 +0000

    base/package.use.mask: gksu will be removed (#594214)
    
    Closes: https://bugs.gentoo.org/594214
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 profiles/base/package.use.mask | 4 ++++
 1 file changed, 4 insertions(+)