Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 593476 - www-client/chromium-54.0.2840.16 - ../../tools/gn/last_commit_position.py: AttributeError: 'NoneType' object has no attribute 'stdout'
Summary: www-client/chromium-54.0.2840.16 - ../../tools/gn/last_commit_position.py: At...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-11 08:12 UTC by klaus818
Modified: 2016-12-07 16:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log.bz2,10.19 KB, application/x-bzip)
2016-09-11 08:12 UTC, klaus818
Details
build log (build.log,234.00 KB, text/plain)
2016-09-11 15:04 UTC, Mike Gilbert
Details
patch for unneeded "git log" call (chromium-no-git.patch,434 bytes, patch)
2016-11-22 12:39 UTC, Andreas Kinzler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description klaus818 2016-09-11 08:12:48 UTC
Created attachment 445454 [details]
build.log

Portage 2.3.0 (python 3.4.5-final-0, default/linux/amd64/13.0/desktop/plasma/systemd, gcc-5.4.0, glibc-2.23-r2, 4.7.3-gentoo x86_64)
=================================================================
System uname: Linux-4.7.3-gentoo-x86_64-Intel-R-_Pentium-R-_CPU_B960_@_2.20GHz-with-gentoo-2.3
KiB Mem:     3902832 total,    964156 free
KiB Swap:    8191996 total,   8191836 free
Timestamp of repository gentoo: Sun, 11 Sep 2016 02:00:01 +0000
sh bash 4.3_p46
ld GNU ld (Gentoo 2.26.1 p1.0) 2.26.1
app-shells/bash:          4.3_p46::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.24.0-r1::gentoo
dev-lang/python:          2.7.12::gentoo, 3.4.5::gentoo
dev-util/cmake:           3.6.2::gentoo
dev-util/pkgconfig:       0.29.1::gentoo
sys-apps/baselayout:      2.3::gentoo
sys-apps/openrc:          0.21.7::gentoo
sys-apps/sandbox:         2.10-r2::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r2::gentoo
sys-devel/automake:       1.11.6-r2::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r2::gentoo
sys-devel/binutils:       2.26.1::gentoo
sys-devel/gcc:            5.4.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r2::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.7::gentoo (virtual/os-headers)
sys-libs/glibc:           2.23-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y"
FCFLAGS="-march=native -O2 -pipe"
FEATURES="assume-digests binpkg-logs candy config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=native -O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="de_DE.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 berkdb branding bzip2 cairo cdda cdr cli cracklib crypt cups cxx dbus declarative dri dts dvd dvdr emboss encode exif fam ffmpeg firefox flac fortran gdbm gif glamor google gpm gtk iconv ipv6 jpeg kde kipi lcms ldap legacy-systray libnotify lm_sensors mad matroska mmx mmxext mng modules mp3 mp4 mpeg mtp multilib ncurses networkmanager nls nptl ogg opengl openmp opus pam pango pch pcre pdf phonon pim plasma png policykit postproc ppds pulseaudio qml qt3support qt4 qt5 readline sdl seccomp semantic-desktop session spell sse sse2 ssl startup-notification svg systemd tcpd threads tiff truetype udev udisks unicode upnp upower usb vaapi vc vorbis vpx widgets wxwidgets x264 x265 xattr xcb xcomposite xinerama xml xscreensaver xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" L10N="de" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="de" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby20 ruby21" SANE_BACKENDS="hp" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Mike Gilbert gentoo-dev 2016-09-11 15:03:10 UTC
> [42/429] python ../../tools/gn/last_commit_position.py ../../ gen/tools/gn/last_commit_position.h TOOLS_GN_LAST_COMMIT_POSITION_H_
> FAILED: gen/tools/gn/last_commit_position.h 
> python ../../tools/gn/last_commit_position.py ../../ gen/tools/gn/last_commit_position.h TOOLS_GN_LAST_COMMIT_POSITION_H_
> Traceback (most recent call last):
>   File "../../tools/gn/last_commit_position.py", line 96, in <module>
>     value = FetchCommitPosition(git_directory)
>   File "../../tools/gn/last_commit_position.py", line 64, in FetchCommitPosition
>     line = proc.stdout.readline()
> AttributeError: 'NoneType' object has no attribute 'stdout'
> [43/429] python ../../build/write_build_date_header.py gen/base/generated_build_date.h default
> ninja: build stopped: subcommand failed.
> Command '['ninja', '-C', '/var/tmp/portage/www-client/chromium-54.0.2840.16/work/chromium-54.0.2840.16/out/Release', '-v', 'gn']' returned non-zero exit status 1
Comment 2 Mike Gilbert gentoo-dev 2016-09-11 15:04:32 UTC
Comment on attachment 445454 [details]
build.log

No need to compress logs when under 1M.
Comment 3 Mike Gilbert gentoo-dev 2016-09-11 15:04:57 UTC
Created attachment 445482 [details]
build log
Comment 4 Mike Gilbert gentoo-dev 2016-09-11 15:16:05 UTC
It appears this python script is trying to read the output of "git log".

I can reproduce the problem after uninstalling dev-vcs/git.
Comment 5 Mike Gilbert gentoo-dev 2016-09-11 15:29:51 UTC
commit 9fbf495a92753d0b91a6ebab3652fa748ab690bb
Author: Mike Gilbert <floppym@gentoo.org>
Date:   Sun Sep 11 11:25:47 2016 -0400

    www-client/chromium: depend on dev-vcs/git
    
    Bug: https://bugs.gentoo.org/593476
    Package-Manager: portage-2.3.0_p24

 www-client/chromium/chromium-54.0.2840.16.ebuild | 2 ++
 www-client/chromium/chromium-55.0.2853.0.ebuild  | 2 ++
 2 files changed, 4 insertions(+)
Comment 6 Andreas Kinzler 2016-11-22 12:39:57 UTC
Created attachment 454038 [details, diff]
patch for unneeded "git log" call

Sorry, I think adding git as an ebuild dependency is an inacceptable "fix". A simple patch really fixes the problem by not calling git at all
Comment 7 Mike Gilbert gentoo-dev 2016-11-22 16:13:53 UTC
(In reply to Andreas Kinzler from comment #6)

If you can provide a patch that upstream would be able to merge, I would be happy to help make that happen.
Comment 8 Ryoto Yayame 2016-12-07 16:00:54 UTC
It has been fixed by:

https://codereview.chromium.org/2237913002/

https://chromium.googlesource.com/chromium/src/+/e9fcf209818dede2348c41913994b5d9ea81314c

Thanks to remove the dev-vcs/git dependency as appropriate.

www-client/chromium-54.0.2840.100 (current stable version) already includes the patch, so it can be modified. I didn't check the other versions.
Comment 9 Ryoto Yayame 2016-12-07 16:24:00 UTC
Ok no sorry, from what I understand, the upstream patch was just for the case where Git cannot find the commit position... Building still fails if Git is not installed and cannot be run at all, with the same error message...