Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 592668 - app-antivirus/clamav-0.99 freshclamd service can't create PID file to start correctly in SystemD
Summary: app-antivirus/clamav-0.99 freshclamd service can't create PID file to start c...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Antivirus Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-01 15:17 UTC by Shaun Bouckaert
Modified: 2018-12-03 21:34 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Emerge Info (emerge-info,4.68 KB, text/plain)
2016-09-01 15:17 UTC, Shaun Bouckaert
Details
Patch for SystemD service file (freshclamd.service.patch,338 bytes, patch)
2016-09-01 15:18 UTC, Shaun Bouckaert
Details | Diff
Patch for SystemD service file (fixed) (freshclamd.service.patch,338 bytes, patch)
2016-09-01 15:22 UTC, Shaun Bouckaert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shaun Bouckaert 2016-09-01 15:17:31 UTC
Created attachment 444726 [details]
Emerge Info

The SystemD service file specifies a path for the PID file that doesn't exist. It just required the RuntimeDirectory directive added, as well as the User and Group to allow permissions to the directory.
Comment 1 Shaun Bouckaert 2016-09-01 15:18:42 UTC
Created attachment 444728 [details, diff]
Patch for SystemD service file

Patch with changes mentioned in report.
Comment 2 Shaun Bouckaert 2016-09-01 15:22:58 UTC
Created attachment 444730 [details, diff]
Patch for SystemD service file (fixed)
Comment 3 Thomas Raschbacher gentoo-dev 2018-04-20 12:19:37 UTC
CC'ing systemd project
Comment 4 Thomas Raschbacher gentoo-dev 2018-10-05 12:50:47 UTC
assigning to systemd project and CC'ing antivirus

Since I have no experience with systemd I would appreciate if someone from the systemd project could check this (and feel free to commit it if it is correct)
Comment 5 Mike Gilbert gentoo-dev 2018-10-05 13:29:55 UTC
The patch looks fine to me.
Comment 6 Thomas Raschbacher gentoo-dev 2018-10-07 18:27:10 UTC
thanks floppym.
commited.
Comment 7 Mike Gilbert gentoo-dev 2018-10-07 18:57:11 UTC
This change merits a revbump: you are changing the contents of an installed file. Straight-to-stable should be fine.

Also, a tip on commit messages:

Instead of this:

> Thanks to Shaun for the patch and floppym for checking.
> Closes https://bugs.gentoo.org/592668

Make it this:

> Thanks to Shaun for the patch and floppym for checking.
> 
> Closes: https://bugs.gentoo.org/592668

The extra newline and the colon are significant. This will allow the commit bot to find the tag and update the bug automatically.
Comment 8 Thomas Raschbacher gentoo-dev 2018-10-08 07:22:20 UTC
@floppym ah thanks i did wonder why it didn'T close it.. so it was the newline. thanks.. and yeah you are right .. I should've rev-bumped it.. I'll do it later / after work.
Comment 9 Larry the Git Cow gentoo-dev 2018-10-14 11:53:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ece77c37f680f60efa93039359ec0fbd27344f98

commit ece77c37f680f60efa93039359ec0fbd27344f98
Author:     Thomas Raschbacher <lordvan@gentoo.org>
AuthorDate: 2018-10-14 11:52:20 +0000
Commit:     Thomas Raschbacher <lordvan@gentoo.org>
CommitDate: 2018-10-14 11:53:08 +0000

    app-antivirus/clamav: revbump for systemd file fix
    
    Closes: https://bugs.gentoo.org/592668
    Signed-off-by: Thomas Raschbacher <lordvan@gentoo.org>
    Package-Manager: Portage-2.3.50, Repoman-2.3.11

 app-antivirus/clamav/clamav-0.100.1-r1.ebuild | 165 ++++++++++++++++++++++++++
 app-antivirus/clamav/clamav-0.99.4-r2.ebuild  | 157 ++++++++++++++++++++++++
 2 files changed, 322 insertions(+)