Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 592332 - x11-terms/st should install terminfo files (tput: unknown terminal "st-256color")
Summary: x11-terms/st should install terminfo files (tput: unknown terminal "st-256col...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Georgy Yakovlev
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 594338
Blocks:
  Show dependency tree
 
Reported: 2016-08-28 16:42 UTC by Joe M
Modified: 2022-01-08 10:29 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joe M 2016-08-28 16:42:49 UTC
Hello,

the st ebuilds are not installing the terminfo files.

The ebuild is also deleting the tic line from the Makefile

can you please change the src_install function of the ebuild to be this:

src_install() {
	emake DESTDIR="${D}" PREFIX="${EPREFIX}"/usr install
	tic -s -o "${ED}"/usr/share/terminfo st.info || die
	dodoc TODO

.
.
.
.

Thanks
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2016-08-31 03:46:08 UTC
Those are installed by sys-libs/ncurses-6*.
Comment 2 Ferenc Erki 2020-05-10 06:19:26 UTC
I believe part of the story is that the general availability of terminfo details via sys-libs/ncurses is delayed by at least a few factors:

  - ncurses upstream adopting new terminfo supplied from terminal projects' upstreams
  - new releases from ncurses upstream containing new terminfo
  - distros packaging/stabilizing new ncurses releases
  - distro users updating their systems

For example, if I'm reading things correctly, today sys-libs/ncurses-6.2-r1 includes terminfo for x11-terms/st-0.8.2, but x11-terms/st-0.8.3 is already released containing terminfo changes which are going to be missing on systems for a while due the above.

While I believe that process is more or less "business as usual", and may be worked around via local and/or per-user configuration, I wonder if we could do better on the Gentoo packaging side of the story.

What I have in mind is the following:

  - let the x11-terms/st ebuild install their own terminfo files to an alternative location to avoid conflict with files in /usr/share/terminfo installed by sys-libs/ncurses
  - let the x11-terms/st ebuild also install a file into /etc/env.d which specifies a TERMINFO_DIRS variable pointing to the alternative terminfo location, which can be picked up by ncurses earlier than the /usr/share/terminfo location
  - probably also making sure TERMINFO_DIRS is allowed to have multiple values separated by colons

What would be a good alternative location for extra terminfo files? /usr/local/share is ruled out from ebuilds, /opt/st/share doesn't feel like a good match, but perhaps /use/share/st/terminfo could work?

Does that idea sound feasible? I think I'll play with this in my overlay, but of course I would be happy to make sure the result something I can send for inclusion in the official portage tree as well.
Comment 3 Ferenc Erki 2020-05-10 19:29:57 UTC
After all, I decided to go for a split out x11-terms/st-terminfo in my overlay[1], and then let x11-terms/st depend on that (inspired by x11-terms/kitty-terminfo).

This approach does not just enable st users to have their own version's terminfo files installed, but also enables administrators to install only the terminfo files without st for any st user possibly logging in to their systems.

I plan to send either this or the originally outlined approach for review in a GitHub PR. Let me know any early feedback about this.

[1]: https://github.com/ferki/gentoo-overlay
Comment 4 Larry the Git Cow gentoo-dev 2022-01-07 20:44:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fa44f3be8da1351734708634e575e27bde98d635

commit fa44f3be8da1351734708634e575e27bde98d635
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2022-01-07 20:36:51 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2022-01-07 20:43:54 +0000

    x11-terms/st: add 0.8.5
    
    Closes: https://bugs.gentoo.org/592332
    Closes: https://github.com/gentoo/gentoo/pull/18326
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 x11-terms/st/Manifest        |  1 +
 x11-terms/st/st-0.8.5.ebuild | 75 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 76 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d65ae4798481462d0c332a98329f2c6075fd57c8

commit d65ae4798481462d0c332a98329f2c6075fd57c8
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2022-01-07 20:32:45 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2022-01-07 20:43:53 +0000

    x11-terms/st-terminfo: initial import
    
    Bug: https://bugs.gentoo.org/592332
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 x11-terms/st-terminfo/Manifest                 |  1 +
 x11-terms/st-terminfo/metadata.xml             |  8 ++++
 x11-terms/st-terminfo/st-terminfo-0.8.5.ebuild | 51 ++++++++++++++++++++++++++
 x11-terms/st-terminfo/st-terminfo-9999.ebuild  | 51 ++++++++++++++++++++++++++
 4 files changed, 111 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2022-01-08 10:29:38 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=07c68bf55b6a6233a6882675e8b4013b3c3affe8

commit 07c68bf55b6a6233a6882675e8b4013b3c3affe8
Author:     Ferenc Erki <erkiferenc@gmail.com>
AuthorDate: 2022-01-08 10:22:48 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2022-01-08 10:29:24 +0000

    x11-terms/st: add 0.8.5
    
    This reverts commit 2a6d918cc0b6dfcc5d3e2e3af2d510ddd978f7ee.
    
    PR: https://github.com/gentoo/gentoo/pull/18326
    Bug: https://bugs.gentoo.org/592332
    Co-authored-by: Ferenc Erki <erkiferenc@gmail.com>
    Signed-off-by: Ferenc Erki <erkiferenc@gmail.com>
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 x11-terms/st/Manifest        |  1 +
 x11-terms/st/st-0.8.5.ebuild | 75 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 76 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=92126d7ad3a853e5a8854a99842e02c1ac465805

commit 92126d7ad3a853e5a8854a99842e02c1ac465805
Author:     Ferenc Erki <erkiferenc@gmail.com>
AuthorDate: 2022-01-08 10:19:57 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2022-01-08 10:29:23 +0000

    x11-terms/st-terminfo: initial import
    
    This reverts commit 3215a06f5a0b44e99ab9619656f740daa4dbeee4.
    
    PR: https://github.com/gentoo/gentoo/pull/18326
    Bug: https://bugs.gentoo.org/592332
    Co-authored-by: Ferenc Erki <erkiferenc@gmail.com>
    Signed-off-by: Ferenc Erki <erkiferenc@gmail.com>
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 x11-terms/st-terminfo/Manifest                 |  1 +
 x11-terms/st-terminfo/metadata.xml             |  8 ++++
 x11-terms/st-terminfo/st-terminfo-0.8.5.ebuild | 51 ++++++++++++++++++++++++++
 x11-terms/st-terminfo/st-terminfo-9999.ebuild  | 51 ++++++++++++++++++++++++++
 4 files changed, 111 insertions(+)