Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 590690 - media-sound/mixxx-2.0.0-r1 with qt-5.7 and gcc-5.4.0 - error Qt requires a C++11 compiler and yours does not seem to be that.
Summary: media-sound/mixxx-2.0.0-r1 with qt-5.7 and gcc-5.4.0 - error Qt requires a C+...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qt5-c++11
  Show dependency tree
 
Reported: 2016-08-07 13:11 UTC by jospezial
Modified: 2020-08-28 11:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2016-08-07 13:11:00 UTC
x86_64-pc-linux-gnu-g++ -o lin64_build/analyserrg.o -c -march=native -O2 -pipe -pipe -Wall -Wextra -g -fPIC -pthread -O3 -ffast-math -fu
nroll-loops -fomit-frame-pointer -march=native -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_FORMAT_MACROS -Dx86_64 -DMIXXX_BUILD_DEBUG -D__LINUX__ -D__UNIX__ -DSETTINGS_PATH=\".mixxx/\" -DSETTINGS_FILE=\"mixxx.cfg\" -DUNIX_SHARE_PATH=\"/usr/share/mixxx\" -DUNIX_LIB_PATH=\"/usr/lib64/mixxx\" -D__PORTAUDIO__ -DQT_SHARED -DQT_TABLET_SUPPORT -DQT_DISABLE_DEPRECATED_BEFORE -DQT_CORE_LIB -DQT_GUI_LIB -DQT_OPENGL_LIB -DQT_XML_LIB -DQT_SVG_LIB -DQT_SQL_LIB -DQT_SCRIPT_LIB -DQT_NETWORK_LIB -DQT_WIDGETS_LIB -D__SNDFILE__ -D__MAD__ -D__HID__ -D__BULK__ -D__VINYLCONTROL__ -D__SHOUTCAST__ -DQT_NO_DEBUG_OUTPUT -DHAVE_FFTW3 -D__AUTODJCRATES__ -D__SQLITE3__ -D__FFMPEGFILE__ -D__LIBAVRESAMPLE__ -Ilin64_build -Isrc -Ilib/soundtouch-1.8.0 -Ilib/replaygain -I/usr/include/qt5/QtOpenGL -I/usr/include/qt5 -I/usr/include/qt5/QtXml -I/usr/include/qt5/QtSvg -I/usr/include/qt5/QtSql -I/usr/include/qt5/QtScript -I/usr/include/qt5/QtXmlPatterns -I/usr/include/qt5/QtNetwork -I/usr/include/qt5/QtTest -I/usr/include/qt5/QtScriptTools -I/usr/include/qt5/QtWidgets -I/usr/include/qt5/QtGui -I/usr/include/qt5/QtConcurrent -I/usr/include/qt5/QtCore -Ilib/gtest-1.7.0/include -Ilib/fidlib-0.9.10 -I/usr/include/taglib -Ilib/hidapi-0.8.0-rc1/hidapi -I/usr/include/libusb-1.0 -Ilib/xwax -Ilib/scratchlib src/analyserrg.cpp
In file included from /usr/include/qt5/QtCore/qglobal.h:83:0,
                 from /usr/include/qt5/QtCore/qchar.h:43,
                 from /usr/include/qt5/QtCore/qstring.h:48,
                 from /usr/include/qt5/QtCore/QString:1,
                 from src/audiotagger.h:5,
                 from src/audiotagger.cpp:1:
/usr/include/qt5/QtCore/qcompilerdetection.h:562:6: error: #error Qt requires a C++11 compiler and yours does not seem to be that.
 #    error Qt requires a C++11 compiler and yours does not seem to be that.
      ^
In file included from /usr/include/qt5/QtCore/qatomic.h:46:0,
                 from /usr/include/qt5/QtCore/qglobal.h:1145,
                 from /usr/include/qt5/QtCore/qchar.h:43,
                 from /usr/include/qt5/QtCore/qstring.h:48,
                 from /usr/include/qt5/QtCore/QString:1,
                 from src/audiotagger.h:5,
                 from src/audiotagger.cpp:1:
/usr/include/qt5/QtCore/qbasicatomic.h:61:4: error: #error "Qt requires C++11 support"
 #  error "Qt requires C++11 support"
    ^
In file included
...
Comment 1 Coacher 2016-08-08 11:15:18 UTC
Please attach a complete 'build.log' and the output of 'emerge --info'.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-10-19 14:40:14 UTC
commit 4cf05fe4fe0741874905961f5ff6a4da5b4d77b1
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Wed Oct 19 16:38:59 2016

    media-sound/mixxx: Fixed compilation with >=qt-5.7.0 (bug #590690).

    Package-Manager: portage-2.3.2
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
Comment 3 jospezial 2020-08-27 21:48:03 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #2)
> commit 4cf05fe4fe0741874905961f5ff6a4da5b4d77b1
> Author: Lars Wendler <polynomial-c@gentoo.org>
> Date:   Wed Oct 19 16:38:59 2016
> 
>     media-sound/mixxx: Fixed compilation with >=qt-5.7.0 (bug #590690).
> 
>     Package-Manager: portage-2.3.2
>     Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

https://github.com/mixxxdj/mixxx/commit/4883aa3f5a1b98da4abc69584c9f96449548f33a
"Switch from C++11 to C++14"

Please remove or change the fix of this bug.
Comment 4 Miroslav Šulc gentoo-dev 2020-08-28 07:15:33 UTC
(In reply to jospezial from comment #3)
> https://github.com/mixxxdj/mixxx/commit/
> 4883aa3f5a1b98da4abc69584c9f96449548f33a
> "Switch from C++11 to C++14"
> 
> Please remove or change the fix of this bug.

could you please explain what exactly are you suggesting? we don't have version 2.0.0-r1 in the tree anymore and the patch you are referring was committed before 2.2.3 (the lowest version that we have in the tree) was released so i suppose it already contains it.
Comment 5 jospezial 2020-08-28 10:14:57 UTC
(In reply to Miroslav Šulc from comment #4)
> (In reply to jospezial from comment #3)
> > https://github.com/mixxxdj/mixxx/commit/
> > 4883aa3f5a1b98da4abc69584c9f96449548f33a
> > "Switch from C++11 to C++14"
> > 
> > Please remove or change the fix of this bug.
> 
> could you please explain what exactly are you suggesting? we don't have
> version 2.0.0-r1 in the tree anymore and the patch you are referring was
> committed before 2.2.3 (the lowest version that we have in the tree) was
> released so i suppose it already contains it.


The ebuilds we have in the tree still have these lines:

# Required for >=qt-5.7.0 (bug #590690)
	append-cxxflags -std=c++11

Should it be changed to c++14 or removed because upstream now sets it anyway?
Comment 6 jospezial 2020-08-28 10:32:27 UTC
I'm working on a cmake based ebuild for mixxx.
I see -std=gnu++17 in build.log.

sys-devel/gcc-10.2.0-r1
dev-util/cmake-3.18.1
Comment 7 Miroslav Šulc gentoo-dev 2020-08-28 10:47:20 UTC
current scons based 2.2.4 has -std=c++11 and 9999 has -std=c++17 so i will drop it from these two ebuilds to not override their settings.
Comment 8 Larry the Git Cow gentoo-dev 2020-08-28 10:51:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3c6c2085af4e8ad7d46b2a91da0c9cb03f699d9d

commit 3c6c2085af4e8ad7d46b2a91da0c9cb03f699d9d
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2020-08-28 10:51:12 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2020-08-28 10:51:30 +0000

    media-sound/mixxx: 'append-cxxflags -std=c++11' not needed anymore
    
    Closes: https://bugs.gentoo.org/590690
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/mixxx/mixxx-2.2.4.ebuild | 3 ---
 media-sound/mixxx/mixxx-9999.ebuild  | 3 ---
 2 files changed, 6 deletions(-)
Comment 9 jospezial 2020-08-28 11:27:29 UTC
Thank you.

There it is.
https://github.com/mixxxdj/mixxx/commit/24affc9376c2d16d459e2464d0277cbd42880e14
"Switch from C++14 to C++17"