Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 590500 - media-libs/rubberband: race condition in Makefile breaks parallel builds
Summary: media-libs/rubberband: race condition in Makefile breaks parallel builds
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Professional Audio Applications Maintainers
URL: https://bitbucket.org/breakfastquay/r...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-04 18:40 UTC by Coacher
Modified: 2020-09-20 08:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,12.37 KB, text/plain)
2016-08-04 18:41 UTC, Coacher
Details
build-abi_x86_64.amd64.log (build-abi_x86_64.amd64.log,11.53 KB, text/plain)
2016-08-04 18:41 UTC, Coacher
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Coacher 2016-08-04 18:40:42 UTC
Hello.

rubberband's Makefile [1] defines 'all' target as

all:	bin lib $(PROGRAM_TARGET) $(STATIC_TARGET) $(DYNAMIC_TARGET) $(VAMP_TARGET) $(LADSPA_TARGET)

where 'bin' and 'lib' targets are defined as

bin:
	$(MKDIR) $@
lib:
	$(MKDIR) $@


This leads to occasional build failures with enabled parallelism because some
make targets call CXX with '-o' option that points to these 'bin' and 'lib'
directories, e.g. PROGRAM_TARGET and DYNAMIC_TARGET. Build fails when these
directories aren't there yet.

Example build.log is attached.
Note that this problem isn't reproducible in 100% of builds.
I can reproduce it in approximately 1 build out of 5.

Please fix.


[1]: https://bitbucket.org/breakfastquay/rubberband/src/d4911a276d96f6232a68c6b8448056d3946043b9/Makefile.in?at=v1.8.1&fileviewer=file-view-default
Comment 1 Coacher 2016-08-04 18:41:26 UTC
Created attachment 442536 [details]
build.log
Comment 2 Coacher 2016-08-04 18:41:48 UTC
Created attachment 442538 [details]
build-abi_x86_64.amd64.log
Comment 3 Larry the Git Cow gentoo-dev 2020-09-20 08:31:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8edcf54165e5af94c9a59c4ae60704c7561e7557

commit 8edcf54165e5af94c9a59c4ae60704c7561e7557
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2020-09-20 08:30:58 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2020-09-20 08:31:11 +0000

    media-libs/rubberband: bump to 1.9.0
    
    1) added use flags for optional features
    2) organized deps
    
    Closes: https://bugs.gentoo.org/547904
    Closes: https://bugs.gentoo.org/685110
    Closes: https://bugs.gentoo.org/590500
    Package-Manager: Portage-3.0.7, Repoman-3.0.1
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-libs/rubberband/Manifest                |  1 +
 media-libs/rubberband/metadata.xml            |  4 ++
 media-libs/rubberband/rubberband-1.9.0.ebuild | 67 +++++++++++++++++++++++++++
 3 files changed, 72 insertions(+)