Created attachment 441836 [details, diff] myspell-en-20160201.ebuild patch to install hyph_en_US.dic app-dicts/myspell-en-20160201 installs "hyph_en_GB.dic", but not "hyph_en_US.dic". Patch provided. Thanks in advance.
Created attachment 442670 [details, diff] Add a comment about why hyph_en_US.dic is not installed Alright, actually I had LibreOffice uninstalled during this time, and when I tried to reinstall it, it pulled dev-libs/hyphen-2.8.8, which installs the same "/usr/share/hyphen/hyph_en_US.dic" file. I suppose this is why this file wasn't included in myspell-en-20160201.ebuild? There should be a comment in the ebuild about this, so it is not forgotten. Patch added for this. "hyph_en_US.dic" from hyphen-2.8.8 is 104KB, while the one from myspell-en-20160201 is 106KB. There aren't too many different lines, and they seem to come from the same source (Hunspell project). dev-libs/hyphen includes a library though, which may not be desirable for people who don't have LibreOffice or another program using it. Plus it may be hard to find for people thinking myspell-en is all there is. I have no idea how things are handled if both were to be installed with a different version suffix (e.g., the thesaurus files in myspell-en have a '_v2' suffix), to avoid the collision. If it's just a version number, it could be annoying to maintain on the long-term, though, if dev-libs/hyphen sometimes include a version number too, which might collide again with myspell-en. Maybe things should be reversed, with dev-libs/hyphen not installing "hyph_en_US.dic", and depending instead on myspell-en for it, according to future L10N USE flags (neither support L10N for currently).
Hey guys, I'd like some input from dev-libs/hyphen maintainers considering adding hyph_en_US.dic back to myspell-en and this will require changes to be made to dev-libs/hyphen PR: https://github.com/gentoo/gentoo/pull/10220
have had a PR locked up for this for a long time now, hopefully I can get it merged soon
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd8da3ea5bd0c4668e7b9f6d85f9a19dc89d21f2 commit cd8da3ea5bd0c4668e7b9f6d85f9a19dc89d21f2 Author: Gino <onigino@protonmail.com> AuthorDate: 2018-11-12 07:46:12 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2019-07-14 12:41:57 +0000 dev-libs/hyphen-2.8.8: Do not install hyph_en_US.dic file Bug: https://bugs.gentoo.org/589942 Signed-off-by: Gino McCarty <onigino@protonmail.com> Closes: https://github.com/gentoo/gentoo/pull/11820 [mgorny: corrected not to remove docs, fixed EAPI 7] Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-libs/hyphen/hyphen-2.8.8-r1.ebuild | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
https://sources.gentoo.org/repo/gentoo.git/commit/?id=f8d3e086c6ec65bd3ada79097509ead340a9fffe
