Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 589702 - media-video/mpv-0.18.1 - install html documentation separately from pdf
Summary: media-video/mpv-0.18.1 - install html documentation separately from pdf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Coacher
URL: https://github.com/mpv-player/mpv/pul...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-25 19:05 UTC by Chris Mayo
Modified: 2016-08-07 20:37 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mpv-html.patch (mpv-html.patch,1.05 KB, patch)
2016-07-26 13:17 UTC, Coacher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mayo 2016-07-25 19:05:31 UTC
Building html doc only needs dev-python/docutils which is already a mandatory dependency. Currently have to install rst2pdf and get the pdf if you only want the html.

Suggest even always installing mpv.html - it's only one extra file in /usr/share/doc/{PF} (and hopefully html subdirectory, haven't checked where it actually goes - happy to experiment if it would help).
Comment 1 Coacher 2016-07-25 19:13:40 UTC
Sounds legit. I'll do it in the next couple of days.
Comment 2 Chris Mayo 2016-07-26 07:06:08 UTC
Thanks. No hurry.

I realised the lack of html subdirectory is my fault (I submitted the request for building the html file). I'll see if I can get htmldir support added:
https://github.com/mpv-player/mpv/pull/3369
Comment 3 Coacher 2016-07-26 13:17:37 UTC
Created attachment 441624 [details, diff]
mpv-html.patch

(In reply to Chris Mayo from comment #2)
> Thanks. No hurry.
> 
> I realised the lack of html subdirectory is my fault (I submitted the
> request for building the html file). I'll see if I can get htmldir support
> added:
> https://github.com/mpv-player/mpv/pull/3369
Having htmldir option would be very nice. Thanks for creating the PR. I'd like to wait till it's merged and then backport the patch.

In the meantime here's a sed-based solution that's less elegant, but works.
Comment 4 Coacher 2016-07-30 18:30:36 UTC
Upstream merged the required changes several hours ago.
I'll backport them and create a PR for Gentoo tomorrow.
Comment 5 Coacher 2016-07-31 11:51:20 UTC
Gentoo PR: https://github.com/gentoo/gentoo/pull/1987
Comment 6 Patrice Clement gentoo-dev 2016-08-07 20:37:22 UTC
commit 82db6639b4857db498bdb374e1c5b9e4b4026ee7 (HEAD -> master, origin/master, origin/HEAD)
Author:     Ilya Tumaykin <itumaykin@gmail.com>
AuthorDate: Sun Jul 31 14:29:49 2016 +0300
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Sun Aug 7 22:37:00 2016 +0200

media-video/mpv: always install HTML doc in 0.18.1 wrt bug 589702

Gentoo-Bug: https://bugs.gentoo.org/589702
Closes: https://github.com/gentoo/gentoo/pull/1987

Package-Manager: portage-2.3.0

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

.../0.18.1/mpv-0.18.1-add-htmldir-option.patch     |  34 +++
media-video/mpv/mpv-0.18.1-r1.ebuild               | 331 +++++++++++++++++++++
media-video/mpv/mpv-0.18.1.ebuild                  | 329 --------------------
3 files changed, 365 insertions(+), 329 deletions(-)
create mode 100644 media-video/mpv/files/0.18.1/mpv-0.18.1-add-htmldir-option.patch
create mode 100644 media-video/mpv/mpv-0.18.1-r1.ebuild
delete mode 100644 media-video/mpv/mpv-0.18.1.ebuild

Commited, thanks!