589534 – www-client/surf: use of REPLACING_VERSIONS does not account for multiple values

Bug 589534 - www-client/surf: use of REPLACING_VERSIONS does not account for multiple values

Summary: www-client/surf: use of REPLACING_VERSIONS does not account for multiple values

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA
Assignee:	Jeroen Roovers (RETIRED)

URL:
Whiteboard:
Keywords:	QAcanfix

Depends on:
Blocks:	589444
	Show dependency tree

Reported:	2016-07-23 13:07 UTC by Michał Górny
Modified:	2019-02-07 11:16 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2016-07-23 13:07:40 UTC

See the tracker bug.

  if [[ ${REPLACING_VERSIONS} ]] && [[ ${REPLACING_VERSIONS} < 0.4.1-r1 ]]; then

Doesn't account for RV having >1 value. Also, < is lexicographical string comparison, so 10 < 1.

Comment 1 Michał Górny archtester

2016-07-23 13:07:52 UTC

10 < 2*.

Comment 2 Larry the Git Cow gentoo-dev

2019-02-07 11:16:31 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ff50c05fb2a2fcb9e6232267d7360d79acdded1

commit 4ff50c05fb2a2fcb9e6232267d7360d79acdded1
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2019-02-07 11:16:03 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-02-07 11:16:27 +0000

    www-client/surf: Drop pkg_postinst()
    
    Package-Manager: Portage-2.3.59, Repoman-2.3.12
    Closes: https://bugs.gentoo.org/589534
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 www-client/surf/surf-2.0.ebuild | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)