589484 – net-firewall/ufw: use of REPLACING_VERSIONS does not account for multiple values

Bug 589484 - net-firewall/ufw: use of REPLACING_VERSIONS does not account for multiple values

Summary: net-firewall/ufw: use of REPLACING_VERSIONS does not account for multiple values

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA
Assignee:	nvinson234

URL:
Whiteboard:
Keywords:	QAcanfix

Depends on:
Blocks:	589444
	Show dependency tree

Reported:	2016-07-23 12:46 UTC by Michał Górny
Modified:	2016-08-11 06:35 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2016-07-23 12:46:57 UTC

See the tracker bug.

  if [[ -z ${REPLACING_VERSIONS} ]] \
    || [[ ${REPLACING_VERSIONS} < 0.34 ]];
  then

This does not account for RV having >1 value. Furthermore, < is lexicographical string comparison, so 100 < 34 ;-).

Comment 1 Patrice Clement (RETIRED) gentoo-dev

2016-08-11 06:35:24 UTC

commit 7386f397410d6c8d4941d947e8a8ffaa81ac5511 (HEAD -> master, origin/master, origin/HEAD)
Author:     Nicholas Vinson <nvinson234@gmail.com>
AuthorDate: Sat Jul 23 10:40:59 2016 -0700
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Thu Aug 11 08:34:57 2016 +0200

net-firewall/ufw: Properly handle cases where |RV| > 1.

Properly handle cases where REPLACING_VERSIONS has more than 1 element.

Gentoo-Bug: https://bugs.gentoo.org/589484

Package-Manager: portage-2.3.0
Closes: https://github.com/gentoo/gentoo/pull/1946

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

net-firewall/ufw/ufw-0.35.ebuild | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)

Commited, thanks!