Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 589482 - net-firewall/shorewall: use of REPLACING_VERSIONS does not account for multiple values
Summary: net-firewall/shorewall: use of REPLACING_VERSIONS does not account for multip...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Thomas Deutschmann (RETIRED)
URL:
Whiteboard:
Keywords: QAcanfix
Depends on:
Blocks: 589444
  Show dependency tree
 
Reported: 2016-07-23 12:45 UTC by Michał Górny
Modified: 2016-08-03 08:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-07-23 12:45:47 UTC
See the tracker bug.

  if [[ -n "${REPLACING_VERSIONS}" && ${REPLACING_VERSIONS} < ${MY_MAJOR_RELEASE_NUMBER} ]]; then

This doesn't account for RV having >1 value. Furthermore, < is lexicographical string comparison, so 10 < 5.
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2016-08-02 13:04:32 UTC
PR submitted: https://github.com/gentoo/gentoo/pull/2000
Comment 2 Patrice Clement gentoo-dev 2016-08-03 08:04:37 UTC
commit 54f3752b3fb9ded157bdc634cc40998750bca525 (HEAD)
Author:     Thomas Deutschmann <whissi@whissi.de>
AuthorDate: Tue Aug 2 14:59:43 2016 +0200
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Wed Aug 3 10:01:25 2016 +0200

net-firewall/shorewall: Fix REPLACING_VERSIONS usage

Gentoo-Bug: https://bugs.gentoo.org/589482

Package-Manager: portage-2.3.0
Closes: https://github.com/gentoo/gentoo/pull/2000

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

net-firewall/shorewall/shorewall-5.0.10.ebuild  | 40 ++++++++++++++-----------
net-firewall/shorewall/shorewall-5.0.4.ebuild   | 40 ++++++++++++++-----------
net-firewall/shorewall/shorewall-5.0.7.2.ebuild | 40 ++++++++++++++-----------
net-firewall/shorewall/shorewall-5.0.9.2.ebuild | 40 ++++++++++++++-----------
4 files changed, 92 insertions(+), 68 deletions(-)

Commited, thanks!