Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 589448 - app-admin/rsyslog: use of REPLACING_VERSIONS does not account for multiple values
Summary: app-admin/rsyslog: use of REPLACING_VERSIONS does not account for multiple va...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Ultrabug
URL:
Whiteboard:
Keywords: QAcanfix
Depends on:
Blocks: 589444
  Show dependency tree
 
Reported: 2016-07-23 12:08 UTC by Michał Górny
Modified: 2016-08-03 08:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-07-23 12:08:37 UTC
See the tracker bug.

The plain [[ -z is good but...

  if [[ -z "${REPLACING_VERSIONS}" ]] || [[ ${REPLACING_VERSIONS} < 8.0 ]]; then

This is going to cause unexpected behavior when REPLACING_VERSIONS has >1 value. Besides, < is lexicographical string comparison, so e.g. 10.0 < 8.0 will evaluate true.
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2016-08-02 13:10:15 UTC
PR submitted: https://github.com/gentoo/gentoo/pull/2001
Comment 2 Patrice Clement gentoo-dev 2016-08-03 08:17:48 UTC
commit 0b9e6c1961ce0578e0fb916fceb4054f34847602 (HEAD -> master, origin/master, origin/HEAD)
Author:     Thomas Deutschmann <whissi@whissi.de>
AuthorDate: Tue Aug 2 15:09:07 2016 +0200
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Wed Aug 3 10:17:25 2016 +0200

app-admin/rsyslog: Fix REPLACING_VERSIONS usage

We no longer need this check because the previous major version was already
removed in 2015.

Gentoo-Bug: https://bugs.gentoo.org/589448

Package-Manager: portage-2.3.0
Closes: https://github.com/gentoo/gentoo/pull/2001

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

app-admin/rsyslog/rsyslog-8.16.0-r1.ebuild | 9 ---------
app-admin/rsyslog/rsyslog-8.18.0.ebuild    | 9 ---------
app-admin/rsyslog/rsyslog-8.19.0.ebuild    | 9 ---------
3 files changed, 27 deletions(-)

Commited, thanks!