Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588832 - dev-games/aseprite - multiple issues requiring patched media-libs/allegro-4.4
Summary: dev-games/aseprite - multiple issues requiring patched media-libs/allegro-4.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Azamat H. Hackimov
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-14 15:03 UTC by Renato Alves
Modified: 2016-09-14 11:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Alves 2016-07-14 15:03:07 UTC
At the moment dev-games/aseprite, as is included in the portage tree, suffers from a few problems that are known by upstream devs. These include the inability to resize the window which severely hampers the use of the application.

https://github.com/aseprite/aseprite/blob/master/INSTALL.md#linux-issues

The solution by the aseprite developers was to fork and patch allegro-4.4.
As far as I understand these patches have not been accepted upstream because development is continuing with allegro-5. 

Given the situation, would it make sense to include these patches in portage under the control of a custom useflag?

Reproducible: Always
Comment 1 Azamat H. Hackimov 2016-08-02 15:46:08 UTC
Hello.

Situation about aseprite and allegro is bit complicated. Upstream said that allegro backend is outdated and will be removed in the future. Skia backed is still unsupported on Linux, and I'm afraid, after drop allegro support there will be no Linux support at all.

I offered migrate to Allegro 5, where added resizing feature, but since allegro support outdated, this effort are useless.

Adding resize-patch to system allegro has some problems. First, bundled version is not same as system 4.4.2. Second, it's hard distinguish exact changes for proper patch.

I can to enable bundled allegro library via USE, but again, bundled version is not same as system 4.4.2, and there some QA issues exists.
Comment 2 zlg (RETIRED) gentoo-dev 2016-08-23 02:30:39 UTC
In situations like this it seems best to have a 'bundled-libs' USE flag like we do for games on Gentoo. It's not perfect or even ideal, but if it's the difference between a working package and one that only half works, I think we should consider packaging software that works. Keeping it as a USE flag will allow for flexibility later when/if the build system or dependencies change.

Marking as confirmed since I had the same problem with being unable to resize the window (with x11-wm/fluxbox-1.3.7-r3).

I'd be willing to offer assistance in getting this USE flag to fruition if the proxy and/or their developer is willing.
Comment 3 Alexander Berntsen (RETIRED) gentoo-dev 2016-08-23 16:17:49 UTC
(In reply to Azamat H. Hackimov from comment #1)
> after drop allegro support there will be no Linux support at all.
This is false. Skia backend support for GNU+Linux is scheduled for Aseprite 1.2, and deprecation of the Allegro backend is scheduled after that.
Comment 4 Azamat H. Hackimov 2016-08-25 16:22:07 UTC
Created PR https://github.com/gentoo/gentoo/pull/2142
Comment 5 Alexander Berntsen (RETIRED) gentoo-dev 2016-08-31 18:48:47 UTC
Unfortunately, Aseprite is now proprietary software: <https://github.com/aseprite/aseprite/commit/5ecc356a41c8e29977f8608d8826489d24f5fa6c>.
Comment 6 Azamat H. Hackimov 2016-08-31 20:30:34 UTC
Not 1.1.7, only after it.
Comment 7 Alexander Berntsen (RETIRED) gentoo-dev 2016-09-05 17:30:08 UTC
We should use https://github.com/aseprite-gpl/aseprite post-1.1.7.
Comment 8 Patrice Clement gentoo-dev 2016-09-14 11:24:40 UTC
commit c03d1e966a8455897002f7ab108877564af28947 (HEAD)
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: Tue Sep 6 23:20:11 2016 +0500
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Wed Sep 14 13:18:17 2016 +0200

dev-games/aseprite: version bump to 1.1.7.

Added bundled allegro library support for resizing feature.

Gentoo-Bug: https://bugs.gentoo.org/588832

Package-Manager: portage-2.2.28
Closes: https://github.com/gentoo/gentoo/pull/2142

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

dev-games/aseprite/Manifest                        |   1 +
dev-games/aseprite/aseprite-1.1.7.ebuild           | 102 +++++++++++++++++++++
.../files/aseprite-1.1.7_type-punned_pointer.patch |  28 ++++++
dev-games/aseprite/metadata.xml                    |   1 +
4 files changed, 132 insertions(+)
create mode 100644 dev-games/aseprite/aseprite-1.1.7.ebuild
create mode 100644 dev-games/aseprite/files/aseprite-1.1.7_type-punned_pointer.patch

Commited, thanks!