Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 588752 - app-portage/repoman should not return 0 if manifest creation fails
Summary: app-portage/repoman should not return 0 if manifest creation fails
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2016-07-13 13:24 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2022-04-11 20:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-07-13 13:24:29 UTC
$ repoman manifest                                   
>>> Downloading 'http://download.sourceforge.net/kid3/kid3-3.4.1.tar.gz'
--2016-07-13 15:19:38--  http://download.sourceforge.net/kid3/kid3-3.4.1.tar.gz
Resolving download.sourceforge.net (download.sourceforge.net)... 52.85.142.24, 52.85.142.115, 52.85.142.231, ...
Connecting to download.sourceforge.net (download.sourceforge.net)|52.85.142.24|:80... connected.
HTTP request sent, awaiting response... 403 Forbidden
2016-07-13 15:19:38 ERROR 403: Forbidden.

!!! Couldn't download 'kid3-3.4.1.tar.gz'. Aborting.
!!! Fetch failed for kid3-3.4.1.tar.gz, can't update Manifest
Unable to generate manifest.%                                                                                                                                                          $ echo $?         
0



$ emerge --info repoman
Portage 2.3.0 (python 3.5.1-final-0, default/linux/amd64/13.0/desktop/kde, gcc-5.4.0-asneeded, glibc-2.22-r4, 4.6.4 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.6.4-x86_64-AMD_Opteron-tm-_Processor_6328-with-gentoo-2.2
KiB Mem:   131960356 total,  95739084 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Wed, 13 Jul 2016 06:00:01 +0000
Timestamp of repository poly-c: Wed, 13 Jul 2016 10:05:02 +0000
sh dash 0.5.9
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
app-shells/bash:          4.3_p46::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.24.0-r1::gentoo
dev-lang/python:          2.7.11-r2::gentoo, 3.4.4::gentoo, 3.5.1-r3::gentoo
dev-util/cmake:           3.6.0::gentoo
dev-util/pkgconfig:       0.29.1::gentoo
sys-apps/baselayout:      2.2-r1::gentoo
sys-apps/openrc:          0.21.2::gentoo
sys-apps/sandbox:         2.11-r2::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r2::gentoo
sys-devel/automake:       1.9.6-r4::gentoo, 1.10.3-r2::gentoo, 1.11.6-r2::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r2::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            5.4.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r2::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.3::gentoo (virtual/os-headers)
sys-libs/glibc:           2.22-r4::gentoo
Repositories:

gentoo
    location: /var/portage
    sync-type: rsync
    sync-uri: rsync://192.168.0.254/gentoo-portage
    priority: -1000

kde-sunset
    location: /var/lib/layman/kde-sunset
    masters: gentoo
    priority: 0

palemoon
    location: /var/lib/layman/palemoon
    masters: gentoo
    priority: 1

poly-c
    location: /usr/local/portage
    masters: gentoo
    priority: 2

Installed sets: @system
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -mtune=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/themes/oxygen-gtk/gtk-3.0"
CONFIG_PROTECT_MASK="/etc/X11/Sessions /etc/X11/app-defaults /etc/X11/xinit /etc/adobe /etc/bonobo-activation /etc/ca-certificates /etc/ca-certificates.conf /etc/dbus-1 /etc/dconf /etc/env.d /etc/fonts /etc/fonts/fonts.conf /etc/foomatic /etc/games /etc/gconf /etc/gentoo-release /etc/gimp /etc/gnome-vfs-2.0 /etc/gre.d /etc/gtk-2.0 /etc/hp /etc/hsqldb /etc/htdig /etc/init.d /etc/iproute2 /etc/java-config-2 /etc/lftp /etc/logrotate.d /etc/ntop /etc/opt /etc/pango /etc/profile.d /etc/qt4 /etc/revdep-rebuild /etc/sandbox.d /etc/sasl2 /etc/sensors.d /etc/sgml /etc/sound /etc/ssl /etc/ssmtp /etc/t1lib /etc/terminfo /etc/vbox /etc/xdg /etc/xinetd.d /etc/xml"
CXXFLAGS="-march=native -mtune=native -O2 -pipe"
DISTDIR="/home/polynomial-c/temp/distfiles"
EMERGE_DEFAULT_OPTS="--alphabetical --with-bdeps=y --misspell-suggestions=n --autounmask=n --quiet-build=n --verbose-slot-rebuilds=n"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms sign strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS=""
INSTALL_MASK="/etc/systemd /lib/systemd /lib32/systemd /lib64/systemd /usr/lib/systemd /usr/lib32/systemd /usr/lib64/systemd /etc/init.d/functions.sh"
LANG="de_DE.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--hash-style=gnu -Wl,--sort-common -Wl,--as-needed"
MAKEOPTS="-j16"
PKGDIR="/opt/portage/packages"
PORTAGE_BZIP2_COMMAND="lbzip2 -q"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="3dnow 3dnowext X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 c++0x cairo caps cdda cdr cli consolekit cracklib crypt css cups cxx dbus declarative dri dts dvd dvdr emboss encode exif faac ffmpeg firefox flac gdbm gif glamor gles2 gmp gnutls gstreamer gtk iconv icu idn imagemagick inotify jpeg jpeg2k kde kipi lame lcms libcanberra libnotify lzma mac mad matroska midi mmap mmx mmxext mng modules mp3 mp4 mpeg mpfr multilib ncurses nls nptl nsplugin ogg opengl openmp opus pam pango pcre pdf phonon plasma png policykit ppds pulseaudio qt3support qt4 quicktime readline rtmp schroedinger sdl seccomp session slang speex spell sse sse2 ssl startup-notification svg theora threads tiff truetype twolame udev udisks unicode upower usb vaapi vcd vdpau vorbis vpx wxwidgets x264 x265 xattr xcb xcomposite xinerama xml xscreensaver xv xvid xvmc zlib zsh-completion" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="access_compat alias auth_basic auth_digest authn_anon authn_core authn_default authn_file authz_core authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dir env file_cache filter headers http2 include info log_config mime mime_magic rewrite socache_shmcb status unique_id unixd userdir vhost_alias" CPU_FLAGS_X86="aes avx fma3 fma4 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3 xop" CURL_SSL="gnutls" ELIBC="glibc" GRUB_PLATFORMS="pc" INPUT_DEVICES="evdev joystick" KERNEL="linux" L10N="de en" LIBREOFFICE_EXTENSIONS="pdfimport presenter-console presenter-minimizer" LINGUAS="de en" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python3_4" PYTHON_TARGETS="python2_7 python3_4 python3_5" RUBY_TARGETS="ruby22 ruby23" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi"
USE_PYTHON="2.7 3.4 3.5"
Unset:  CC, CPPFLAGS, CTARGET, CXX, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

app-portage/repoman-2.3.0::poly-c was built with the following:
USE="" ABI_X86="64" PYTHON_TARGETS="-pypy python2_7 -python3_3 python3_4 python3_5"
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-10-26 09:57:02 UTC
ping. Come on guys, this is a minor issue and I doubt it's hard to fix.
Comment 2 Larry the Git Cow gentoo-dev 2018-10-27 21:29:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=91a9c2da33802f1f71e669bffc7ce940b9f6d450

commit 91a9c2da33802f1f71e669bffc7ce940b9f6d450
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2018-10-27 20:42:16 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-10-27 21:27:44 +0000

    repoman: fix exit code for manifest mode (bug 588752)
    
    When manifest generation fails, report "manifest.bad" violations.
    
    Reported-by: Lars Wendler <polynomial-c@gentoo.org>
    Bug: https://bugs.gentoo.org/588752
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 repoman/bin/repoman                            |  2 +-
 repoman/lib/repoman/main.py                    |  9 +++++----
 repoman/lib/repoman/modules/commit/manifest.py | 11 ++++-------
 repoman/lib/repoman/scanner.py                 |  3 ++-
 4 files changed, 12 insertions(+), 13 deletions(-)
Comment 3 Zac Medico gentoo-dev 2018-10-27 21:30:25 UTC
Thanks for reporting!
Comment 4 Zac Medico gentoo-dev 2018-11-04 03:50:23 UTC
The bug has been referenced by via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0946d42b3e2877ac97ae8f6cdcfa3e5244cb8f5a

commit 0946d42b3e2877ac97ae8f6cdcfa3e5244cb8f5a
Author: Zac Medico <zmedico@gentoo.org>
Date:   2018-11-03 20:25:07 -0700

    app-portage/repoman: version bump to 2.3.12
    
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    Signed-off-by: Zac Medico <zmedico@gentoo.org>