Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 587382 - games-emulation/dosbox should deprecate games and use EAPI 6
Summary: games-emulation/dosbox should deprecate games and use EAPI 6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mr. Bones. (RETIRED)
URL:
Whiteboard:
Keywords: QAcanfix
Depends on:
Blocks: games.eclass
  Show dependency tree
 
Reported: 2016-06-28 08:42 UTC by Austin English (RETIRED)
Modified: 2016-06-29 22:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Austin English (RETIRED) gentoo-dev 2016-06-28 08:42:43 UTC
I'm preparing a pull request for review as I type this..
Comment 1 Austin English (RETIRED) gentoo-dev 2016-06-28 08:44:32 UTC
https://github.com/gentoo/gentoo/pull/1777

I'll commit this in 1 week unless there are technical objections raised here.
Comment 2 Patrice Clement gentoo-dev 2016-06-28 14:00:12 UTC
commit 3d239d4e470c8f0c99339649ec74c4bdf86cf98f (HEAD -> master, origin/master, origin/HEAD)
Author:     Austin English <wizardedit@gentoo.org>
AuthorDate: Tue Jun 28 03:43:09 2016 -0500
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Tue Jun 28 13:31:36 2016 +0000

games-emulation/dosbox: remove games eclass and convert to EAPI 6

Gentoo-Bug: https://bugs.gentoo.org/566498
Gentoo-Bug: https://bugs.gentoo.org/587382

Package-Manager: portage-2.2.28
Closes: https://github.com/gentoo/gentoo/pull/1777

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

games-emulation/dosbox/dosbox-0.74-r2.ebuild | 46 ++++++++++++++++++++++++++++++++++++++++++++++
games-emulation/dosbox/dosbox-9999.ebuild    | 12 ++++++------
2 files changed, 52 insertions(+), 6 deletions(-)
create mode 100644 games-emulation/dosbox/dosbox-0.74-r2.ebuild
Comment 3 Austin English (RETIRED) gentoo-dev 2016-06-28 23:50:52 UTC
(In reply to Patrice Clement from comment #2)
> commit 3d239d4e470c8f0c99339649ec74c4bdf86cf98f (HEAD -> master,
> origin/master, origin/HEAD)
> Author:     Austin English <wizardedit@gentoo.org>
> AuthorDate: Tue Jun 28 03:43:09 2016 -0500
> Commit:     Patrice Clement <monsieurp@gentoo.org>
> CommitDate: Tue Jun 28 13:31:36 2016 +0000
> 
> games-emulation/dosbox: remove games eclass and convert to EAPI 6
> 
> Gentoo-Bug: https://bugs.gentoo.org/566498
> Gentoo-Bug: https://bugs.gentoo.org/587382
> 
> Package-Manager: portage-2.2.28
> Closes: https://github.com/gentoo/gentoo/pull/1777
> 
> Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
> 
> games-emulation/dosbox/dosbox-0.74-r2.ebuild | 46
> ++++++++++++++++++++++++++++++++++++++++++++++
> games-emulation/dosbox/dosbox-9999.ebuild    | 12 ++++++------
> 2 files changed, 52 insertions(+), 6 deletions(-)
> create mode 100644 games-emulation/dosbox/dosbox-0.74-r2.ebuild

This was reverted:
https://github.com/gentoo/gentoo/commit/7efcd72291ba745978e8a02ca0ac6f8c07434a38
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2016-06-29 04:03:32 UTC
Seems like a subset of bug 566498

*** This bug has been marked as a duplicate of bug 566498 ***
Comment 5 Pacho Ramos gentoo-dev 2016-06-29 10:56:03 UTC
If the Council agreed on killing games.eclass and the handling of games groups... why not start the migration accepting commits like this? Reverting this for later needing to reinclude a similar change is only causing to duplicate the efforts :/
Comment 6 Austin English (RETIRED) gentoo-dev 2016-06-29 22:35:46 UTC
(In reply to Pacho Ramos from comment #5)
> If the Council agreed on killing games.eclass and the handling of games
> groups... why not start the migration accepting commits like this? Reverting
> this for later needing to reinclude a similar change is only causing to
> duplicate the efforts :/

https://github.com/gentoo/gentoo/commit/5edb412a63031c0372093d5e5fb038e5da4f52f1
https://github.com/gentoo/gentoo/commit/b252a3bd07e923b507c7eddb72656834033b5ba4