Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 585224 - app-eselect/eselect-java - No highilighting for currently selected maven package when running "eselect maven list"
Summary: app-eselect/eselect-java - No highilighting for currently selected maven pac...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-06 21:28 UTC by pierigno
Modified: 2018-03-04 12:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
tentative patch for maven.eselect.in (fix-do_list.patch,740 bytes, patch)
2016-06-06 21:29 UTC, pierigno
Details | Diff
fix-maven-do_list.patch (0001-fix-maven-do_list.patch,753 bytes, patch)
2016-06-07 10:16 UTC, pierigno
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pierigno 2016-06-06 21:28:22 UTC
Current maven eselect module fails to highlight which maven version is "(eselect)ed".

The culprit is in do_list function in src/modules/eselect.maven.in file and the fix is really simple (a tentative patch is attached). 

It may also fix or be a workaround for https://bugs.gentoo.org/show_bug.cgi?id=549498


Reproducible: Always
Comment 1 pierigno 2016-06-06 21:29:56 UTC
Created attachment 436724 [details, diff]
tentative patch for maven.eselect.in
Comment 2 Austin English (RETIRED) gentoo-dev 2016-06-07 01:02:35 UTC
(In reply to pierigno from comment #1)
> Created attachment 436724 [details, diff] [details, diff]
> tentative patch for maven.eselect.in

Why did you remove the quotes around the subshell?
Comment 3 pierigno 2016-06-07 10:16:31 UTC
Created attachment 436754 [details, diff]
fix-maven-do_list.patch

While inspecting, I removed the quotes because I thought they were messing with the basename subshell and were reduntant. 

I realize now that they weren't and that in $(command1 "$(command2)"), "$(command2)" and may be also the result of multiple strings concatenation.


The patch quotes subshell for readlink and substitutes previous patch
Comment 4 Larry the Git Cow gentoo-dev 2018-03-04 12:07:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=12b1e1135f89f04d2d12d2df862cf27cb08c6ea0

commit 12b1e1135f89f04d2d12d2df862cf27cb08c6ea0
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2018-03-04 12:04:53 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2018-03-04 12:06:19 +0000

    app-eselect/eselect-java: 0.4.0 stable on ppc64, x86 using ALLARCHES
    
    Closes: https://bugs.gentoo.org/649506
    Closes: https://bugs.gentoo.org/549498
    Closes: https://bugs.gentoo.org/585224
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 app-eselect/eselect-java/eselect-java-0.4.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)