Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 582714 - net-fs/nfs-utils: warn if client tracking will be broken
Summary: net-fs/nfs-utils: warn if client tracking will be broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-05-11 05:16 UTC by Matt Whitlock
Modified: 2019-09-02 07:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Whitlock 2016-05-11 05:16:23 UTC
NFSDv4 supports client tracking across server restarts using two methods. The legacy method is in-kernel and requires CONFIG_CRYPTO_MD5, which is not automatically selected by CONFIG_NFSD_V4 (see https://bugzilla.kernel.org/show_bug.cgi?id=52271). The newer method involves a usermode helper upcall program (nfsdcltrack), which is built and installed only when USE="nfsdcld". If neither method is available, then the NFS server does not support tracking clients across restarts, and it emits a warning to the kernel log:

NFSD: unable to generate recoverydir name (-2).
NFSD: disabling legacy clientid tracking. Reboot recovery will not function correctly!

I have created a pull request that introduces an ewarn in pkg_setup to warn the user if their configuration will not support client tracking due to neither of these options being enabled.

Please merge: https://github.com/gentoo/gentoo/pull/1448
Comment 1 Matt Turner gentoo-dev 2019-09-02 05:29:15 UTC
Thank you. It's clear you did a lot of work to come up with this. Thank you for wrapping all of that up in a nice little patch!
Comment 2 Larry the Git Cow gentoo-dev 2019-09-02 07:08:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b2d7c955a8b3c0c422780d25bc2b1355f37df25

commit 5b2d7c955a8b3c0c422780d25bc2b1355f37df25
Author:     Matt Whitlock <gentoo@mattwhitlock.name>
AuthorDate: 2016-05-11 00:32:58 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2019-09-02 07:08:13 +0000

    net-fs/nfs-utils: warn if client tracking will be broken
    
    NFSDv4 supports client tracking across server restarts using two
    methods. The legacy method is in-kernel and requires CONFIG_CRYPTO_MD5,
    which is not automatically selected by CONFIG_NFSD_V4 (see
    https://bugzilla.kernel.org/show_bug.cgi?id=52271). The newer method
    involves a usermode helper upcall program (nfsdcltrack), which is built
    and installed only when USE="nfsdcld". If neither method is available,
    then the NFS server does not support tracking clients across restarts,
    and it emits a warning to the kernel log:
    
    NFSD: unable to generate recoverydir name (-2).
    NFSD: disabling legacy clientid tracking. Reboot recovery will not function correctly!
    
    This commit introduces an ewarn in pkg_setup to warn the user if their
    configuration will not support client tracking due to neither of these
    options being enabled.
    
    Closes: https://github.com/gentoo/gentoo/pull/1448
    Closes: https://bugs.gentoo.org/582714
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 net-fs/nfs-utils/nfs-utils-2.4.1.ebuild | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)