Proper build of dev-util/electron is now in the tree (#579116), which makes it possible to rebuild Atom properly, i.e. without the use of precompiled blobs and with proper library unbundling. The strategy used in this build is to take the upstream release build and recompile the native module portions against the system Electron and system libraries. The ebuild is available in the atom overlay: https://github.com/elprans/atom-overlay/blob/master/app-editors/atom/atom-1.7.3.ebuild
Ebuild: https://github.com/elprans/atom-overlay/blob/master/app-editors/atom/atom-1.7.3.ebuild I see from the PR that the user wishes to co-maintain atom as he added himself to metadata.xml. Elvis Pranskevichus, you should first ask about this the current app-editors/atom maintainer Heather Cynede.
Elvis Pranskevichus, your PR/ebuild in its current form has some questionable changes. I've highlighted some of them in the PR comments. I suggest you to work closely with Heather to resolve these and other possible problems.
(In reply to Coacher from comment #2) > Elvis Pranskevichus, your PR/ebuild in its current form has some > questionable changes. I've highlighted some of them in the PR comments. I > suggest you to work closely with Heather to resolve these and other possible > problems. Certainly, most of those changes have a valid reason. Bear in mind that this is an entirely new ebuild, with a different build approach, based on a proper build of electron. This is in contrast to the current ebuild, which pulls precompiled binaries from Github.
Elvis, Thanks for the PR. Your approach is legit and we much prefer building packages from source. Could you provide a build.log for this new ebuild? Thank you.
Created attachment 433788 [details] build.log
Thanks for the log. Your PR lgtm and so does the build. Let's merge your contribution.
commit 35a0f25a84b32b2f15b5d115aa607db4020cc55b (HEAD -> master) Author: Elvis Pranskevichus <elvis@magic.io> AuthorDate: Sun May 8 12:35:08 2016 -0400 Commit: Patrice Clement <monsieurp@gentoo.org> CommitDate: Tue May 10 11:12:16 2016 +0000 app-editors/atom: Switch to using dev-util/electron, recompile binaries and unbundle libraries. Proper build of dev-util/electron is now in the tree (#579116), which makes it possible to rebuild Atom properly, i.e. without the use of precompiled blobs and with proper library unbundling. The strategy used in this build is to take the upstream release build and recompile the native module portions against the system Electron and system libraries. Gentoo-Bug: https://bugs.gentoo.org/582462 Package-Manager: portage-2.2.28 Closes: https://github.com/gentoo/gentoo/pull/1430 Signed-off-by: Patrice Clement <monsieurp@gentoo.org> app-editors/atom/Manifest | 28 ++++++++- app-editors/atom/atom-1.7.3.ebuild | 388 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------- app-editors/atom/files/atom-unbundle-electron.patch | 45 ++++++++++++++ app-editors/atom/files/gyp-unbundle.py | 123 ++++++++++++++++++++++++++++++++++++ app-editors/atom/metadata.xml | 8 +++ 5 files changed, 538 insertions(+), 54 deletions(-) create mode 100644 app-editors/atom/files/atom-unbundle-electron.patch create mode 100644 app-editors/atom/files/gyp-unbundle.py Thanks!
Great! Thanks for merging! This probably warrants the review and closure of the following bugs as well: #517056, #579184, #579896, #580476, #581808, and #581986.
