go-mode.el[1] is the Emacs mode for editing Go code. From its README: > It is a complete rewrite of the go-mode that shipped with Go 1.0.3 and before, > and was part of Go 1.1 until Go 1.3. Beginning with Go 1.4, editor integration > will not be part of the Go distribution anymore, making this repository the > canonical place for go-mode. Please see pull request[2] on github. Since current master is quiet ahead of last release of go-mode.el (1.3.1), I've added 9999 ebuild too. [1] https://github.com/dominikh/go-mode.el [2] https://github.com/gentoo/gentoo/pull/1428
User wishes to proxy maintain this package. CC'ing proxy-maint team.
Hello emacs folks Could you kindly review this package and the PR attached to it? Thanks for your help.
Comments: 1. The package includes some documentation which should be installed. Please add DOCS="AUTHORS NEWS README.md" 2. (very minor) For uniformity throughout the app-emacs category, the S, SITEFILE, and DOCS variables should be assigned in this order and in one block. 3. dev-lang/go might profit from a runtime dependency on go-mode (conditional on the "emacs" USE flag).
And I've missed another issue: 4. v${PV}.tar.gz is not a suitable name for a distfile. Please use an appropriate SRC_URI arrow. (In reply to Victor from comment #0) > Since current master is quiet ahead of last release of go-mode.el (1.3.1), > I've added 9999 ebuild too. Better would be to ask upstream to make a new release.
> 1. The package includes some documentation which should be installed. > Please add DOCS="AUTHORS NEWS README.md" Fixed. > 2. (very minor) For uniformity throughout the app-emacs category, the S, > SITEFILE, and DOCS variables should be assigned in this order and in one > block. Fixed. > 3. dev-lang/go might profit from a runtime dependency on go-mode > (conditional on the "emacs" USE flag). Should I add new revision of dev-lang/go ebuild in this PR? (go-1.6-r3?) > 4. v${PV}.tar.gz is not a suitable name for a distfile. Please use an > appropriate SRC_URI arrow. Fixed. > > Since current master is quiet ahead of last release of go-mode.el > > (1.3.1) I've added 9999 ebuild too. > > Better would be to ask upstream to make a new release. I think it's planned but not yet released. See [1]. See also [2]: > go-mode.el has regular, tagged releases and is part of the MELPA Stable > repository. These tagged releases are intended to provide a stable > experience. [...] > If you want a stable experience, use MELPA Stable. If you want cutting > edge features, or "beta-test" future releases, use MELPA or the master > branch. As for me, I'm using its master branch. [1] https://github.com/dominikh/go-mode.el/blob/master/NEWS#L1 [2] https://github.com/dominikh/go-mode.el#stability
I'm also getting this warning when installing ebuild: > * Compiling GNU Emacs Elisp files ... > In toplevel form: > go-mode.el:16:1:Warning: cl package required at runtime What does it mean? go-mode.el contains "(require 'cl)", but what's wrong with it? PS. There is no "NEWS" file in 1.3.1, so I added it only in 9999 ebuild.
(In reply to Victor from comment #6) > I'm also getting this warning when installing ebuild: > > > * Compiling GNU Emacs Elisp files ... > > In toplevel form: > > go-mode.el:16:1:Warning: cl package required at runtime > > What does it mean? go-mode.el contains "(require 'cl)", but what's wrong > with it? It is recommended to use either "(eval-when-compile (require 'cl))" if only CL macros are used, or "(require 'cl-lib)" for CL functions. The warning is harmless, so normally we don't fix this for the Gentoo package but report it upstream. Here it looks like it is fixed upstream already: https://github.com/dominikh/go-mode.el/commit/bdf353a5992ce493d6f6510f442384cdae155e58 (In reply to Victor from comment #5) > > 3. dev-lang/go might profit from a runtime dependency on go-mode > > (conditional on the "emacs" USE flag). > > Should I add new revision of dev-lang/go ebuild in this PR? (go-1.6-r3?) Good question. Maybe it is better to file a separate bug for it, after app-emacs/go-mode has been added to the tree. CCing Go maintainer. William, what is your advice here?
To summarise: 1. go-mode-1.3.1.ebuild can be merged to the tree. 2. I still think that we shouldn't have a live ebuild for this package. If you believe that the master branch offers a large enough advantage over stable, then either ask upstream for a new release, or make a snapshot and provide an ebuild for it. (Name should be go-mode-1.3.1_pYYYYMMDD where YYYYMMDD is the UTC date of the last upstream commit included in the snapshot.) 3. Adding a dependency to dev-lang/go can be done later, so no need to include it in the PR.
(In reply to Ulrich Müller from comment #8) > To summarise: > > 1. go-mode-1.3.1.ebuild can be merged to the tree. > > 2. I still think that we shouldn't have a live ebuild for this package. If > you believe that the master branch offers a large enough advantage over > stable, then either ask upstream for a new release, or make a snapshot and > provide an ebuild for it. (Name should be go-mode-1.3.1_pYYYYMMDD where > YYYYMMDD is the UTC date of the last upstream commit included in the > snapshot.) > > 3. Adding a dependency to dev-lang/go can be done later, so no need to > include it in the PR. go-mode author have released 1.4.0[1] just now, so I removed 1.3.1 and 9999 and added 1.4.0, please see updated PR. [1] https://github.com/dominikh/go-mode.el/releases/tag/v1.4.0
commit 94ea431c4451cfec60df149fe20422133fae7efd Author: Victor Gaydov <victor@enise.org> Date: Sun May 8 12:06:40 2016 +0300 app-emacs/go-mode: new package / ebuild initial version 1.4.0, live ebuild prepared but abandonned entered under supervision of both the Gentoo GNU Emacs and Proxy Maintainers projects initial patches and discussion presented via the Gentoo-bug: #582434 Package-Manager: portage-2.2.28 Closes: https://github.com/gentoo/gentoo/pull/1428
Created attachment 766419 [details] ebuild
Created attachment 766420 [details] ebuild files
Upstream made a lot of changes and no version bump for long time.
Thanks for your contribution. Instead of using git-r3 to clone the sources, I think it would be better to create a snapshot tarball. I'll try and do that today.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ee53e4e6f8a57b79cb9120501d720eb0790a8a9 commit 5ee53e4e6f8a57b79cb9120501d720eb0790a8a9 Author: Matthew Smith <matthew@gentoo.org> AuthorDate: 2022-03-06 15:04:35 +0000 Commit: Matthew Smith <matthew@gentoo.org> CommitDate: 2022-03-06 15:06:25 +0000 app-emacs/go-mode: add 1.6.0 Also bump to EAPI 8 and run the provided tests. Bug: https://bugs.gentoo.org/582434 Suggested-by: Alessandro Di Marco <dmr@ethzero.com> Signed-off-by: Matthew Smith <matthew@gentoo.org> app-emacs/go-mode/Manifest | 1 + app-emacs/go-mode/files/50go-mode-1.6.0-gentoo.el | 2 + app-emacs/go-mode/go-mode-1.6.0.ebuild | 47 +++++++++++++++++++++++ 3 files changed, 50 insertions(+)
