Created attachment 432038 [details] scite-3.6.5.ebuild a new bugfix release is available. It compiles fine on amd64. Just like to hint on bug #577882 which, seems to me, isn't recognized yet. ervin
Created attachment 432048 [details] build.log Hi Ervin! I have run some tests on this and it seems to be failing (build.log attached). This happens for both USE=lua and USE=-lua. This testing is performed in a minimal testing environment, so is likely caused by a missing dependency. Also, there are a couple of further points that I will mention: The `cd`'s in src_prepare() are missing "|| die" statements, however they could even be entirely removed and instead specify the full path in the `sed` statements: > sed -i "${WORKDIR}/scintilla/gtk/makefile" \ > ... Also, this ebuild could likely be bumped to EAPI6[0] (though note that it will also need a couple of other minor changes (such as adding `eapply_user` to src_prepare() or calling `default`) if bumping EAPI). Can you have a look at these and attach a fixed ebuild? If you have any questions, feel free to ask. [0] https://projects.gentoo.org/pms/6/pms.html#x1-175000E Thanks!
Also, with regards to bug 577882, it is preferred that stable candidates not have any open bugs for 30-days before stabilisation; so you may want to have a look at bug 569986 and see if you can address that one. Once all significant bugs are closed, you can proceed with stabilisation by adding a comment noting which target arches you wish to stabilise on and CC'ing the relevant arch teams. See the wiki[0] for details. :) [0] https://devmanual.gentoo.org/keywording/#moving-from-~arch-to-arch
> build error ----from the attached build.log---- Package gtk+-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `gtk+-2.0.pc' to the PKG_CONFIG_PATH environment variable No package 'gtk+-2.0' found ----from the attached build.log---- Problem: >=x11-libs/gtk+-2.0:* installs gtk+-3 - would not work. I changed it to x11-libs/gtk+:2 I think the slot operator is the right way, isn't it? ervin
Created attachment 432874 [details] scite-3.6.5.ebuild updated ebuild
Created attachment 432898 [details] updates scite-3.6.5.ebuild to respect Cxx flags Trying to adress bug #569986 i updated the ebuild againsrc_compile() { emake CC="$(tc-getCC)" LD="$(tc-getLD)" \ LDFLAGS="$(raw-ldflags)" AR="$(tc-getAR)" \ -C "${WORKDIR}/scintilla/gtk" Are there any ressources to read how to QA checks like this issue? ervin
Created attachment 432900 [details] scite-3.6.5.ebuild again to mark old as obsolete
(In reply to Ervin Peters from comment #4) > Created attachment 432874 [details] > scite-3.6.5.ebuild > > updated ebuild Ervin Peters, while, in src_install emake prefix="${ED}/usr" install works, it is in gentoo terms rather ugly and non preferred. Please substitute this and previous ebuilds with emake DESTDIR="${D}" install within src_install. I can bump it then.
Created attachment 433062 [details] updatet scite-3.5.5-r1 ebuild ebuild update to fix OA and cosmetic issues as discussed
Created attachment 433066 [details] updatet scite-3.6.2-r1 ebuild ebuild update to fix OA and cosmetic issues as discussed
Created attachment 433068 [details] updatet scite-3.6.4-r1 ebuild ebuild update to fix OA and cosmetic issues as discussed
Created attachment 433070 [details] scite-3.6.5.ebuild ebuild update to fix OA and cosmetic issues as discussed
Hi Ervin; I've had a look at this and the only comment I can make is that all the variables in src_install() should be either ${D} or ${ED}, not a mix of either. In many cases they will expand to the same thing, however in some cases they won't. For reference, ${ED} is a compound of ${D} and ${EPREFIX}[0]. This can be fixed as it's committed since it's such a small change. Otherwise, this passes my tests, so I will commit it now for you. Thanks! [0] https://devmanual.gentoo.org/eclass-reference/ebuild/#lbAF
commit 88d0ed8b93254c34bbc3cda51b666f5f7a75a2ab Author: Ervin Peters <ervin.peters@ervnet.de> AuthorDate: Tue May 3 20:53:44 2016 +1000 Commit: Sam Jorna <wraeth@gentoo.org> CommitDate: Tue May 3 20:54:46 2016 +1000 app-editors/scite: bump to 3.6.5 Version bump to 3.6.5, bump to EAPI6, fixes build with ${CC}. Gentoo-bug: 581220 Package-Manager: portage-2.2.28
