With the current version xmms stays displayed on the task bar when the xmms-status-plugin is used -- kind of defeats the purpose of using the xmms-status-plugin. (unless everyone install kstart). Seems to work here, limited testing.
Created attachment 35827 [details, diff] patch to src/main.c Needs a better name
Created attachment 35828 [details] Update ebuild (one liner actually) Added epatch line
messes the relative positioning of the windows (main/playlist/eq) a bit when toggling --look into that.
Rob, any luck looking into the relative position problem?
Not yet. Basically, the main window (with the patch) doesn't remember the old position and gets relocated by the autoplacement of my WM (xfwm) where as the eq and playlists still remember their postitions -- they aren't using the gtk_widget_close/hide.... yet. I guess it also ruins the ability to get XMMS pop up in a set location on your desktop. I'll keep at it and let you know -- I'm definitly not at gtk programer (really my first look at it). Ideally, it would be good to be able to pass a window manager hint to remove from the task bar but AFAIK it is little more difficult with GTK++ (vs gtk2). I've taken a quick look at the sylpheed-claws tray-icon plugin, but they have a completely different setup for their windows and window properties.
Created attachment 35943 [details, diff] Updated patch See how this works on with other wm.... Seem to work fine here, with or without the plugin activated.
hmm... I'm scared about the whole hide section there... there's probably a reason they didn't do it that way... I'll take a look at it, but I'd like to get some feedback from the xmms devs themselves... do you think you could open up an upstream bug for this and let me know the URL? Or have you talked about this on an xmms list which is archived somewhere?
Nope, just something I looked into 'cause it bugged me. I'll file an upstream bug and keep you posted. It is actually code adapted from their playlist window and equalizer window (they both use the similar code -- using the widget show/hide). From what I undestand of the original code, it was a fake hide that that they did by resizing the window to 0x0, unless the window manager decorations were turned on -- where they used the widget_hide. It could also use some testing I guess on other window managers -- maybe a system with only gtk+1 as well.
did you open a bug with this info upstream at bugs.xmms.org? Can you please tell me the bug URL... thanks.
Sorry for the delay -- bug #1887 http://bugs.xmms.org/show_bug.cgi?id=1887
in forthcoming -r6.
