Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 577148 - app-portage/metagen: Unconditionally uses herds.xml which no longer exists
Summary: app-portage/metagen: Unconditionally uses herds.xml which no longer exists
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jesus Rivero (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-12 14:10 UTC by Adam Feldman
Modified: 2016-06-23 22:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Feldman gentoo-dev 2016-03-12 14:10:59 UTC 
herds.xml has been removed.  The latest metagen currently unconditionally references the file as if it still exists. 

Traceback (most recent call last):
  File "/usr/lib/python-exec/python2.7/metagen", line 35, in <module>
    HB = herdbase.make_herd_base(os.path.sep.join([PORTDIR, 'metadata', 'herds.xml']))
  File "/usr/lib64/python2.7/site-packages/repoman/checks/herds/herdbase.py", line 81, in make_herd_base
    raise FileNotFound(filename)
portage.exception.FileNotFound: /var/lib/repos/gentoo/metadata/herds.xml
Comment 1 Sebastian Pipping gentoo-dev 2016-03-14 21:40:36 UTC 
Is my understanding correct that all herd-related code should be removed from metagen?
Comment 2 Adam Feldman gentoo-dev 2016-03-15 12:33:46 UTC 
(In reply to Sebastian Pipping from comment #1)
> Is my understanding correct that all herd-related code should be removed
> from metagen?

Eventually, yes.  When you choose to drop support for backwards compatibility (like derivatives/overlays that still maintain one) is up to you.  At least for now though, at a minimum, the herd related code should only be run if the herds.xml file exists on the system.
Comment 3 Matthew Marchese Gentoo Infrastructure gentoo-dev 2016-06-23 18:58:11 UTC 
I can also confirm missing herds.xml causes metagen to crash. Was able to reproduce on my system by installing metagen and running `metagen`. :)