Bug 576748 – media-video/mpv-0.16: too much output from pkg_pretend

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Patrick Lauer 2016-03-08 08:57:05 UTC]

The pkg_pretend function is doing things it shouldn't:
>
>pkg_pretend() {
>        if [[ ${MERGE_TYPE} != "binary" ]] && ! tc-has-tls && use vaapi && use egl; then
>                die "Your compiler lacks C++11 TLS support. Use GCC>=4.8.0 or Clang>=3.3."
>        fi

that's reasonable


        if ! use libass; then
                ewarn "You have disabled the libass support."
                ewarn "OSD and subtitles won't be available."
        fi

        if use openal; then
                ewarn "You have enabled the openal audio output. Be warned that"
                ewarn "this output is considered experimental by upstream."
        fi

        if use sdl; then
                ewarn "You have enabled the sdl video and audio outputs. Note that"
                ewarn "upstream provides these outputs for compatibility reasons only."
                ewarn "You probably don't need them under the normal circumstances."
        fi


... why is this in pkg_pretend? That should be in the useflag description in metadata.xml and maybe pkg_postinst. 



        if use libav; then
                elog "You have enabled media-video/libav instead of media-video/ffmpeg."
                elog "Upstream recommends media-video/ffmpeg, as some functionality"
                elog "is not provided by media-video/libav."
        fi

... tell me something I don't know? This is not going to do anything, users that decided on libav know what they are doing. (And what functionality?!)

        einfo "mpv optionally supports many different audio and video formats."
        einfo "You will need to enable support for the desired formats in your"
        einfo "libavcodec/libavformat provider:"
        einfo "    media-video/ffmpeg or media-video/libav"

This is just useless spam. Triggered on every merge, for every user, in pkg_pretend.
It doesn't give any actionable output, so why have it at all?
(And why not einfo in pkg_postinst where users might notice it?)

[Comment 1 Coacher 2016-03-08 09:53:52 UTC]

I'll think what's the best way to resolve this and will prepare the PR.
ETA is 1-2 days.

[Comment 2 Patrice Clement 2016-03-10 21:50:55 UTC]

commit 34da076f6b14edbef02c8fe91e9e19deefb49269 (HEAD -> master)
Author:     Ilya Tumaykin <[e-mail]>
AuthorDate: Thu Mar 10 20:51:05 2016 +0300
Commit:     Patrice Clement <[e-mail]>
CommitDate: Thu Mar 10 21:35:18 2016 +0000

media-video/mpv: remove old

Gentoo-Bug: https://bugs.gentoo.org/576748
Closes: https://github.com/gentoo/gentoo/pull/1026
Signed-off-by: Patrice Clement <[e-mail]>
Package-Manager: portage-2.2.27

media-video/mpv/Manifest                                               |   1 -
media-video/mpv/files/mpv-0.15.0-fix-null-pointer-dereference.patch    |  21 -------
media-video/mpv/files/mpv-0.15.0-fix-vaapi-build-on-older-ffmpeg.patch |  23 --------
media-video/mpv/mpv-0.15.0-r1.ebuild                                   | 304 -----------------------------------------------------------------------------------------------
media-video/mpv/mpv-0.16.0.ebuild                                      | 302 ----------------------------------------------------------------------------------------------
5 files changed, 651 deletions(-)
delete mode 100644 media-video/mpv/files/mpv-0.15.0-fix-null-pointer-dereference.patch
delete mode 100644 media-video/mpv/files/mpv-0.15.0-fix-vaapi-build-on-older-ffmpeg.patch
delete mode 100644 media-video/mpv/mpv-0.15.0-r1.ebuild
delete mode 100644 media-video/mpv/mpv-0.16.0.ebuild


Thanks for your contribution.

[Comment 3 Coacher 2016-03-11 08:27:07 UTC]

To be more specific this problem was addressed in the following series of changes, which are included in mpv-0.16.0-r1 ebuild:

commit e07c2bcf879b32a1d1f67fb69beb1a850c8447d5
Author: Ilya Tumaykin <[e-mail]>
Date:   Thu Mar 10 15:12:36 2016 +0300

    media-video/mpv: add libass USE description, drop libass ewarn from 9999

    Gentoo-Bug: 576748

    Package-Manager: portage-2.2.27

    Signed-off-by: Patrice Clement <[e-mail]>

commit 59c0fde85ba8078b4bf8eb74675d3b833586ec05
Author: Ilya Tumaykin <[e-mail]>
Date:   Thu Mar 10 15:09:26 2016 +0300

    media-video/mpv: drop spammy einfo re ffmpeg/libav from 9999

    Gentoo-Bug: 576748

    Package-Manager: portage-2.2.27

    Signed-off-by: Patrice Clement <[e-mail]>

commit d731e9173b82f75bf7318f626f6166f099cb301e
Author: Ilya Tumaykin <[e-mail]>
Date:   Thu Mar 10 15:01:36 2016 +0300

    media-video/mpv: drop useless ewarn re libav from 9999

    Gentoo-Bug: 576748

    Package-Manager: portage-2.2.27

    Signed-off-by: Patrice Clement <[e-mail]>

commit 63a2333ecad262efdc8cc2a16b4f2f1bb47e43b2
Author: Ilya Tumaykin <[e-mail]>
Date:   Thu Mar 10 14:59:09 2016 +0300

    media-video/mpv: drop useless ewarn re openal from 9999

    Gentoo-Bug: 576748

    Package-Manager: portage-2.2.27

    Signed-off-by: Patrice Clement <[e-mail]>

commit 9d5b4b57bcd08f3066326c02bcd9d7d4e407de83
Author: Ilya Tumaykin <[e-mail]>
Date:   Thu Mar 10 14:55:44 2016 +0300

    media-video/mpv: update sdl USE description, drop sdl ewarn from 9999

    Package-Manager: portage-2.2.27

    Signed-off-by: Patrice Clement <[e-mail]>