Created attachment 426154 [details] torrentzip-0.9_pre9.ebuild There are several issues with the new torrentzip ebuild: * Sourceforge code-snapshots are not stable download URIs.¹ When I tried to download $SRC_URI, I got a 404. After visiting <https://sourceforge.net/p/trrntzip/code/9/tree/> and clicking on "Download Snapshot" the URI would work, but I got an archive with different checksums. Threfore the SRC_URI must be replaced with mirror://gentoo/... * Renaming the source archive is wrong. The original name is just fine and the new name is misleading because it's NOT version 0.2. * A revision bump is not enough when switching to a newer code base. This needs a proper version bump. The last release was 0.2 but the snapshot is svn rev. r9 and identifies itself as v0.9, so 0.9_pre9 looks like a good ebuild version. * Missing deps: sys-libs/zlib is missing from RDEPEND and app-arch/unzip is needed in DEPEND. * The new and old versions create different archives (when they contain subdirectories).² This defeats the original purpose of the tool. I suggest to put this version in package.mask and resurrect the real version 0.2 (see next comment). In the attached ebuild I've * fixed the issues above, * bumped to EAPI=6 and used default phases where possible * replaced the build fix I suggested in bug 514634 with a simpler solution: unconditionally define the needed macro in CPPFLAGS. In order to use the ebuild you need to manually add the code snapshot to the gentoo mirrors, with its original name "trrntzip-code-9.zip" or change the archive name in SRC_URI. But don't use "torrentzip-0.2.zip". If you change the ebuild version scheme, you need to adjust MY_P. -- ¹) Somewhat unrelated note: there are 3 other ebuilds where SRC_URI contains http://sourceforge.net/code-snapshots/. They may need to be fixed, too. ²) I think the changes breaking compatibility were in r6 (aka v0.8). Revision r5 (v0.3) may be good but I don't think it's worth to introduce that version.
Created attachment 426156 [details] torrentzip-0.2-r3.ebuild Here is a working ebuild for the 0.2 release. It needs the patch from the old 0.2-r1 ebuild and therefore has EAPI=5.
Alexander, were you going to finally be set as proxy maintainer for this or...? It looks like you were not added to metadata after solving bug 514634 but I am not sure if that was simply missed :/
Hi Pacho, nobody has talked about proxy maintainership with me, yet. I've only posted a patch to that bug, after that I was no longer involved. Now I've seen the updated ebuild and noticed some issues, so I have merged my wip and posted the result here. Apparently Malcolm has created the current 0.2-r2 ebuild with monsieurp supervising and committing the work. Maybe you should ask monsieurp what they have planned.
I will CC him to try to know about that plans but, anyway, I doubt there will be any problem letting you to proxy maint this (or co maintain it) to try to get things fixed sooner :)
commit d36ec383a7997fb49782e76db5f80e6745fa0315 (HEAD -> master) Author: Patrice Clement <monsieurp@gentoo.org> Date: Mon Mar 7 13:39:10 2016 +0000 app-arch/torrentzip: Fix invalid SRC_URI. Gentoo-Bug: https://bugs.gentoo.org/575338 Reporter: Alexander Miller <alex.miller@gmx.de> Acked-by: Patrice Clement <monsieurp@gentoo.org> Signed-off-by: Patrice Clement <monsieurp@gentoo.org> Package-Manager: portage-2.2.26 app-arch/torrentzip/Manifest | 1 + app-arch/torrentzip/torrentzip-0.2-r3.ebuild | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 app-arch/torrentzip/torrentzip-0.2-r3.ebuild
Alexander if you want to proxy maint this ebuild let me know.
In reply to Comment #6: > Alexander if you want to proxy maint this ebuild let me know. If nobody else is interested I can probably do that. My interest in this package isn't that great, but it doesn't seem to be too much work either, an I think I know enough to keep it going. Regarding your commit: I noticed yo have dropped fix-perms.patch from my ebuild (which I inherited from the ancient broken ebuild). I think it's still needed for bug #182628 or am I missing something?
The patch isn't in the tree: https://gitweb.gentoo.org/repo/gentoo.git/tree/app-arch/torrentzip/files or is it? :/ I can't see it.
Created attachment 427688 [details, diff] fix-perms.patch The patch is no longer in the tree, you removed it on 16 Feb 2016. (You could find in the tree's git history or in the last comment of the bug linked above, but) I've attached it here for your convenience.
Reopening since the patch for old bug #182628 is still missing from the committed ebuild and I haven't heard anything for 2 weeks.
commit 1955ba94cadb967b66cc7bdc9bd607c77072f400 (HEAD -> master) Author: Patrice Clement <monsieurp@gentoo.org> AuthorDate: Tue Mar 22 09:58:59 2016 +0000 Commit: Patrice Clement <monsieurp@gentoo.org> CommitDate: Tue Mar 22 09:58:59 2016 +0000 app-arch/torrentzip: Fix SRC_URI. Bump to EAPI 6. Bump to version 0.9 Also assign package to Alexander Miller <alex.miller@gmx.de>. Gentoo-Bug: https://bugs.gentoo.org/575338 Package-Manager: portage-2.2.26 app-arch/torrentzip/Manifest | 4 ++-- app-arch/torrentzip/files/torrentzip-0.2-fix-perms.patch | 11 +++++++++++ app-arch/torrentzip/metadata.xml | 11 ++++++++++- app-arch/torrentzip/torrentzip-0.2-r2.ebuild | 42 ------------------------------------------ app-arch/torrentzip/torrentzip-0.2-r3.ebuild | 32 -------------------------------- app-arch/torrentzip/torrentzip-0.2-r4.ebuild | 33 +++++++++++++++++++++++++++++++++ app-arch/torrentzip/torrentzip-0.9.ebuild | 31 +++++++++++++++++++++++++++++++ 7 files changed, 87 insertions(+), 77 deletions(-) create mode 100644 app-arch/torrentzip/files/torrentzip-0.2-fix-perms.patch delete mode 100644 app-arch/torrentzip/torrentzip-0.2-r2.ebuild delete mode 100644 app-arch/torrentzip/torrentzip-0.2-r3.ebuild create mode 100644 app-arch/torrentzip/torrentzip-0.2-r4.ebuild create mode 100644 app-arch/torrentzip/torrentzip-0.9.ebuild Thank you Alex.
