Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 574550 - sys-devel/libtool: Fail to detect correct sed when run emerge -e @system
Summary: sys-devel/libtool: Fail to detect correct sed when run emerge -e @system
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: All FreeBSD
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-12 12:03 UTC by Yuta SATOH
Modified: 2024-03-29 02:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sample patch for libtool.ebuild (bug574550.patch,1.40 KB, patch)
2016-02-12 12:10 UTC, Yuta SATOH
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta SATOH 2016-02-12 12:03:25 UTC
It is similar to bug 438112.
/var/tmp/portage/._portage_reinstall_.0uece7hy/bin/ebuild-helpers/bsd/sed is not a correct sed.


Reproducible: Always

Steps to Reproduce:
1. emerge sys-apps/portage sys-devel/libtool
2.
3.
Actual Results:  
# grep SED= /usr/bin/libtool*
/usr/bin/libtool:SED="/var/tmp/portage/._portage_reinstall_.0uece7hy/bin/ebuild-helpers/bsd/sed"
/usr/bin/libtool:  SED=$func_path_progs_result
/usr/bin/libtoolize:: ${SED="/var/tmp/portage/._portage_reinstall_.0uece7hy/bin/ebuild-helpers/bsd/sed"}
/usr/bin/libtoolize:  SED=$func_path_progs_result


Expected Results:  
# grep SED= /usr/bin/libtool*
/usr/bin/libtool:SED="/usr/bin/gsed"
/usr/bin/libtool:  SED=$func_path_progs_result
/usr/bin/libtoolize:: ${SED="/usr/bin/gsed"}
/usr/bin/libtoolize:  SED=$func_path_progs_result
Comment 1 Yuta SATOH 2016-02-12 12:10:54 UTC
Created attachment 425292 [details, diff]
sample patch for libtool.ebuild
Comment 2 SpanKY gentoo-dev 2016-02-13 07:49:44 UTC
i don't think hardcoding any particular C library makes sense

we could change it to do the basename, but then it'd still fail when portage has the wrapper named "sed".  then again, i don't think libtool actually requires GNU sed ... just any sed.
Comment 3 SpanKY gentoo-dev 2016-02-13 08:55:42 UTC
libtool-2.4.6-r2 will assign the value of "sed" now:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5f4225eb727dcd8cc0eebd60620d4b2b160712aa
Comment 4 Larry the Git Cow gentoo-dev 2024-03-29 02:28:55 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=411f7e106012a6af37a5d14e2a62572c2f0b4f6a

commit 411f7e106012a6af37a5d14e2a62572c2f0b4f6a
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-27 06:16:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-29 02:28:22 +0000

    dev-build/libtool: simplify defining tool names to their basename
    
    Recently a bunch more got added following the original sed style. The
    whole thing is incredibly wasteful and difficult to read, however.
    
    - type -P xxx will always return ${path}/xxx or nothing, which includes
      failing to fork in low-memory conditions, catastrophically failing the
      build, but NOT running "die"
    - basename ${path}/xxx will always return "xxx"
    
    We can simply write xxx directly. This is a confusing 2016 hack that
    doesn't need to be continued.
    
    Bug: https://bugs.gentoo.org/574550
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-build/libtool/libtool-2.4.7-r4.ebuild | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)