Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 567320 - www-servers/spawn-fcgi init script doesn't detect crash
Summary: www-servers/spawn-fcgi init script doesn't detect crash
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 618090
  Show dependency tree
 
Reported: 2015-12-02 11:26 UTC by Cédric Krier
Modified: 2018-10-14 10:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
spawn-fcgi.initd-r3 (spawn-fcgi,3.10 KB, text/plain)
2015-12-02 11:26 UTC, Cédric Krier
Details
spawn-fcgi.diff (spawn-fcgi.diff,1.12 KB, patch)
2015-12-08 06:57 UTC, Cédric Krier
Details | Diff
spawn-fcgi.diff (spawn-fcgi.diff,822 bytes, patch)
2015-12-08 06:59 UTC, Cédric Krier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cédric Krier gentoo-dev 2015-12-02 11:26:06 UTC
Created attachment 418322 [details]
spawn-fcgi.initd-r3

The script use env and --name option which prevents OpenRC to detect crash.
Here is in attachment an improved version of the script which remove the --name option and use --env of start-stop-daemon instead of using env command.
Comment 1 Manuel Rüger (RETIRED) gentoo-dev 2015-12-06 18:42:22 UTC
Could you provide a diff?
Comment 2 Cédric Krier gentoo-dev 2015-12-07 10:27:59 UTC
For me, it shoud be a new init script so I don't see against what it should be "diffed".
Comment 3 Manuel Rüger (RETIRED) gentoo-dev 2015-12-07 18:45:07 UTC
Diff against -r2, so it's more obvious what you have changed.
Comment 4 Cédric Krier gentoo-dev 2015-12-08 06:57:55 UTC
Created attachment 418742 [details, diff]
spawn-fcgi.diff

Here is the diff.
Comment 5 Cédric Krier gentoo-dev 2015-12-08 06:59:45 UTC
Created attachment 418744 [details, diff]
spawn-fcgi.diff
Comment 6 Larry the Git Cow gentoo-dev 2018-10-14 10:18:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e087bd09a7b0d4737e26c876720a596ed002d28

commit 0e087bd09a7b0d4737e26c876720a596ed002d28
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2018-10-14 08:43:27 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2018-10-14 10:18:04 +0000

    www-servers/spawn-fcgi: Several fixes to init.d script
    
    - Detect crashes (#567320 by Cédric Krier)
    - Use proper variable names (#657362 by Jernej Simoncic)
    
    Closes: https://bugs.gentoo.org/567320
    Closes: https://bugs.gentoo.org/657362
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 www-servers/spawn-fcgi/files/spawn-fcgi.initd-r3  | 116 ++++++++++++++++++++++
 www-servers/spawn-fcgi/spawn-fcgi-1.6.4-r1.ebuild |  33 ++++++
 2 files changed, 149 insertions(+)