Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 565796 - net-libs/libsoup-gnome-2.52.0 version bump request
Summary: net-libs/libsoup-gnome-2.52.0 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks: gnome-3.18
  Show dependency tree
 
Reported: 2015-11-15 00:47 UTC by Harris Landgarten
Modified: 2015-11-19 16:43 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libsoup.patch (libsoup.patch,7.19 KB, patch)
2015-11-17 09:44 UTC, Pacho Ramos
Details | Diff
libsoup.patch (libsoup.patch,7.13 KB, patch)
2015-11-19 11:10 UTC, Pacho Ramos
Details | Diff
libsoup-gnome-2.52.2.ebuild (libsoup-gnome-2.52.2.ebuild,1.54 KB, text/plain)
2015-11-19 11:34 UTC, Pacho Ramos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harris Landgarten 2015-11-15 00:47:07 UTC
tracker-1.6.0 needs libosinfo which needs libsoup-gnome. libsoup-gnome-2.50.0 requires libsoup.2.50.0 but dev-libs/appstream-glib 0.5.3 requires libsoup-2.52.2

I think we need libsoup-gnome-2.52.2

I tried copying libsoup-gnome-2.5.0.ebuild to libsoup-gnome-2.52.2.ebuild but it
fails to build.
Comment 1 Harris Landgarten 2015-11-15 01:38:28 UTC
note: arch libsoup-2.52 includes libsoup-gnome. That does not seem to be the case in our libsoup-2.52 but if it is then the dependencies of rest and libosinfo need to be adjusted.
Comment 2 Harris Landgarten 2015-11-15 02:26:06 UTC
It looks like both arch and fedora have replaced libsoup-gnome with libsoup-2.52.2

as a workaround I did the following:

deleted the --without-gnome
line from the libsoup-2.52.2 ebuild
It built fine and provide libsoup-gnome libraries

I then modified the rest and libosinfo ebuild to depend on libsoup-2.52.2:24 instead of libsoup-gnome.

They both built fine without libsoup-gnome.

Use this info as you see fit.

We either have to go this route with adjustments for earlier gnome versions or we need a newer version of libsoup-gnome that builds with libsoup-2.52.2 and other gnome-3.18 components
Comment 3 Pacho Ramos gentoo-dev 2015-11-15 08:43:09 UTC
Yeah, it's incomplete because libsoup-gnome needs to get the big patch updated :S
Comment 4 Priit Laes (IRC: plaes) 2015-11-15 09:30:27 UTC
(In reply to Pacho Ramos from comment #3)
> Yeah, it's incomplete because libsoup-gnome needs to get the big patch
> updated :S

Do we actually really need to split this anymore?

IIRC it was originally split to accommodate the libproxy requirement but its requirement in libsoup-gnome was reworked awhile ago (in version 2.34 which also dropped gconf requirement) to use gio.

It was already back then when I wanted to drop libsoup-gnome (in gnome-overlay) and have a single package.

As it stands now, `--with-gnome` requires no extra libraries and it doesn't enable any conditional code paths, except of the extra library with bunch of new symbols.
Comment 5 Pacho Ramos gentoo-dev 2015-11-15 10:19:55 UTC
I had this discussion before (I think at Gnome 3.8 time), but other people in the team strongly disagreed on dropping this splitting... 

Well, at least now it seems that far less packages need the obsolete libsoup-gnome
Comment 6 Priit Laes (IRC: plaes) 2015-11-15 11:25:33 UTC
(In reply to Pacho Ramos from comment #5)
> I had this discussion before (I think at Gnome 3.8 time), but other people
> in the team strongly disagreed on dropping this splitting... 
> 
> Well, at least now it seems that far less packages need the obsolete
> libsoup-gnome

How about we just install libsoup-gnome with net-libs/libsoup and have empty net-libs/libsoup-gnome that provides no files?
Comment 7 Pacho Ramos gentoo-dev 2015-11-17 09:44:32 UTC
Created attachment 417188 [details, diff]
libsoup.patch

This could be the updated patch... but I cannot test it as I am not with my machine ;)
Comment 8 Pacho Ramos gentoo-dev 2015-11-17 19:56:31 UTC
make -j5 
make  all-recursive
make[1]: Entering directory '/var/tmp/portage/net-libs/libsoup-gnome-2.52.2/work/libsoup-2.52.2-abi_x86_64.amd64'
Making all in libsoup
make[2]: Entering directory '/var/tmp/portage/net-libs/libsoup-gnome-2.52.2/work/libsoup-2.52.2-abi_x86_64.amd64/libsoup'
Makefile:1403: *** missing separator.  Stop.
make[2]: Leaving directory '/var/tmp/portage/net-libs/libsoup-gnome-2.52.2/work/libsoup-2.52.2-abi_x86_64.amd64/libsoup'
Makefile:557: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/net-libs/libsoup-gnome-2.52.2/work/libsoup-2.52.2-abi_x86_64.amd64'
Makefile:462: recipe for target 'all' failed
make: *** [all] Error 2

It fails
Comment 9 Pacho Ramos gentoo-dev 2015-11-18 10:08:49 UTC
It looks error is referring to this part, any ideas?
+endif
+
+if BUILD_LIBSOUP_GNOME
+if OS_LINUX
+check-local:
+       @echo Checking libsoup-gnome-2.4.so symbols
+       @nm $(builddir)/.libs/libsoup-gnome-2.4.so | \
+               grep "^[[:xdigit:]]\+ [BTR] " | \
+               sed "s/^[[:xdigit:]]\+ [BTR] //" | \
+               env LANG=C sort -u | \
+               diff -U0 $(srcdir)/libsoup-gnome-2.4.sym - >&2
+endif
+endif
Comment 10 Pacho Ramos gentoo-dev 2015-11-19 11:10:48 UTC
Created attachment 417340 [details, diff]
libsoup.patch

After fixing some spaces vs. tabs it looks to work
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-11-19 11:19:33 UTC
I really think we should unsplit this. Such patches are really unmaintainable long-term and cause unnecessary confusion. Diverging from upstream is not the Gentoo Way.

That said, keeping libsoup-gnome as meta-ebuild seems fine to me. This is what we did to clang to keep things working until upstream fixes out-of-llvm build.
Comment 12 Pacho Ramos gentoo-dev 2015-11-19 11:34:01 UTC
Created attachment 417346 [details]
libsoup-gnome-2.52.2.ebuild

And this is the ebuild that finally works (but I cannot commit as I am far from my dev machine :S)
Comment 13 Pacho Ramos gentoo-dev 2015-11-19 11:45:19 UTC
Well.. maybe for this cycle we can finally keep the splitting (as the work is already done). For the next breakage... I was checking for reverse deps and the only reverse dep that went in the opposite way (it *started* to depend on obsolete libsoup-gnome instead of moving away from it) is midori :S

I reported a bug to upstream a few days ago but I don't have enough knowledge to provide them a patch :( 

The other reverse deps are being moved away of it
Comment 14 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-11-19 14:19:37 UTC
Well, I presume you didn't want to add it with stable keywords, so I lowered them.

commit 96f051197156152dc283c014747c56b693f52eb9
Author: Michał Górny <mgorny@gentoo.org>
Date:   Thu Nov 19 15:17:55 2015 +0100

    net-libs/libsoup-gnome: Bump to 2.52.2
    
    Commit the 2.52.2 version bump on behalf of Pacho Ramos.
    
    Bug: https://bugs.gentoo.org/565796
Comment 15 Pacho Ramos gentoo-dev 2015-11-19 16:43:23 UTC
Sure, thanks a lot!