Created attachment 410272 [details] fwknop-2.6.7.ebuild Hello. fwknop-2.6.7 was released today. Here's the proposed ebuild for it. Changes since 2.6.6: - add iptables/firewalld USEs to choose the default server backend (needed to avoid automagic) - add check for required kernel options - notify server users about example configuration and supported backends - use upstream systemd configs (they are Gentoo configs merged upstream) @proxy-maint please review and add to the tree.
Created attachment 410274 [details, diff] 2.6.6-r1..2.6.7.patch
Created attachment 410280 [details] metadata.xml Updated metadata.xml with new USEs and updated descriptions for old ones.
Created attachment 410282 [details, diff] metadata.xml.patch
@proxy-maint please preserve USE flag ordering from my submitted metadata.xml. Though it makes no functional difference, it really helps to review diffs between releases as I prefer to keep USEs sorted alphabetically in my overlay.
CC'ing @proxy-maint
Created attachment 410284 [details] fwknop-2.6.7.ebuild Oops, last minute changes: disable autoformatting by readme.gentoo eclass to make DOC_CONTENTS more readable.
Created attachment 410286 [details, diff] 2.6.6-r1..2.6.7.patch
Now everything should be fine.
(I didn't import emails for several days) This ebuild had some flaws. You have included DISTUTILS_OPTIONAL=1 DISTUTILS_SINGLE_IMPL=1 inherit autotools-utils distutils-r1 python? ( ${PYTHON_DEPS} )" and within REQUIRED_USE python? ( ${PYTHON_REQUIRED_USE} ). This combo interfere with one another. DISTUTILS_OPTIONAL=1 is fine. Once you use DISTUTILS_SINGLE_IMPL=1, it is required to add the pkg_setup phase and call python_single-r1_pkg_setup. Otherwise, with USE=python, you get; make[1]: Leaving directory '/mnt/gen2/TmpDir/portage/net-firewall/fwknop-2.6.7/work/fwknop-2.6.7' * ERROR: net-firewall/fwknop-2.6.7::gentoo failed (compile phase): * EPYTHON unset, python-single-r1_pkg_setup not called?! * * Call stack: * ebuild.sh, line 93: Called src_compile * environment, line 4919: Called distutils-r1_src_compile * environment, line 1571: Called _distutils-r1_run_foreach_impl 'distutils-r1_python_compile' Solution is either delete DISTUTILS_SINGLE_IMPL=1 or add the required phase. In either case, python? ( ${PYTHON_DEPS} )" and python? ( ${PYTHON_REQUIRED_USE} ) are not required with inheriting distutils-r1 eclass. They ARE required inheriting a python-r1 eclass. These are all outlined in the docs for python project. Yes the setup.py is quite minimal but still might work with py3. I hold off at this point on testing py3. The sad news is I skim read it and never runtested on adding fwknop-2.6.6 and fwknop-2.6.6-r1, and all devs prior to me. I presumed it was all tested. (Better late than never) In a package like this with a folder specially for python and the setup.py in that subfolder, it's valid to use either python-r1 or python-single-r1. Both are right. The form in this current is not.
After discussion with Ian on #gentoo-proxy-maint IRC channel we both agreed that using distutils-r1 eclass and removing DISTUTILS_SINLGE_IMPL is a valid solution to the python compilation problem mentioned above. The updated ebuild will be attached shortly.
Created attachment 411048 [details] fwknop-2.6.7.ebuild Updated ebuild. Also firewalld dep was adjusted, but it results in some strange errors from repoman now. Actual bump is postponed until this is resolved.
Created attachment 411050 [details, diff] 2.6.6-r1..2.6.7.patch
(In reply to Coacher from comment #11) > Created attachment 411048 [details] > fwknop-2.6.7.ebuild > > Updated ebuild. Also firewalld dep was adjusted, but it results in some > strange errors from repoman now. Actual bump is postponed until this is > resolved. The problem with firewalld dep is narrowed down to package mask on selinux-aware profiles. The proper resolution is to mask firewalld USE on these profiles as well and this should be done by hardened team. So, waiting for them to proceed.
commit 048d03cc31f4f5c326384bbb6920b1491a179539 Author: Ian Delaney <idella4@gentoo.org> Date: Sat Sep 5 22:42:38 2015 +0800 net-firewall/fwknop: bump: new optional deps with use flags dep net-firewall/firewalld is masked under profiles for SElinux, the use flag firewalld has been masked accordingly under profiles, patches and ebuild supplied by maintainer via bug #558754, prior version dropped, closes said bug
commit 107ac003e905c757fc8ce12802c36c18d59a52f5 Author: Jason Zaman <perfinion@gentoo.org> Date: Sat Sep 5 21:52:30 2015 +0800 SELinux profile: add net-firewall/fwknop to mask version 2.6.7 will have a dep on firewalld. Mask the USE-flag so it can be added to the tree. https://bugs.gentoo.org/558754
Ian and Jason, thank you.
