Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 556280 - media-video/vlc-9999 and media-video/vlc-2.2.9999 USE="-qt5 qt4" vlc uses qt5 when it should use qt4 at runtime
Summary: media-video/vlc-9999 and media-video/vlc-2.2.9999 USE="-qt5 qt4" vlc uses qt5...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-29 23:39 UTC by jospezial
Modified: 2017-12-07 00:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vlc-9999.ebuild.patch (vlc-9999.ebuild.patch,947 bytes, patch)
2015-08-04 21:47 UTC, jospezial
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2015-07-29 23:39:05 UTC
vlc has the bug on my system that when it uses qt5 the video is not scaled.
I'm compiling vlc-2.2.1 with USE="-qt5 qt4" and it works.


When I do the same with vlc-9999 I get the video scaling bug.

USE="-qt5 qt4 -vcdx" emerge -va vlc

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild     U *] media-video/vlc-9999:0/5-8::gentoo [2.2.1:0/5-8::gentoo] USE="X a52 aalib alsa avcodec avformat bluray cdda cddb dbus dts dvb dvbpsi dvd encode faad ffmpeg flac fluidsynth fontconfig gcrypt gme gnutls jack jpeg kate libass libnotify libsamplerate libtiger live lua matroska modplug mp3 mpeg mtp musepack ncurses ogg opengl png postproc projectm pulseaudio qt4* rtsp schroedinger sdl sftp shout skins speex svg swscale taglib theora truetype twolame udev v4l vaapi vdpau vlm vnc vorbis vpx x264 x265 xcb xml xv zvbi (-altivec) -atmo (-audioqueue) -bidi -chromaprint -dc1394 -debug -directfb (-directx) (-dxva2) -fdk -gnome -growl -httpd -ieee1394 -kde -libav -libcaca -libtar -linsys -lirc (-macosx-dialog-provider) (-macosx-eyetv) (-macosx-qtkit) (-macosx-quartztext) (-media-library) (-neon) -omxil -opencv -optimisememory -opus -qt5* -rdp -run-as-root -samba -sdl-image -sid {-test} -tremor -upnp -vcdx* -wma-fixed -zeroconf" CPU_FLAGS_X86="mmx sse" 0 KiB

Total: 1 package (1 upgrade), Size of downloads: 0 KiB

Would you like to merge these packages? [Yes/No] 
>>> Verifying ebuild manifests
>>> Emerging (1 of 1) media-video/vlc-9999::gentoo
>>> Installing (1 of 1) media-video/vlc-9999::gentoo
>>> Jobs: 1 of 1 complete                           Load avg: 3.75, 2.84, 2.30
>>> Auto-cleaning packages...


With QT_DEBUG_PLUGINS=1 vlc I can see which qt-plugins are used.
This is a part of the output:

VLC media player 3.0.0-git Vetinari (revision 419861b)
[0000000000f891f0] core libvlc: VLC wird mit dem Standard-Interface ausgeführt. Benutzen Sie 'cvlc', um VLC ohne Interface zu verwenden.
QFactoryLoader::QFactoryLoader() checking directory path "/usr/lib64/qt5/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() looking at "/usr/lib64/qt5/plugins/platforms/libqminimal.so"
Found metadata in lib /usr/lib64/qt5/plugins/platforms/libqminimal.so, metadata=
{
    "IID": "org.qt-project.Qt.QPA.QPlatformIntegrationFactoryInterface.5.3",
    "MetaData": {
        "Keys": [
            "minimal"
        ]
    },
    "className": "QMinimalIntegrationPlugin",
    "debug": false,
    "version": 329216
}

and so on.


Even gdb shows me /usr/lib64/libQt5Core.so.5
The only qt4 thing I see in gdb is /usr/lib64/vlc/plugins/gui/libqt4_plugin.so
Comment 1 jospezial 2015-07-29 23:54:08 UTC
The same problems with media-video/vlc-2.2.9999 .
Comment 2 jospezial 2015-07-30 00:19:00 UTC
There is an upstream bug for that
https://trac.videolan.org/vlc/ticket/11772

and that directs me to
https://bugs.gentoo.org/show_bug.cgi?id=541678

Then I read on the versioned ebuilds "${FILESDIR}"/qt4-select.patch is only applied to the versioned ebuilds for now and not to the live ebuilds.

I hope upstream will add the patch to the source in future.
I think I have to try qtchooser.
Comment 3 jospezial 2015-07-30 01:52:01 UTC
Please add the patch line and the lines in configure() to the live ebuilds too because that still works as wanted.
Comment 4 jospezial 2015-08-04 21:47:14 UTC
Created attachment 408318 [details, diff]
vlc-9999.ebuild.patch

The needed lines taken from media-video/vlc-2.2.1.ebuild:

--- /usr/portage/media-video/vlc/vlc-9999.ebuild	2015-07-04 14:31:13.000000000 +0200
+++ vlc-9999.ebuild	2015-08-04 22:42:44.197619178 +0200
@@ -258,6 +258,9 @@
 	# Fix up broken audio when skipping using a fixed reversed bisected commit.
 	epatch "${FILESDIR}"/${PN}-2.1.0-TomWij-bisected-PA-broken-underflow.patch
 
+        # Bug #541678
+        epatch "${FILESDIR}"/qt4-select.patch
+
 	# Don't use --started-from-file when not using dbus.
 	if ! use dbus ; then
 		sed -i 's/ --started-from-file//' share/vlc.desktop.in || die
@@ -299,10 +302,14 @@
 				--with-default-monospace-font-family=Monospace"
 	fi
 
-	local qt_flag=""
-	if use qt4 || use qt5 ; then
-		qt_flag="--enable-qt"
-	fi
+       local qt_flag=""
+       if use qt4 ; then
+                qt_flag="--enable-qt=4"
+       elif use qt5 ; then
+                qt_flag="--enable-qt=5"
+       else
+                qt_flag="--disable-qt"
+       fi
 
 	econf \
 		${myconf} \
Comment 5 Amy Liffey gentoo-dev 2017-02-23 21:44:42 UTC
(In reply to jospezial from comment #4)
> Created attachment 408318 [details, diff] [details, diff]
> vlc-9999.ebuild.patch
> 
> The needed lines taken from media-video/vlc-2.2.1.ebuild:
> 
> --- /usr/portage/media-video/vlc/vlc-9999.ebuild	2015-07-04
> 14:31:13.000000000 +0200
> +++ vlc-9999.ebuild	2015-08-04 22:42:44.197619178 +0200
> @@ -258,6 +258,9 @@
>  	# Fix up broken audio when skipping using a fixed reversed bisected commit.
>  	epatch "${FILESDIR}"/${PN}-2.1.0-TomWij-bisected-PA-broken-underflow.patch
>  
> +        # Bug #541678
> +        epatch "${FILESDIR}"/qt4-select.patch
> +
>  	# Don't use --started-from-file when not using dbus.
>  	if ! use dbus ; then
>  		sed -i 's/ --started-from-file//' share/vlc.desktop.in || die
> @@ -299,10 +302,14 @@
>  				--with-default-monospace-font-family=Monospace"
>  	fi
>  
> -	local qt_flag=""
> -	if use qt4 || use qt5 ; then
> -		qt_flag="--enable-qt"
> -	fi
> +       local qt_flag=""
> +       if use qt4 ; then
> +                qt_flag="--enable-qt=4"
> +       elif use qt5 ; then
> +                qt_flag="--enable-qt=5"
> +       else
> +                qt_flag="--disable-qt"
> +       fi
>  
>  	econf \
>  		${myconf} \

Is it still valid for the recent vlc-9999?
Comment 6 jospezial 2017-02-25 09:20:07 UTC
(In reply to Amy Liffey from comment #5)
> (In reply to jospezial from comment #4)
> > Created attachment 408318 [details, diff] [details, diff] [details, diff]
> > vlc-9999.ebuild.patch
> 
> Is it still valid for the recent vlc-9999?

I prefer to use the vlc-9999 since a long time with qt5. So I don't know if it is still needed.
Comment 7 Larry the Git Cow gentoo-dev 2017-12-07 00:02:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e2805b7ce032e415956919a4d7ad98b64d50f54d

commit e2805b7ce032e415956919a4d7ad98b64d50f54d
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2017-12-06 23:29:54 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2017-12-07 00:01:54 +0000

    media-video/vlc: Sync 9999 with upstream changes
    
    Added USE: aom, archive, nfs
    Dropped USE: audioqueue, directfb, httpd, macosx-eyetv, qt4, sdl
    Dropped patch: vlc-9999-libva-1.2.1-compat.patch
    New options: --disable-libplacebo, --disable-spatialaudio, --disable-srt
    Old options: --disable-gles1, --disable-vda
    Raised minimum: >=sys-devel/gettext-0.19.8
    
    Closes: https://bugs.gentoo.org/631526
    Closes: https://bugs.gentoo.org/556280
    Closes: https://bugs.gentoo.org/610762
    Package-Manager: Portage-2.3.16, Repoman-2.3.6

 media-video/vlc/metadata.xml    |  3 ++
 media-video/vlc/vlc-9999.ebuild | 63 ++++++++++++++---------------------------
 2 files changed, 25 insertions(+), 41 deletions(-)