Created attachment 407490 [details, diff] openssh-dont-use-var-run-in-initscript.patch The sshd init script still sets the pidfile to /var/run/sshd.pid, where sshd itself is set to look for it at /run/sshd.pid.
it doesn't really matter because /var/run is a symlink to /run
Sure, but it would be nice if we could eventually get rid of that symlink
I'd tend to agree with Patrick on this one Mike. We have some other QA warnings about /var/run I believe.
(In reply to Patrick McLean from comment #2) i really don't see the symlink ever going away (it's in FHS and been around for decades), nor do i see it necessary to even bother cleaning it up. saving an inode in the fs is not an optimization worth discussing. (In reply to Doug Goldstein from comment #3) i haven't closed the bug ...
Created attachment 486950 [details] sshd.init Here's a modernized/simplified init script that fixes bug 617596, too.
(In reply to Michael Orlitzky from comment #5) > Here's a modernized/simplified init script that fixes bug 617596, too. I like it, but let's make start_stop_daemon_args configurable as well. I.e. > : ${SSHD_SSDARGS:="--wait 1000"} > start_stop_daemon_args="${SSHD_SSDARGS}"
Created attachment 486964 [details] sshd.init Sure, and why not fix bug 470020 while we're at it.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b74fc16d7b050757989bd8ebba1366e3b8eeda1 commit 9b74fc16d7b050757989bd8ebba1366e3b8eeda1 Author: Thomas Deutschmann <whissi@gentoo.org> AuthorDate: 2018-04-11 02:16:28 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2018-04-11 02:43:57 +0000 net-misc/openssh: Bump to v7.7_p1 Ebuild changes: =============== - HPN patch set updated to v14.14. MT AES CTR cipher are still not working at the moment but we are working on this. - SCTP patch updated for openssh-7.7_p1. - LDAP patch is currently not available because patch isn't compatble with openssh-7.7_p1 and needs a major rewrite because upstream removed auth_parse_options() via commit 7c8568576071. - X.509 patch updated to v11.3.1. - Previously, SCTP patch sometimes got applied even when "sctp" USE flag wasn't set, this is now fixed. - We now always expose applied patches in version string (previously this was only the case for some patches and was also depending on whether the "hpn" USE flag was enabled or not). - Make sure "/var/empty" gets preserved by package manager. [Bug 647034] - Runscript: "use" entropy. [Bug 470020] - Runscript: Use "/run" instead of "/var/run". [Bug 555734] - Runscript: Verify daemon is really up and running. [Bug 617596] - Runscript: Simplified (thanks to Michael Orlitzky) - Runscript: Add prefix support. [Bug 640666] - Runscript: It is now possible to pass any by start-stop-daemon supported arguments (like "--ionice" or "--nicelevel" for example) to start-stop-daemon. [Bug 636764] Closes: https://bugs.gentoo.org/470020 Closes: https://bugs.gentoo.org/555734 Closes: https://bugs.gentoo.org/617596 Closes: https://bugs.gentoo.org/636764 Closes: https://bugs.gentoo.org/640666 Closes: https://bugs.gentoo.org/647034 Closes: https://bugs.gentoo.org/652438 Package-Manager: Portage-2.3.28, Repoman-2.3.9 net-misc/openssh/Manifest | 4 + .../openssh/files/openssh-7.7_p1-GSSAPI-dns.patch | 351 ++++++++++++++++++ net-misc/openssh/files/sshd-r1.confd | 33 ++ net-misc/openssh/files/sshd.rc6.5 | 89 +++++ net-misc/openssh/openssh-7.7_p1.ebuild | 406 +++++++++++++++++++++ 5 files changed, 883 insertions(+)
