Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 554248 - net-p2p/transmission-2.84-r1 - invalid slot-operator dependency on dev-qt/*
Summary: net-p2p/transmission-2.84-r1 - invalid slot-operator dependency on dev-qt/*
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Samuli Suominen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-08 15:49 UTC by Michael Palimaka (kensington)
Modified: 2015-12-03 17:42 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2015-07-08 15:49:52 UTC
qt5 is introducing subslots to cover an uncommon case where a package uses a private API. Your package has bogus subslot dependencies which will cause unnecessary rebuilds with USE="qt5".
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-07-08 17:16:52 UTC
So how about you use subslots for common cases rather than reusing them for unlikely cases where a few packages are going to cause pain upon everyone else.
Comment 2 Michael Palimaka (kensington) gentoo-dev 2015-07-08 17:18:41 UTC
There is no common case - the ABI is otherwise stable.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-07-08 17:21:53 UTC
There is a common case of a lot of other libraries using subslots consistently. Developers really have better things to do than check every single library how it's using subslots in case it has a really special use for them.
Comment 4 Michael Palimaka (kensington) gentoo-dev 2015-07-08 17:25:05 UTC
None of that is relevant to this bug.
Comment 5 Davide Pesavento (RETIRED) gentoo-dev 2015-07-09 00:46:18 UTC
(In reply to Michał Górny from comment #3)
> There is a common case of a lot of other libraries using subslots
> consistently. Developers really have better things to do than check every
> single library how it's using subslots in case it has a really special use
> for them.

Then we shouldn't use a subslot at all for Qt5. That would be the "common case" of Qt usage (i.e. using public APIs only).

Personally I don't have a strong opinion either way.

In any case please discuss in bug 554190
Comment 6 Mike Gilbert gentoo-dev 2015-12-03 17:05:13 UTC
Qt team: how would you like me to proceed here? Remove the slot-operator or not?
Comment 7 Davide Pesavento (RETIRED) gentoo-dev 2015-12-03 17:08:28 UTC
Yes please remove it. The slot operator is wrong for this package regardless of the outcome of the discussion that is happening in bug 554190.
Comment 8 Mike Gilbert gentoo-dev 2015-12-03 17:42:56 UTC
commit acc67f4952404f0aa0439e00edfd447f350860d3
Author: Mike Gilbert <floppym@gentoo.org>
Date:   Thu Dec 3 12:41:32 2015 -0500

    net-p2p/transmission: Remove slot-operator from Qt deps

    Bug: https://bugs.gentoo.org/554248

    Package-Manager: portage-2.2.26_p10

 ...ission-2.84-r3.ebuild => transmission-2.84-r4.ebuild} | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)