Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 552512 - sys-apps/keyutils - KEYS_DEBUG_PROC_KEYS check not valid for kernel >=4.0
Summary: sys-apps/keyutils - KEYS_DEBUG_PROC_KEYS check not valid for kernel >=4.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://git.kernel.org/pub/scm/linux/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-19 03:12 UTC by Anthony Ryan
Modified: 2018-03-11 06:24 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Ryan 2015-06-19 03:12:24 UTC
When recompiling sys-apps/keyutils today I saw a warning for KEYS_DEBUG_PROC_KEYS not being set in my kernel (gentoo-sources-4.0.5), and quickly discovered this kernel option no longer exists.

The check for KEYS_DEBUG_PROC_KEYS either needs to be removed or updated.

Reproducible: Always
Comment 1 Adam Feldman gentoo-dev 2015-06-19 03:52:12 UTC
I did a quick look to see what replaced it in 4.0, I didn't see it.  That said, there are plenty of references to /proc/keys in the source (what is enabled with the KEYS_DEBUG_PROC_KEYS option), so I'm not sure if another option toggles it, or if it is now there by default.

Anthony, since I'm not running 4.0, can you confirm if that directory exists when you are running the 4.0 kernel?
Comment 2 Anthony Ryan 2015-06-19 05:16:05 UTC
I happened to have another system here still running "3.18.11-gentoo" with CONFIG_KEYS_DEBUG_PROC_KEYS enabled. After comparing it against the "4.0.5-gentoo" kernel without that option, it appears as though both the contents of /proc/keys (which is a file, rather than a folder on both of these kernel versions) remains unchanged.

Because of this I believe this is now included by default when CONIFG_KEYS is enabled.
Comment 3 Matt Turner gentoo-dev 2018-03-07 19:42:46 UTC
v4.0 contained this commit:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dabd39cc2fb1b0e97313ebbe7309ea8e05b7cfb5

the result of which is that keyutils should check for CONFIG_KEYS=y instead.

v4.6 removed KEYS_DEBUG_PROC_KEYS:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=50d35015ff0c00a464e35b109231145d2beec1bd
Comment 4 Larry the Git Cow gentoo-dev 2018-03-11 06:24:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ba206c24738022e96693a5591fb3a6227f51a6a

commit 5ba206c24738022e96693a5591fb3a6227f51a6a
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2018-03-11 06:24:06 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2018-03-11 06:24:06 +0000

    sys-apps/keyutils: Don't check for KEYS_DEBUG_PROC_KEYS after Linux 4.0
    
    Closes: https://bugs.gentoo.org/552512
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 sys-apps/keyutils/keyutils-1.5.10.ebuild   | 9 ++++++---
 sys-apps/keyutils/keyutils-1.5.9-r4.ebuild | 7 +++++--
 2 files changed, 11 insertions(+), 5 deletions(-)