Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 549140 - dev-qt/qtcore:5 and dev-qt/qtgui:5 inject -O3 into CXXFLAGS
Summary: dev-qt/qtcore:5 and dev-qt/qtgui:5 inject -O3 into CXXFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qt-5.4.2-stable
  Show dependency tree
 
Reported: 2015-05-11 04:50 UTC by Jeroen Roovers (RETIRED)
Modified: 2018-02-06 13:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2015-05-11 04:50:32 UTC
>>> Compiling source in /dev/shm/portage/dev-qt/qtgui-5.4.1-r1/work/qtbase-opensource-src-5.4.1 ...
 * Running emake in src/gui
make -j3
powerpc64-unknown-linux-gnu-g++ -c -O2 -g -pipe -mcpu=G5 -mtune=G5 -maltivec -Wall -O3 ...
Comment 1 Davide Pesavento (RETIRED) gentoo-dev 2015-05-11 12:03:35 UTC
Yes, this is expected. It was introduced in 5.3 and is enabled for qtcore and qtgui. See http://code.qt.io/cgit/qt/qtbase.git/commit/?id=cd652500af18671e0d64b30d51c79a0c45b973a3

I'm inclined to leave it as-is. Does it cause any problems?
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2015-05-16 05:00:44 UTC
I'm sure it will break. Especially the niche architectures are somewhat volatile in the face of novel compiler optimisations. Gentoo has a QA policy about this kind of thing for a reason.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2015-07-12 16:49:20 UTC
I agree, we should fully respect CFLAGS.
Comment 4 Davide Pesavento (RETIRED) gentoo-dev 2015-07-15 01:49:40 UTC
I don't disagree in principle, but what exactly does "fully respect CFLAGS" mean? And how is -O3 different from other -ffoo flags that sometimes upstreams add to their software?
Comment 5 Michael Palimaka (kensington) gentoo-dev 2015-07-15 13:50:40 UTC
I'm not sure what you mean...randomly overriding user CFLAGs for no reason has never been allowed.
Comment 6 Davide Pesavento (RETIRED) gentoo-dev 2015-08-07 02:03:14 UTC
(In reply to Michael Palimaka (kensington) from comment #5)
> I'm not sure what you mean...randomly overriding user CFLAGs for no reason
> has never been allowed.

It's not "for no reason"... please read the upstream commit message.

I'll fix this but how about adding also a 'replace-flags -O2 -O3' for amd64?
Comment 7 Davide Pesavento (RETIRED) gentoo-dev 2015-08-07 02:28:22 UTC
Actually, I don't really care.

Fixed in cvs.
https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/qt5-build.eclass?r1=1.22&r2=1.23
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2015-08-08 07:29:17 UTC
(In reply to Davide Pesavento from comment #6)
> (In reply to Michael Palimaka (kensington) from comment #5)
> > I'm not sure what you mean...randomly overriding user CFLAGs for no reason
> > has never been allowed.
> 
> It's not "for no reason"... please read the upstream commit message.

It would have been nice if upstream had instead figured out which specific -O3 feature they wanted.