Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 548542 - dev-libs/crypto++ doesn't provide a pkg-config file
Summary: dev-libs/crypto++ doesn't provide a pkg-config file
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Crypto team [DISABLED]
URL: https://github.com/weidai11/cryptopp/...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 548544
  Show dependency tree
 
Reported: 2015-05-03 23:04 UTC by Fat-Zer
Modified: 2018-05-03 11:32 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libcrypto++.pc.in file (libcrypto++.pc.in,242 bytes, text/plain)
2015-05-03 23:21 UTC, Fat-Zer
Details
the propoused patch for the ebuild (crypto++-5.6.2-r1.ebuild.patch,712 bytes, patch)
2015-05-03 23:26 UTC, Fat-Zer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fat-Zer 2015-05-03 23:04:59 UTC
The upstream doesn't supply this file as well. But at least the debian does so. It would be nice that gentoo do the same way.

Reproducible: Always
Comment 1 Fat-Zer 2015-05-03 23:21:34 UTC
Created attachment 402578 [details]
libcrypto++.pc.in file

Here is a pc.in file to be used in the ebuild (fairly stolen from debian package).
Comment 2 Fat-Zer 2015-05-03 23:26:07 UTC
Created attachment 402580 [details, diff]
the propoused patch for the ebuild

Here is a propoused patch. also it requres above file to be placed in the FILESDIR.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2015-05-09 18:57:26 UTC
Note that it's typically frowned upon to make downstream additions/modifications to pkg-config files.
Comment 4 Alon Bar-Lev (RETIRED) gentoo-dev 2015-05-09 19:03:17 UTC
Have you tried to approach upstream to add this?
Comment 5 Fat-Zer 2015-05-12 08:35:12 UTC
(In reply to Alon Bar-Lev from comment #4)
> Have you tried to approach upstream to add this?

Nope, I haven't... As far as upstream haven't incorporated autotools (or some other modern enough build system) and uses general Makefile, I don't know even how to start the talk about a *.pc file.

According to mail-archive there were a thread about it on the maillist several years ago, but it seems it result in nothing but patching the debian package with autotools:
http://www.mail-archive.com/cryptopp-users%40googlegroups.com/msg04378.html

Also I'm not sure how alive the upstream is: there was no commit to svn since last release.
Comment 6 Julian Ospald 2015-08-18 16:52:30 UTC
This should be closed as invalid IMO. As already said, this is not packager business.
Comment 7 Jason A. Donenfeld gentoo-dev 2016-04-17 04:34:37 UTC
Fixed.
Comment 8 Alon Bar-Lev (RETIRED) gentoo-dev 2016-04-17 04:43:40 UTC
(In reply to Jason A. Donenfeld from comment #7)
> Fixed.

Do you want to be a maintainer of this package? If so, please assign your self, remove crypto.
Comment 9 Alon Bar-Lev (RETIRED) gentoo-dev 2016-04-17 04:55:11 UTC
Reverted, poor quality.

1. Not sure why you copy and then sed -i, while you can sed to final destination.
2. Not sure why you use WORKDIR and not T.
3. If the file is a template, it should be with .in suffix and substs should be standard @v@

Regardless, when we add patches we first submit to upstream for acceptance. This means that it should write it in proper way for them to be merged.

Once again, having a pkg-config is upstream task, downstream should not add such by its own, it may create a lot of breakages.
Comment 10 Alon Bar-Lev (RETIRED) gentoo-dev 2016-04-17 05:01:29 UTC
Also see [1] for upstream handle.
If it is a require artifact, feel free to discuss it here.
So far we did not find mandatory reason to include it as many other libraries whose upstream do not provide it.

[1] https://github.com/weidai11/cryptopp/issues/133
Comment 11 Ulenrich 2016-04-17 10:21:28 UTC
@Bar-Lev
reverting your revert helped  
to compile the media-sound/clementine-1.3

Whats the point of a dev-lib existing but not usable?
As a hobbyista Gentoo user I needed two hours to find out.
... not amused about Gentoo developers fighting.
Comment 12 Alon Bar-Lev (RETIRED) gentoo-dev 2016-04-17 10:26:54 UTC
(In reply to Ulenrich from comment #11)
> @Bar-Lev
> reverting your revert helped  
> to compile the media-sound/clementine-1.3
> 
> Whats the point of a dev-lib existing but not usable?
> As a hobbyista Gentoo user I needed two hours to find out.
> ... not amused about Gentoo developers fighting.

I do not know what is media-sound/clementine-1.3, nor do I know if it can be modified to be built with libcrypto++ upstream without pkg-config.
Comment 13 Ulenrich 2016-04-17 14:27:18 UTC
it cannot been built, see my tries at:
https://bugs.gentoo.org/show_bug.cgi?id=580134#c1
Comment 14 Alon Bar-Lev (RETIRED) gentoo-dev 2016-06-04 19:02:52 UTC
Upstream is against pkg-config, dependencies should not require it.