Hi team Gentoo, Is it possible to add in portage the last stable version of Clementine (1.3) which is available here : https://github.com/clementine-player/Clementine/releases Thanks ! Reproducible: Always
clementine-1.3 landed but following dependency does not exist yet in portage dev-libs/crypto++-5.6.2-r4 I now just try to compile with existing dev-libs/crypto++-5.6.2-r3
fails with dev-libs/crypto++-5.6.2-r3 -- Checking for module 'libspotify>=12.1.45' -- -- Checking for module 'taglib>=1.6' -- Found taglib, version 1.10 -- Performing Test TAGLIB_HAS_OPUS -- Performing Test TAGLIB_HAS_OPUS - Success CMake Error at CMakeLists.txt:278 (message): Either crypto++ must be available or the non-GPL Spotify code must be compiled in
Tried with one of https://gpo.zugaina.org/dev-libs/libspotify but same result using: dev-libs/libspotify-12.1.51 --- -- Checking for module 'libspotify>=12.1.45' -- Clementine did not find it
depends on https://bugs.gentoo.org/show_bug.cgi?id=548542#c9 where @Bar-Lev revoked dev-libs/crypto++-5.6.2-r4
When package assumes a dependency to behave in particular way, it does not mean that the dependency should just change. libcrypto++ does not provide pkg-config file, this means that this (and other) dependencies should not make this assumption, nor "change" libcrypto++ just for the sake of an assumption. In autoconf it was easy to specify LIBCRYPTOPP_CFLAGS="" and LIBCRYPTOPP_LIBS="-lcrypto++" to configure and resolve this mess. I am not expert in cmake, but as long this upstream wrongly assumes pkg-config for libcrypto, there should be a way to override this as well, I've done some reading it should be by defining these variables (or other): XCRYPTOPP_FOUND=1 XCRYPTOPP_LIBRARIES=crypto++ XCRYPTOPP_LDFLAGS=-lcrypto++ XCRYPTOPP_INCLUDE_DIR= XCRYPTOPP_CFLAGS= XCRYPTOPP=CRYPTOPP Please help fix this ebuild if you know cmake better. Please help to push upstream a variant that fallback to searching libcrypto++ as library if pkg-config fails, to meet upstream release management. Thanks.
@Alon: please make sure to run repoman before widely removing a package's dep. Removing libcrypto++ broke the tree: https://qa-reports.gentoo.org/output/gentoo-ci/a9608ae/output.html#media-sound/clementine I have masked clementine-1.3 for now to address this warning: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b6f6a35b0f0972e82c8addb7af748c075d801482 Please fix and remove the mask once everything's settled again. Thanks!
There was a patch for media-sound/clementine-9999 in #548544 to force the libcrypto++ be found without altering the crypto++ ebuild: https://bugs.gentoo.org/attachment.cgi?id=403742 Those lines was removed from 9999 a month ago and I'm not really understand why: https://gitweb.gentoo.org/repo/gentoo.git/commit/media-sound/clementine/clementine-9999.ebuild?id=798265666093d42ba44871fbb932594cebd321d1
Also Nikoli is long known as inactive. This package is destined for maintainer-needed unless another user offers to proxy maintain it.
(In reply to Ian Delaney from comment #8) > Also Nikoli is long known as inactive. This package is destined for > maintainer-needed unless another user offers to proxy maintain it. I may take up the maintainership...
(In reply to Fat-Zer from comment #9) > (In reply to Ian Delaney from comment #8) > > Also Nikoli is long known as inactive. This package is destined for > > maintainer-needed unless another user offers to proxy maintain it. > > I may take up the maintainership... go right ahead. You can review and re-prepare and ebuilds and patches presented here with 'your name' on them.
Done some time ago.
