mesa can be compiled with --enable-opencl-icd. This can be used to build the library with an icd loader for OpenCL. The mesa OpenCL platform then becomes available when dev-libs/ocl-icd is installed and the opencl eselect profile is set to ocl-icd. I think a use flag to compile mesa with OpenCL icd support is appropriate. Reproducible: Always
Is there a benefit in it being configurable, or should we simply use --enable-opencl-icd whenever USE=opencl is enabled?
You may enable it by default, this will be a good choise, but it is a possible case when user want opencl support, but doesn't want icd interface, e.g. to reduce size, codepath or to improve security.
Having this in portage would also help with running binary only apps that require OPENCL_1.0 versioned symbols. dev-libs/ocl-icd already exports it, mesa developers don't seem willing to do it. See https://bugs.freedesktop.org/show_bug.cgi?id=61417
Created attachment 504462 [details, diff] mesa-17.3.0_rc4.ebuild.patch Patch that adds the the opencl-icd use flag to the latest version of mesa in portage
Created attachment 504466 [details, diff] mesa-17.3.0_rc4.ebuild.patch Fix typo
Come on, this is a trivial fix, and if you still have doubts about adding an use flag for it or not: you definitely want to add an use flag as dev-libs/ocl-icd is using ruby, and a lot of people with minimalist installs would be annoyed if mesa would suddenly drag it in for no reason.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e276a5eab8552202db5988843c41ef7007759475 commit e276a5eab8552202db5988843c41ef7007759475 Author: Jan Vesely <jano.vesely@gmail.com> AuthorDate: 2018-10-06 17:06:24 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2018-10-08 15:43:13 +0000 media-libs/mesa: Use ICD version of OpenCL Closes: https://github.com/gentoo/gentoo/pull/9836 Closes: https://bugs.gentoo.org/546320 Signed-off-by: Jan Vesely <jano.vesely@gmail.com> Signed-off-by: Matt Turner <mattst88@gentoo.org> media-libs/mesa/mesa-18.2.2-r1.ebuild | 526 ++++++++++++++++++++++++++++++++++ media-libs/mesa/mesa-9999.ebuild | 34 +-- 2 files changed, 532 insertions(+), 28 deletions(-)
