Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 542252 - sys-devel/libtool: getting rid of 180,000 sed forks
Summary: sys-devel/libtool: getting rid of 180,000 sed forks
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL: http://debbugs.gnu.org/cgi/bugreport....
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2015-03-05 12:01 UTC by Florian Steinel
Modified: 2024-01-14 18:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libtool-2.4.4.ebuild modifed to apply the patch from Harald Hoyer (libtool-2.4.4.ebuild,2.19 KB, text/plain)
2015-03-05 12:01 UTC, Florian Steinel
Details
libtool-2.4.4-sed.patch modified to applay to the source of libtool (libtool-2.4.4-sed.patch,1.19 KB, patch)
2015-03-05 12:02 UTC, Florian Steinel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Steinel 2015-03-05 12:01:56 UTC
Created attachment 398146 [details]
libtool-2.4.4.ebuild modifed to apply the patch from Harald Hoyer

Description is at
https://harald.hoyer.xyz/2015/03/05/libtool-getting-rid-of-180000-sed-forks/
Upstream report http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20006
Comment 1 Florian Steinel 2015-03-05 12:02:47 UTC
Created attachment 398148 [details, diff]
libtool-2.4.4-sed.patch modified to applay to the source of libtool
Comment 2 SpanKY gentoo-dev 2015-03-05 16:52:48 UTC
going to wait until upstream sorts it out
Comment 3 Oleh 2016-01-06 14:11:18 UTC
it's supposedly fixed in libtool upstream
http://git.savannah.gnu.org/cgit/libtool.git/commit/?id=32f0df9835ac15ac17e04be57c368172c3ad1d19
so wait until new release, or install libtool-9999
Comment 4 SpanKY gentoo-dev 2016-02-13 08:55:19 UTC
i've grabbed the fix from upstream and it's in libtool-2.4.6-r2 now:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5f4225eb727dcd8cc0eebd60620d4b2b160712aa
Comment 5 Larry the Git Cow gentoo-dev 2024-01-14 18:14:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/elt-patches.git/commit/?id=6c423a0961c235b9a898d21954705a3b8f943d1f

commit 6c423a0961c235b9a898d21954705a3b8f943d1f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-14 18:07:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-14 18:10:49 +0000

    patches: sed-quote: add new patch
    
    See https://harald.hoyer.xyz/2015/03/05/libtool-getting-rid-of-180000-sed-forks/
    
    Interestingly, at the time, we added the patch to sys-devel/libtool in 5f4225eb727dcd8cc0eebd60620d4b2b160712aa,
    but we never pulled it into elt-patches.
    
    Note that we could try to pull in two more fixes:
    * 'libtool: optimizing options-parser hooks' (https://git.savannah.gnu.org/cgit/libtool.git/commit/?id=16dbc070d32e6d4601cb5878dfdf69f2e29c84e1)
    * 'funclib: refactor quoting methods a bit' (https://git.savannah.gnu.org/cgit/libtool.git/commit/?id=9187e9a231e0a06cc29c336857e95f07f855b2c9)
    
    Unconvinced it's worth it for those though: they're a lot bigger and they affect
    the API of the functions so more care is needed with any risk of fuzz, etc.
    
    Bug: https://bugs.gnu.org/20006
    Bug: https://bugs.gentoo.org/542252
    Signed-off-by: Sam James <sam@gentoo.org>

 eltpatch.in             |   2 +-
 patches/sed-quote/2.4.6 | 128 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 129 insertions(+), 1 deletion(-)