Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 53729 - win4lin-sources 2.6.6 does not compile modules
Summary: win4lin-sources 2.6.6 does not compile modules
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: High major (vote)
Assignee: x86-kernel@gentoo.org (DEPRECATED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 58048
  Show dependency tree
 
Reported: 2004-06-12 11:01 UTC by Karl Huysmans
Modified: 2004-07-31 15:46 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
win4lin-sources-2.6.6-r2.ebuild (win4lin-sources-2.6.6-r2.ebuild,2.90 KB, text/plain)
2004-06-19 18:16 UTC, Derk W te Bokkel
Details
win4lin-sources-2.6.6-r2.ebuild (eclass version) (win4lin-sources-2.6.6-r2.ebuild,1.21 KB, text/ebuild)
2004-06-24 11:06 UTC, Charles Phoenix
Details
win4lin-sources-2.6.6-r2.ebuild (eclass version) (win4lin-sources-2.6.6-r2.ebuild,1.22 KB, text/ebuild)
2004-06-24 11:12 UTC, Charles Phoenix
Details
win4lin-sources-2.6.7-r1.ebuild (win4lin-sources-2.6.7-r1.ebuild,1.29 KB, patch)
2004-07-03 05:49 UTC, Harald van Dijk (RETIRED)
Details | Diff
win4lin-sources-2.6.7-r3 (win4lin-sources-2.6.7-r3.ebuild,1.56 KB, text/plain)
2004-07-13 16:44 UTC, Derk W te Bokkel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Huysmans 2004-06-12 11:01:07 UTC
config has CONFIG_MKI=y

Previous kernel versions compile the modules correctly:

#find /lib/modules | grep -i mki

./2.6.4/kernel/arch/i386/mki-adapter26
./2.6.4/kernel/arch/i386/mki-adapter26/mki-adapter.ko
./2.6.5/kernel/arch/i386/mki-adapter26
./2.6.5/kernel/arch/i386/mki-adapter26/mki-adapter.ko

Nothing for 2.6.6-win4lin

Tried this with 2 different gentoo boxes.

Reproducible: Always
Steps to Reproduce:
1.emerge win4lin-sources
2.compile kernel
3.
Comment 1 Peter Ruskin 2004-06-12 14:21:04 UTC
Happens here too.
Comment 2 Michael W. Holdeman 2004-06-14 10:51:36 UTC
I solved this by copying ~/linux/mki-adapter26-old/arch/i386/mki-adapter26 and its contents to ~/linux/arch/i386.

Then built the kernel and all went well.

Did this on 3 different machines, all ~x86 machines.
Comment 3 Derk W te Bokkel 2004-06-19 18:16:20 UTC
Created attachment 33604 [details]
win4lin-sources-2.6.6-r2.ebuild

old style ebuild .. crufty etc. .. works but may have quirks
Comment 4 Charles Phoenix 2004-06-24 11:06:28 UTC
Created attachment 34067 [details]
win4lin-sources-2.6.6-r2.ebuild (eclass version)

The "problem" is the mki-adapter26_1_3_5.patch is not being applied properly.
This undoubtly has to do with the new eclass.
I made a simple hack which applies the patch correctly - the old way.
Yes, I know the patch is being applied twice, but the eclass is doing it
incorrectly.
Side note: eclasses are "kewl", imagine them as default "modules" with
inheritance
Comment 5 Charles Phoenix 2004-06-24 11:12:26 UTC
Created attachment 34068 [details]
win4lin-sources-2.6.6-r2.ebuild (eclass version)

The orginal win4lin-sources-2.6.6-r1.ebuild does not use the $MKI_VERSION
variable in the SRC_URI variable - fixed.
Comment 6 Michal Januszewski (RETIRED) gentoo-dev 2004-07-03 02:45:24 UTC
I've just bumped win4lin-sources to 2.6.7 and added a new mki-adapter patch, so I'm closing this bug. Please reopen is the problem still occurs.
Comment 7 Harald van Dijk (RETIRED) gentoo-dev 2004-07-03 05:49:05 UTC
Created attachment 34705 [details, diff]
win4lin-sources-2.6.7-r1.ebuild

2.6.7-r1 still has the same problem. I modified the patch so that
kernel-2.eclass can just handle it properly. The patch could instead be removed
from UNIPATCH_LIST and applied from the ebuild as in 2.6.6-r2, but I think it
should be one or the other, as the 2.6.6-r2 ebuild seems to apply it twice.
Comment 8 Harald van Dijk (RETIRED) gentoo-dev 2004-07-04 02:06:34 UTC
Oops, that was an accident. That's not a patch, of course. Sorry.
Comment 9 Derk W te Bokkel 2004-07-13 16:44:59 UTC
Created attachment 35356 [details]
win4lin-sources-2.6.7-r3

this form of the win4lin-sources-2.6.7-r3 ebuild works .. the other "sed" style
does not(commented out in this ebuild) ..

of course it double patches but the mki-adapter26-old sub-directory at the top
level is ignored when building the kernel ..
Comment 10 Rodrigo Severo 2004-07-16 17:53:03 UTC
Just to leave a note: I have just emerged the 2.6.7-win4lin-r2 sources and it still doesn't create the mki-adapter module by itself.

I aplied the mki-adapter patch manually and everything got built correctly.

I believe this bug should be reopened. Or should I create a new one?
Comment 11 Charles Phoenix 2004-07-16 19:19:56 UTC
to all concern: patiently wait...

John Mylchreest said he was going to modify the eclass to allow explict patch levels - still waiting :) It will solve this problem period.

{patch_filename}:{pathlevel}

All that will have to be changed is 
${DISTDIR}/mki-adapter26_${MKI_VERSION}.patch
to 
${DISTDIR}/mki-adapter26_${MKI_VERSION}.patch:1

Sidenote: Doesn't hurt to talk to the developer(s) instead of making numerious workaround, no?

Also please note: 
1) the problem has not been acknowledge (see #6), it was not the patch itself but HOW the patch is being applied. This is due to using the new  kernel-2.eclass.
2) nor has any solution been accepted (see win4lin-sources-2.6.7-r2, no change, not even a hack.) #10 points out the problem still exists.

Any listening? 

Use the hack until John Mylchreest implements the changes and everyone will be happy.
Comment 12 Rodrigo Severo 2004-07-17 04:55:08 UTC
Commenting on #11 prooposed hack:

It didn't work for me. I had to make that change in /usr/portage/sys-kernel/win4lin-sources/win4lin-sources-2.6.7-r2.ebuild file, right?

Well, I'm still apllying mki-adapter patch manually...
Comment 13 Harald van Dijk (RETIRED) gentoo-dev 2004-07-19 23:11:30 UTC
I am glad to hear that a proper fix is underway. I would like to ask what the problem you had with my sed hack was, though. Are you sure that you modified the UNIPATCH_LIST as well as adding a new src_unpack? I changed ${DISTDIR}/mki-adapter26_${MKI_VERSION}.patch to ${WORKDIR}/mki-adapter26_${MKI_VERSION}.patch. I ask because I just tried it myself with 2.6.7-r3, and it built the module as it should. I am curious about what I did differently.
Comment 14 Rodrigo Severo 2004-07-20 03:31:10 UTC
No, I didn't. I got the present 2.6.7-r2 ebuild and just made the ":1" change you mentioned.

I think I got it now: I have to get the ebuild from #9 and make the modification you proposed in #11, is that right?

I won't be able to try it now as I'm already late for airport but please leave a note to let me know exactly what should I try and I will do it tomorow.
Comment 15 Charles Phoenix 2004-07-20 04:43:29 UTC
To answer #14.

:1 is the future fix, which I am patiently waiting for

win4lin-sources-2.6.7-r3 is most current ebuild USING the hack and should work without modification. The commented 'src_unpack' section is the sed hack. The 'src_unpack' section at the bottom is the "old-way" hack.

Any questions. :)
Comment 16 Harald van Dijk (RETIRED) gentoo-dev 2004-07-20 18:44:58 UTC
I'm sorry, that was not at all clear of me. My previous question was in reply to comment #9.
Comment 17 Rodrigo Severo 2004-07-22 03:32:29 UTC
win4lin-sources-2.6.7-r3.ebuild isn't working either, as far as I can tell.

It's choking on the lack of "win4lin-sources.CAN-2004-0497.patch".

After I removed it from UNIPATCH_LIST, the ebuild choke on the lack of "win4lin-sources-2.6.IPTables-RDoS.patch".

I believe "win4lin-sources-2.6.ProcPerms.patch" would also be a problem as none of these three files are listed in SRC_URI. Or am I missing something?
Comment 18 Charles Phoenix 2004-07-22 04:01:15 UTC
There are two source of files, one which downloads files to /distfile directory and other is in /files directory with the ebuild - this is where the patches are hiding.

So make a link from (will save you future trouble)
/usr/portage/sys-kernel/win4lin-sources/files

to 
{location of local portage tree}/sys-kernel/win4lin-sources/files

The variable ${FILESDIR} is relative to the ebuild file.
Comment 19 Rodrigo Severo 2004-07-22 11:27:45 UTC
Extra info on win4lin-sources-2.6.7-r3.ebuild. I was making a mess with win4lin-sources-2.6.7-r3. I thought it wasn't yet available on regular portage so I downloaded it from this page. This is the reason for the "files not available" problems I reported on #17. Having clarified this point let me report my experiences with the real win4lin-sources-2.6.7-r3.ebuild:

the mki-adapter module is still not created. I still have to manually (re)aply the mki-adapter patch.

As far as I can tell, win4lin-sources-2.6.7-r3.ebuild is no-go.
Comment 20 Charles Phoenix 2004-07-22 21:28:01 UTC
Enough already...

http://bugs.gentoo.org/show_bug.cgi?id=58008

1) commented out the patch in UNIPATCH_LIST so it is not applied twiced
2) added a line so that if placed in the local portage tree it will
link to the patch files - no more missing files
3) make a new report so all can see. 

Would you believe other people are having problems with win4lin not working?
Comment 21 Rodrigo Severo 2004-07-24 06:17:45 UTC
I have just tested win4lin-sources-2.6.7-r4.ebuild from http://bugs.gentoo.org/show_bug.cgi?id=58008. It works!! I mean, mki-adapter module gets built.

Despite being refered to as a hack I think win4lin-sources-2.6.7-r4.ebuild should be published as the present stable win4lin-sources ebuild doesn't work with win4lin (no mki_adapter module).

And them this bug could be considered RESOLVED/FIXED. Ops, it's already RESOLVED/FIXED ;)