Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 534330 - [TRACKER] x11-libs/gdk-pixbuf[X] removal
Summary: [TRACKER] x11-libs/gdk-pixbuf[X] removal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard: gdk-pixbuf-xlib removed in v2.42.0
Keywords: Tracker
: 754048 (view as bug list)
Depends on: 582090 605930 611246 613320 753890 753893 753896 753899 753905 753908 753911 753914 753917 753920 753923 753926 753929 753932
Blocks:
  Show dependency tree
 
Reported: 2015-01-02 14:12 UTC by Mart Raudsepp
Modified: 2020-11-26 03:42 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2015-01-02 14:12:07 UTC
It doesn't seem that x11-libs/gdk-pixbuf USE=X does anything other than provide the gdk-pixbuf-xlib-2.0.pc package and the related library out of gdk-pixbuf source trees contrib/ directory.
However various packages, including gtk+:2 and gtk+:3 USE depend on it. But I don't see usage of that library anywhere - which makes sense, because it's a library for usage by pure xlib applications for image decoding and such.

I think we should:

* Try to see that there are no missing gdk-pixbuf X USE deps on packages that actually need gdk-pixbuf-xlib
* Remove IUSE default from gdk-pixbuf
* Remove wrong gdk-pixbuf[X] dependencies from many other packages than gtk+ (I found libreoffice from what I have installed, and it doesn't seem to link to it at least) - many of them are probably just historical from gdk-pixbuf having been inside gtk+ before, and it being a gtk+[X] before for obvious reasons.
* Remove technically wrong gdk-pixbuf[X] dependency on the gtk+ SLOT if my claims are correct; this assumes point 1 is somewhat well done, as some consumers of gdk-pixbuf-xlib might have depended on it indirectly with gtk+[X]


Comments, acks?
Comment 1 Mart Raudsepp gentoo-dev 2015-07-21 05:29:38 UTC
> Comments, acks?
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2015-07-22 20:29:55 UTC
Ack. I should be easy to do, maybe Tranquillity could have a look at it.
Comment 3 Mart Raudsepp gentoo-dev 2016-05-04 14:39:06 UTC
Information for depend bugs to help figure out if it's really needed dep or not:

gdk-pixbuf USE=X builds the extra library libgdk_pixbuf_xlib-2.0.so.0 and provides the gdk-pixbuf-xlib-2.0.pc pkg-config package.

The extra library defines the following public functions:

gdk_pixbuf_xlib_get_from_drawable
gdk_pixbuf_xlib_init
gdk_pixbuf_xlib_init_with_depth
gdk_pixbuf_xlib_render_pixmap_and_mask
gdk_pixbuf_xlib_render_threshold_alpha
gdk_pixbuf_xlib_render_to_drawable
gdk_pixbuf_xlib_render_to_drawable_alpha
xlib_draw_gray_image
xlib_draw_indexed_image
xlib_draw_rgb_32_image
xlib_draw_rgb_image
xlib_draw_rgb_image_dithalign
xlib_rgb_cmap_free
xlib_rgb_cmap_new
xlib_rgb_ditherable
xlib_rgb_gc_set_background
xlib_rgb_gc_set_foreground
xlib_rgb_get_cmap
xlib_rgb_get_depth
xlib_rgb_get_display
xlib_rgb_get_screen
xlib_rgb_get_visual
xlib_rgb_get_visual_info
xlib_rgb_init
xlib_rgb_init_with_depth
xlib_rgb_set_install
xlib_rgb_set_min_colors
xlib_rgb_set_verbose
xlib_rgb_xpixel_from_rgb
Comment 4 Mart Raudsepp gentoo-dev 2017-01-16 22:38:43 UTC
I've removed gdk-pixbuf[X] depend from gtk+:2 and gtk+:3 latest ~arch revisions after reviewing all the gtk+[X] using packages in main tree to not be using any gdk_pixbuf_xlib stuff.
I have not reviewed  (besides the filed w3m bug that just happened to show up as a preserved-lib) any of the gdk-pixbuf dependencies, if they have an unnecessary USE=X depend or are missing it, so this bug itself as a tracker and that reviewing work remains open - we just never had a gtk+ bug on the subject matter that blocks this tracker.
Comment 5 Matt Turner gentoo-dev 2020-11-10 18:46:14 UTC
The xlib bits are now in an archived repository: https://gitlab.gnome.org/Archive/gdk-pixbuf-xlib
Comment 6 Matt Turner gentoo-dev 2020-11-10 19:24:32 UTC
(In reply to Matt Turner from comment #5)
> The xlib bits are now in an archived repository:
> https://gitlab.gnome.org/Archive/gdk-pixbuf-xlib

My expectation is that some of the dependencies on gdk-pixbuf[X] are unnecessary, and some are clearly still correct and needed. We should fix the incorrect dependencies and then probably package gdk-pixbuf-xlib separately for the real consumers.
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2020-11-11 18:39:52 UTC
*** Bug 754048 has been marked as a duplicate of this bug. ***
Comment 8 Larry the Git Cow gentoo-dev 2020-11-14 16:34:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2752ea859f10bfc0cd26793605d61592f642ee9b

commit 2752ea859f10bfc0cd26793605d61592f642ee9b
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2020-11-14 16:33:58 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2020-11-14 16:33:58 +0000

    x11-libs/gdk-pixbuf-xlib: Initial commit
    
    with kind permission from mattst88
    
    Bug: https://bugs.gentoo.org/534330
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 x11-libs/gdk-pixbuf-xlib/Manifest                  |  1 +
 .../gdk-pixbuf-xlib/gdk-pixbuf-xlib-2.40.2.ebuild  | 43 ++++++++++++++++++++++
 x11-libs/gdk-pixbuf-xlib/metadata.xml              | 11 ++++++
 3 files changed, 55 insertions(+)