Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 53050 - KDE knode CJK patch
Summary: KDE knode CJK patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: CJK Team
URL: http://www.magiclinux.org
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-05 05:54 UTC by Jackey Yang ("timeout" in forum)
Modified: 2004-11-09 09:13 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kdepim-3.2.2-cjk.diff (kdepim-3.2.2-cjk.diff,6.79 KB, patch)
2004-06-05 05:55 UTC, Jackey Yang ("timeout" in forum)
Details | Diff
snapshot-zh_CN.png (snapshot-zh_CN.png,39.85 KB, image/png)
2004-06-29 10:05 UTC, Jackey Yang ("timeout" in forum)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jackey Yang ("timeout" in forum) 2004-06-05 05:54:44 UTC
Fix knode can not view cjk news groupname.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Jackey Yang ("timeout" in forum) 2004-06-05 05:55:45 UTC
Created attachment 32700 [details, diff]
kdepim-3.2.2-cjk.diff

knode patch for cjk users
Comment 2 Jason Stubbs (RETIRED) gentoo-dev 2004-06-05 05:57:59 UTC
Will test this on Monday.
Comment 3 Jackey Yang ("timeout" in forum) 2004-06-05 07:55:53 UTC
use cjk flag in your ebuild if you are cjk users
Comment 4 Jackey Yang ("timeout" in forum) 2004-06-24 05:27:50 UTC
it works for kdepim-3.2.3 too.
Comment 5 Jackey Yang ("timeout" in forum) 2004-06-28 04:57:38 UTC
For none zh_CN users, you may have to modify the following source in the patch, 34 is for Simplified Chinese, i do not know what is for Japanese or Korean, sorry about that*^_^*
-  a_ctSetCharset->setCurrentItem(0);
+  a_ctSetCharset->setCurrentItem(34);
Comment 6 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-06-29 08:30:11 UTC
I wanted to try it but I don't know any news group which has Japanese name :(
Comment 7 Jackey Yang ("timeout" in forum) 2004-06-29 10:05:26 UTC
Created attachment 34429 [details]
snapshot-zh_CN.png

Snapshot for Simplified Chinese on webking.online.jn.sd.cn
You guys can try, i am sure that you will get lots of ??? without this
patch*^_^*
Comment 8 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-07-04 07:23:20 UTC
Right. The patch actually displays Chinese newsgroup name under
correct LC_* environemnt. kde team: do you mind if I add the patch
to kde-3.2.3 (and kde-3.3.0_alpha1)?
Comment 9 Jackey Yang ("timeout" in forum) 2004-07-04 07:34:23 UTC
do what ever you want with my patches.My patches are GPL like Gentoo other patches.
But i really like to test with japnese and korean users first.
If there is a problem with my patch, i can fix it ASAP.

I am working on Gentoo chinese local portage project. We got lots of patches to help cjk users, but most of them are hack for chinese, so i have to fix them first before i submit here.
Comment 10 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-07-05 04:43:32 UTC
Jackey, I was asking for KDE herd people to include the patch.
It is not us (cjk herd) but they (kde herd) who maintain kdepim.
For example, if they want to upgrade kdepim to, say, 3.4.0 and
find cjk patch fails, they should fix it (Of course they may ask
it to cjk herd or directory to you). So it is important to inform
them what's going on.(They are the primary maintaining herd)

As for the patch, I never heard of Japanese newsgroup name
(I used to read fj.* and japan.*, the most famous newsgroups 
among Japanese, and they use only ascii characters for 
newsgroup name). So I think it's ok to ignore Japanese in
this respect (not sure about Korean). 
Comment 11 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-11-07 07:07:01 UTC
Finally I added the patch to CVS. It also applies to kdepim-3.3.1,
and works with Chinese news group name. If there is any Japanese
news group, I'll modify the patch to incorporate it. Jackey, sorry
for the delay and thanks for the contribution.
Comment 12 Jackey Yang ("timeout" in forum) 2004-11-07 20:53:00 UTC
Thx Mamoru, 
Did you try my amarok patch yet?
http://bugs.gentoo.org/show_bug.cgi?id=67915
This patch is a little bit dirty but works, you can modified if you want to.

Do you realize that juk also had a CJK problem, since
the orignal developer refused to add following patch into KDE, i think we can
just add as CJK patch.
http://bugs.gentoo.org/show_bug.cgi?id=51582

Recently, i put all our protage project into cvs, you can find it from 
http://www.magiclinux.org/viewcvs.cgi, we started a local USE flag called glc(Gentoo Linux Chinese) to make a difference with cjk, and you can always download latest cjk patch from there. I will try to update all the previous patches i submitted *^_^*, cross my big fingers.

Comment 13 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-11-08 01:19:15 UTC
Yeah, I know, but I'd like to test it over again
because the last time I checked kde-3.3.x was
not yet released. Thanks anyways.

P.S. I tried to access the ViewCVS site but
got Forbidden error. Will you have a look
at its permission?
Comment 14 Jackey Yang ("timeout" in forum) 2004-11-08 08:19:52 UTC
woops, should be http://www.magiclinux.org/cgi-bin/viewcvs.cgi/
Comment 15 Jackey Yang ("timeout" in forum) 2004-11-08 18:06:39 UTC
BTW, this patch set default encoding to zh_CN.GB18030
if you want to setup to your encoding, just change the
number to your encoing
a_ctSetCharset->setCurrentItem(34);

Good luck guys
Comment 16 Gregorio Guidi (RETIRED) gentoo-dev 2004-11-09 01:40:25 UTC
Has someone posted this patch here?

http://bugs.kde.org/show_bug.cgi?id=46989
Comment 17 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-11-09 09:13:26 UTC
Jackey: I suppose `use linguas_zh_CN` is better than `use cjk`,
what do you think about it? (linguas_zh_CN is set if LINGUAS
contain "zh_CN")

Gregorio: I'm afraid the patch is for localisation purpose and 
shouldn't be applied KDE wide. However, it's good to let knode
upstream know that there are Chinese users facing this problem
and we have a workaround for it. Jackey, would you post your
comment to the bug shown in comment #16?