Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 528280 - app-crypt/libu2f-host-0.0.1 version bump
Summary: app-crypt/libu2f-host-0.0.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Diego Elio Pettenò (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-05 08:58 UTC by BT
Modified: 2014-11-10 15:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libu2f-host-0.0.1.ebuild.patch (libu2f-host-0.0.1.ebuild.patch,581 bytes, patch)
2014-11-06 00:39 UTC, BT
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BT 2014-11-05 08:58:06 UTC
Changes:
- Use semantic versioning.
- Correct json key for keyHandle in signResponse.
- Fix the udev rule.
- Add option to install udev rule.
Comment 1 Rick Farina (Zero_Chaos) gentoo-dev 2014-11-05 16:57:39 UTC
+  05 Nov 2014; Rick Farina <zerochaos@gentoo.org> +libu2f-host-0.0.1.ebuild:
+  bump per bug #528280, adding USE=static-libs to disable building static-libs

Thanks, please keep the reports coming!
Comment 2 BT 2014-11-06 00:39:26 UTC
Created attachment 388646 [details, diff]
libu2f-host-0.0.1.ebuild.patch

Thank you for the bump, but you missed the upstream fixes to the 70-u2f.rules file.

The ebuild makes two sed calls in src_prepare(). The first sed pads 'idProduct' values with '0' in 70-u2f.rules. Upstream has fixed this so the first sed is no longer required.

The second sed replaces GROUP="plugdev" with TAG+="uaccess" in 70-u2f.rules for systemd installs. Upstream changed 70-u2f.rules so that it now works for systemd installs without modification. The second sed now needs to replace TAG+="uaccess" with MODE="0664", GROUP="plugdev" in 70-u2f.rules.

I have attached a patch with the changes needed.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2014-11-10 01:46:51 UTC
Rick, a heads'  up if you commit to my packages would be at least welcome.
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2014-11-10 02:24:39 UTC
Thanks, fixed.
Comment 5 BT 2014-11-10 04:14:55 UTC
(In reply to Diego Elio Pettenò from comment #4)
> Thanks, fixed.

I apologize for commenting on a closed bug, but your commit has an error. The sed in src_prepare() is editing 70-u2f.rules in place, leaving 70-u2f-udev.rules empty. You need to drop '-i' from the sed command.
Comment 6 BT 2014-11-10 06:29:21 UTC
(In reply to BT from comment #5)
> I apologize for commenting on a closed bug, but your commit has an error.
> The sed in src_prepare() is editing 70-u2f.rules in place, leaving
> 70-u2f-udev.rules empty. You need to drop '-i' from the sed command.

I opened a separate bug #528792.
Comment 7 Rick Farina (Zero_Chaos) gentoo-dev 2014-11-10 15:07:37 UTC
(In reply to Diego Elio Pettenò from comment #3)
> Rick, a heads'  up if you commit to my packages would be at least welcome.

I apologize, the note on the bug should send you an email, I didn't want to spam you twice.  It is very hard to keep track of the devs who choose to disable bug notification.