Layman bashcomp is very slow, even when it only needs to list layman options or just a dash. 1. enable layman bashcomp 2. open bash 3. write (without quotes) "layman " 4. press tab * bash thinks for a few !seconds! and adds a dash 5. press tab 2 times * bash thinks even more and then lists these layman options: -a --debug-classes --debug-verbose -k -N -p -s --add --debug-class-vars --delete -l --nocheck --priority -S -c --debug-level -f -L --nocolor -q --sync --config --debug-methods --fetch --list --nofetch -Q --sync-all -d --debug-nocolor -i --list-local -o --quiet -v --debug --debug-variables --info -n --overlays --quietness --verbose I could understand lags if layman actually listed packages like emerge bashcomp does or anything like that. But completing a list of options for a few seconds is unacceptable. Reproducible: Always $ emerge --info gentoo-bashcomp Portage 2.2.14_rc1 (python 3.3.5-final-0, default/linux/amd64/13.0/desktop/kde, gcc-4.8.3, glibc-2.19-r1, 3.17.1-gentoo-r1_gg20 x86_64) ================================================================= System Settings ================================================================= System uname: Linux-3.17.1-gentoo-r1_gg20-x86_64-Intel-R-_Core-TM-_i7-3517U_CPU_@_1.90GHz-with-gentoo-2.2 KiB Mem: 3941976 total, 115188 free KiB Swap: 4509692 total, 4095168 free Timestamp of tree: Thu, 23 Oct 2014 20:00:01 +0000 ld GNU ld (Gentoo 2.24 p1.4) 2.24 app-shells/bash: 4.3_p30 dev-java/java-config: 2.2.0 dev-lang/perl: 5.20.1-r1 dev-lang/python: 2.7.8, 3.3.5-r1, 3.4.2 dev-util/cmake: 3.0.2 dev-util/pkgconfig: 0.28-r2 sys-apps/baselayout: 2.2 sys-apps/openrc: 0.13.1 sys-apps/sandbox: 2.6-r1 sys-devel/autoconf: 2.13, 2.69 sys-devel/automake: 1.11.6, 1.14.1 sys-devel/binutils: 2.24-r3 sys-devel/gcc: 4.8.3 sys-devel/gcc-config: 1.8 sys-devel/libtool: 2.4.2-r1 sys-devel/make: 4.1 sys-kernel/linux-headers: 3.17 (virtual/os-headers) sys-libs/glibc: 2.19-r1 Repositories: gentoo tox-overlay aegypius qt chaos dotnet x-portage Installed sets: @qt5-addons, @qt5-essentials ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/themes/oxygen-gtk/gtk-2.0" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=native -O2 -pipe" DISTDIR="/usr/portage/distfiles" EMERGE_DEFAULT_OPTS="--ask-enter-invalid --quiet-build --keep-going" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://ftp.vectranet.pl/gentoo/ http://gentoo.bloodhost.ru/ http://mirror2.corbina.ru/gentoo-distfiles/ http://mirror.yandex.ru/gentoo-distfiles/ http://tux.rainside.sk/gentoo/ http://ftp.df.lth.se/pub/gentoo/ http://gentoo.kiev.ua/ftp/" LANG="en_US.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j7" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/var/lib/layman/tox-overlay /var/lib/layman/aegypius /var/lib/layman/qt /var/lib/layman/chaos /var/lib/layman/dotnet-github /usr/local/portage" USE="X a52 aac acl acpi alsa amd64 bash-completion berkdb bindist bluetooth branding bzip2 cairo cdda cdr cli cmake consolekit cracklib crypt cryptsetup cups cxx dbus declarative dri dts dvd dvdr emboss encode exif fam ffmpeg firefox flac fortran gdbm gif gimp git glamor gpm gtk iconv ipod ipv6 jpeg kde kipi lastfm lcms ldap libnotify mad matroska mmx mng modules mp3 mp4 mpeg multilib ncurses networkmanager nls nptl ogg opengl openmp pam pango pcre pdf phonon plasma png policykit ppds pulseaudio qt3support qt4 readline sdl semantic-desktop session spell sse sse1 sse2 ssl startup-notification svg tcpd tiff truetype udev udisks unicode upower usb valgrind vim vim-syntax vorbis vpx wxwidgets x264 xcb xcomposite xinerama xml xscreensaver xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64 pc" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en ru" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC, USE_PYTHON ================================================================= Package Settings ================================================================= app-shells/gentoo-bashcomp-20121024 was built with the following: USE="(policykit)" ABI_X86="64"
This is due to preparing the lists of remote and local overlays (lines 21,22 in /usr/share/bash-completion/completions/layman) for every case. Instead, these should be prepared only for the cases that need/use them: -a|--add|-i|--info, line 33 -d|--delete, line 37 -s|--sync, line 41 see attached patches for inline/function versions.
Created attachment 388370 [details, diff] patch using functions instead of variables
Created attachment 388372 [details, diff] patch with inlined calls
(In reply to Ole Langbehn from comment #2) > Created attachment 388370 [details, diff] [details, diff] > patch using functions instead of variables I applied this patch, seems to work nicely.
Isn't this an easy win? 5 minutes work, including reading the whole history. Just decide whether to use one of the patches or keep the situation as is. I don't like to bump bugs, but this one is just too straigtforward.
(In reply to Ole Langbehn from comment #5) > Isn't this an easy win? 5 minutes work, including reading the whole history. > > Just decide whether to use one of the patches or keep the situation as is. > > I don't like to bump bugs, but this one is just too straigtforward. Are you asking me? If so then of course use the patch - I said it works nicely.
app-shells/gentoo-bashcomp-20140911 is affected as well. Can someone update the summary accordingly?
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/gentoo-bashcomp.git/commit/?id=7fac21ea09db60e625ed47c95327836230873192 commit 7fac21ea09db60e625ed47c95327836230873192 Author: Arthur Zamarin <arthurzam@gentoo.org> AuthorDate: 2024-05-21 19:18:26 +0000 Commit: Arthur Zamarin <arthurzam@gentoo.org> CommitDate: 2024-05-21 19:18:26 +0000 layman: optimize speed Closes: https://bugs.gentoo.org/526614 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org> completions/layman | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-)
