Created attachment 385972 [details] use posix test syntax and no brace expansions test foo == bar syntax is used in configure.ac and src/m4/bitcoin-qt.m4, $@{.n,} is used in some Makefile templates. I've attached a patch that fixes this, generated by these two gnu sed commands in zsh (maybe bash supports **/ too?) sed -i s/' == / = /'g configure.ac src/m4/bitcoin_qt.m4 sed -i s/'\$@{\.n,}/\$@.n \$@'/g **/Makefile*
Can someone with a non-BASH system please confirm the fixes in https://github.com/bitcoin/bitcoin/pull/5038 ?
@reporter, can you test Luke-Jr's fixes. I don't have a dash only system.
(In reply to Anthony Basile from comment #2) > @reporter, can you test Luke-Jr's fixes. I don't have a dash only system. Not really, the patches in that pull are to tests and something called gitian, i don't even know what that is, and I also don't have a git checkout of bitcoin-qt. All you have to do to test it is emerge dash and run eselect sh set dash, you can then change it back to bash if you want. The parts I could test are the parts that were included in my patch and I already tested those :).
The PR (which addressed more than just gitian) was merged a while ago and was released in 0.10 and newer. Can you confirm if this is still a problem with the latest versions (0.12.x) or not?
I upgraded to 0.12 some time ago without noticing any problems, had no memory of this bug report at the time, but I suppose it must have been fixed then :).
(In reply to Mikael Magnusson from comment #5) > I upgraded to 0.12 some time ago without noticing any problems, had no > memory of this bug report at the time, but I suppose it must have been fixed > then :). @luke-jr is this then fixed upstream? if so, let's close.
(In reply to Anthony Basile from comment #6) > (In reply to Mikael Magnusson from comment #5) > > I upgraded to 0.12 some time ago without noticing any problems, had no > > memory of this bug report at the time, but I suppose it must have been fixed > > then :). > > @luke-jr is this then fixed upstream? if so, let's close. Yep, sounds close-worthy to me. I cannot change the status myself, however.
