Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 521774 - genkernel.conf setting "KNAME" is misleading, does not correspond to (General setup -> () Local version - append to kernel release):
Summary: genkernel.conf setting "KNAME" is misleading, does not correspond to (General...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-30 20:42 UTC by Paige Thompson
Modified: 2019-07-21 16:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paige Thompson 2014-08-30 20:42:54 UTC
it's misleading, redundant. I still have to go and set the local version append to kernel release despite setting KNAME and it ultimately results in this: 

kernel-genkernel-vanilla-x86_64-3.16.1-gentoo-vanilla

I would say the KNAME feature should correspond to the setting of local version, it does it's part as I would expect: 

windowlicker kernels # cd /lib/modules/   
windowlicker modules # ls
3.12.21-gentoo-r1  3.15.3-gentoo  3.15.5-gentoo  3.16.0-gentoo  3.16.1-gentoo-debug  3.16.1-gentoo-vanilla
windowlicker modules # 


Reproducible: Always
Comment 1 Paige Thompson 2014-08-31 00:28:37 UTC
Yes and the way genkernel names the kernel when you specify KNAME breaks grub2-mkconfig, and they promptly changed the status to WONTFIX 

I really think KNAME="" should be changed to override this setting: (General setup -> () Local version - append to kernel release):


reference to grub2-mkconfig bug: 

https://bugs.gentoo.org/show_bug.cgi?id=521780#c2
Comment 2 Ben Kohler gentoo-dev 2017-09-07 18:57:11 UTC
IMHO the current comments in genkernel.conf make this pretty clear what it changes, do you still think there should be a note about this breaking grub-mkconfig's defaults?

Not sure where to go from here
Comment 3 Larry the Git Cow gentoo-dev 2019-07-21 16:26:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=c85901916e603cac8f92f176a84fbb03d0f0bc6d

commit c85901916e603cac8f92f176a84fbb03d0f0bc6d
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-07-21 13:03:19 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-07-21 16:09:45 +0000

    Add --kernel-localversion option
    
    This option will set/unset kernel option CONFIG_LOCALVERSION.
    
    Closes: https://bugs.gentoo.org/521774
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 doc/genkernel.8.txt  |  4 ++++
 gen_cmdline.sh       |  7 +++++++
 gen_configkernel.sh  | 19 +++++++++++++++++++
 gen_determineargs.sh | 19 +++++++++++++++++++
 genkernel.conf       |  4 ++++
 5 files changed, 53 insertions(+)