Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 514966 - games-arcade/opentyrian-2.1.20130907 has a superfluous dependency on dev-vcs/mercurial
Summary: games-arcade/opentyrian-2.1.20130907 has a superfluous dependency on dev-vcs/...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2014-06-24 21:19 UTC by calculuspenguin
Modified: 2020-08-22 18:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description calculuspenguin 2014-06-24 21:19:16 UTC
The games-arcade/opentyrian-2.1.20130907 ebuild includes a dependency on dev-vcs/mercurial with a comment saying that:
# Yes, mercurial is needed to set the build version stamp.

However in the Makefile from the unpacked source the build version step that requires mercurial is commented out and instead a hardcoded value is assigned to HG_REV.  Thus, the dependency on mercurial is unneeded as the value is already set.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2020-08-22 18:56:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e70d543f74f8445856c0ebd943d9409b7c0eb13

commit 3e70d543f74f8445856c0ebd943d9409b7c0eb13
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-08-20 11:52:33 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2020-08-22 18:55:59 +0000

    games-arcade/opentyrian: fix issues
    
    Update to EAPI 7, drop mercurial dependency (not required anymore),
    fixed compilation with -fno-common, updated HOMEPAGE, LICENSE
    
    Closes: https://bugs.gentoo.org/514966
    Closes: https://bugs.gentoo.org/707724
    Closes: https://bugs.gentoo.org/738182
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 .../opentyrian/files/2.1.20130907-gcc10.patch      | 362 +++++++++++++++++++++
 games-arcade/opentyrian/metadata.xml               |   2 +-
 .../opentyrian/opentyrian-2.1.20130907-r2.ebuild   |  54 +++
 3 files changed, 417 insertions(+), 1 deletion(-)