Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 508160 - net-news/quiterss does not respect CFLAGS in linking command
Summary: net-news/quiterss does not respect CFLAGS in linking command
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on: 508812
Blocks:
  Show dependency tree
 
Reported: 2014-04-19 18:07 UTC by Julian Ospald
Modified: 2020-12-16 23:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
quiterss-0.15.3:20140419-180137.log (quiterss-0.15.3:20140419-180137.log,140.36 KB, text/plain)
2014-04-19 18:07 UTC, Julian Ospald
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2014-04-19 18:07:35 UTC
Created attachment 375320 [details]
quiterss-0.15.3:20140419-180137.log

Portage 2.2.10 (default/linux/amd64/13.0, gcc-4.8.2, glibc-2.17, 3.13.7-ck1 x86_64)
=================================================================
System uname: Linux-3.13.7-ck1-x86_64-Intel-R-_Core-TM-_i7-4770_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem:    16459364 total,   3751824 free
KiB Swap:     524284 total,    389248 free
Timestamp of tree: Sun, 04 Aug 2013 12:00:01 +0000
ld GNU ld (GNU Binutils) 2.23.2
distcc[9971] (dcc_trace_version) distcc 3.1 x86_64-pc-linux-gnu; built Oct 26 2013 13:41:01 [disabled]
ccache version 3.1.9 [disabled]
app-shells/bash:          4.2_p45
dev-java/java-config:     2.2.0
dev-lang/python:          2.6.8-r3, 2.7.5-r3, 3.2.5-r3, 3.3.5::hasufell-overlay, 3.4.0::hasufell-overlay
dev-util/ccache:          3.1.9-r3
dev-util/cmake:           2.8.12.2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.10.3, 1.11.6, 1.12.6, 1.13.4
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.3-r1, 4.8.2
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.9 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo arx-libertatis hasufell sunrise toolchain mrueg gentoo-haskell qt torbrowser crossdev hasufell-overlay hasufell-science
Installed sets: @bleh, @development, @games, @optional, @steam, @test, @xfce
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core-avx2 -O2 -pipe -Wall -g"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/cron.hourly /usr/share/applications /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=core-avx2 -O2 -pipe -Wall -g"
DISTDIR="/var/cache/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch protect-owned sandbox sfperms sign split-log splitdebug strict test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userpriv usersandbox usersync webrsync-gpg"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://mirror.netcologne.de/gentoo/ ftp://gentoo.imj.fr/pub/gentoo/ ftp://de-mirror.org/gentoo/"
INSTALL_MASK="/usr/lib/systemd/*"
LANG="de_DE.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j8"
PKGDIR="/var/cache/packages"
PORTAGE_COMPRESS="xz"
PORTAGE_COMPRESS_FLAGS="-z -9"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/arx-libertatis /var/lib/layman/hasufell /var/lib/layman/sunrise /var/lib/layman/toolchain /var/lib/layman/mrueg /var/lib/layman/gentoo-haskell /var/lib/layman/qt /var/lib/layman/torbrowser /usr/local/crossdev /usr/local/portage /usr/local/portage-science"
USE="X a52 aac acl acpi alsa amd64 apng bash-completion berkdb bzip2 cairo cdr cli consolekit cracklib crypt cscope css cups cxx dbus dri dv dvd dvdr exif fat ffmpeg flac fontconfig fortran gdbm gif gpm gstreamer hddtemp iconv icq icu ipv6 jabber jpeg jpeg2k lame libnotify lm_sensors matroska mmx modules mp3 mp4 mpeg multilib musepack ncurses nls nptl nsplugin ntfs ogg opengl openmp oscar pam pcre pdf png policykit python qt3support raw readline sdl session sound sse sse2 ssl ssse3 svg tcpd threads tiff timidity truetype udev unicode usb v4l vcd vdpau vim-syntax vnc vorbis wavpack wayland win32codecs wmf x264 xinerama xv xvid xvmc zlib" ABI_X86="64 32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CURL_SSL="polarssl" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev keyboard mouse joystick" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="pdfimport presenter-console presenter-minimizer" LINGUAS="en de" NETBEANS_MODULES="*" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="pypy python2_6 python2_7 python3_2 python3_3 python3_4" QEMU_SOFTMMU_TARGETS="arm i386 ppc ppc64 x86_64" QEMU_USER_TARGETS="arm i386 ppc ppc64 x86_64" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="nvidia nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
USE_PYTHON="2.6 2.7 3.2 3.3"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_RSYNC_EXTRA_OPTS, SYNC
Comment 1 Nikoli 2014-04-20 05:32:42 UTC
Is there official Gentoo documentation telling to always include CFLAGS in linking command?
Comment 2 Julian Ospald 2014-04-20 11:22:51 UTC
(In reply to Nikoli from comment #1)
> Is there official Gentoo documentation telling to always include CFLAGS in
> linking command?

what's with all that "official"? We don't have policies for every possible crap. See bug 446281 for an explanation. I have talked to QA about this as well (the old one), so this is a valid bug.
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2014-04-20 11:25:23 UTC
(In reply to Nikoli from comment #1)
> Is there official Gentoo documentation telling to always include CFLAGS in
> linking command?

That's a valid question. Yes it's required, since the CFLAGS include stuff like -Wl,--as-needed which are targeting the linker so they should be present while linking.
Comment 4 Julian Ospald 2014-04-20 12:13:41 UTC
(In reply to Markos Chandras from comment #3)
> since the CFLAGS include stuff like -Wl,--as-needed which 

Usually, -Wl,--as-needed is not in CFLAGS.
Comment 5 Nikoli 2014-04-20 12:39:07 UTC
> what's with all that "official"? We don't have policies for every possible crap.

Your comments are self-contradictory: either this issue is important enough for documenting it and fixing in packages and upstreams or it is not. You reported it for 5 my packages already, so for you it should be significant.

> See bug 446281 for an explanation.

Respecting CFLAGS is kind of bug that should be fixed upstream too, so i need to provide url to valid explanation for them. Random talk in random bug is not such explanation, it is not usable as documentation or rule: nobody will squeeze through discussions in bugs.

Markos, may be open separate bug for clarifying and updating docs?
I am still not sure if this 'respect CFLAGS in linking command' is real bug in all cases: a lot packages are doing _only_ linking in linking command; quiterss operates only .o files, it does not have any .c or .cpp files as input for linking command.

> Yes it's required, since the CFLAGS include stuff like -Wl,--as-needed which are targeting the linker so they should be present while linking.

I only saw --as-needed in LDFLAGS, why would it be in CFLAGS? It seems nothing in Gentoo adds it to CFLAGS and nothing should add.
Comment 6 Julian Ospald 2014-04-20 13:00:16 UTC
(In reply to Nikoli from comment #5)
> > what's with all that "official"? We don't have policies for every possible crap.
> 
> Your comments are self-contradictory

Not at all. There are a lot of QA things that are not documented "officially". I don't have to write documentation for every possible thing in order for a report to be a valid bug.

> > See bug 446281189 for an explanation.
> 
> Respecting CFLAGS is kind of bug that should be fixed upstream too
> 

Most don't care. I'v been doing this for some time now, so the general approach is... fix this downstream first and then take it to upstream. It's trivial enough. Otherwise you will have ~120 open bugs and 5 upstreams who merge it, 20 say we don't care and the rest doesn't even reply.

If you have actual code changes, then it's reasonable to take this to upstream first.

> Markos, may be open separate bug for clarifying and updating docs?
> I am still not sure if this 'respect CFLAGS in linking command' is real bug
> in all cases: a lot packages are doing _only_ linking in linking command;
> quiterss operates only .o files, it does not have any .c or .cpp files as
> input for linking command.
> 

That's not the point, as outlined in the bug I just linked for you. It's not about "we compile objects during linking stage explicitly", it's about "some flags affect BOTH object compilation AND linking".
Comment 7 Sergey Popov gentoo-dev 2014-04-28 10:02:23 UTC
This is trickier, cause qmake itself generate makefile, that does not respect CFLAGS in linking command. Perhaps some interaction with Qt itself is needed...
Comment 8 Davide Pesavento gentoo-dev 2014-04-28 10:56:11 UTC
(In reply to Sergey Popov from comment #7)
> This is trickier, cause qmake itself generate makefile, that does not
> respect CFLAGS in linking command. Perhaps some interaction with Qt itself
> is needed...

I suspected that... if qmake is the culprit, then only qmake should be fixed.
Please don't add ad-hoc fixes/hacks to random ebuilds until we have determined the root cause.
Comment 9 Julian Ospald 2014-04-28 17:41:09 UTC
(In reply to Sergey Popov from comment #7)
> This is trickier, cause qmake itself generate makefile, that does not
> respect CFLAGS in linking command. Perhaps some interaction with Qt itself
> is needed...

Maybe we should file a bug at qmake upstream? Are they collaborative?
Comment 10 Davide Pesavento gentoo-dev 2014-05-03 17:12:06 UTC
Yes, they usually are, although I doubt they'll fix it for qt4... maybe for qt5 and then we can backport.
Comment 11 Larry the Git Cow gentoo-dev 2020-11-16 23:40:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=264f7fda4fc3324ddab122f4bebee044f34c8bd7

commit 264f7fda4fc3324ddab122f4bebee044f34c8bd7
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-11-16 23:15:06 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-11-16 23:40:12 +0000

    profiles: Mask net-news/quiterss for removal
    
    See also: https://github.com/QuiteRSS/quiterss/issues/909
    
    Bug: https://bugs.gentoo.org/508160
    Bug: https://bugs.gentoo.org/654968
    Bug: https://bugs.gentoo.org/687840
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 12 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-12-16 23:05:12 UTC
Package removed.