Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 494710 - Improper quoting breaks variable interpolation in test_success
Summary: Improper quoting breaks variable interpolation in test_success
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2013-12-19 01:27 UTC by Anthony Lieuallen
Modified: 2020-07-23 23:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Lieuallen 2013-12-19 01:27:23 UTC
File initrd.scripts function test_success contains the line:

                bad_msg 'Failed to $1; failing back to the shell...'

with single quotes.  If the test fails, the literal "$1" is printed, not the contents of argument one.  The sources also implies that this should be $error_string instead of $1?
Comment 1 Larry the Git Cow gentoo-dev 2020-06-23 19:14:38 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=24d3f6b4b3afe1125fa9296b50b55f75870c645e

commit 24d3f6b4b3afe1125fa9296b50b55f75870c645e
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-06-23 19:08:17 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-06-23 19:08:17 +0000

    defaults/initrd.scripts: test_success(): Fix quoting
    
    Bug: https://bugs.gentoo.org/494710
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 defaults/initrd.scripts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2020-06-23 19:15:16 UTC
Will be in next genkernel release, thank you for the report :)
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2020-07-23 23:46:28 UTC
Released with >=genkernel-4.0.10.