Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 492994 - dev-util/kbuild-0.1.9998_pre20131130 - please add Gentoo/FreeBSD support and ~amd64-fbsd KEYWORDS.
Summary: dev-util/kbuild-0.1.9998_pre20131130 - please add Gentoo/FreeBSD support and ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: All FreeBSD
: Normal normal
Assignee: Gentoo/BSD Team
URL:
Whiteboard:
Keywords: KEYWORDREQ, PATCH
Depends on:
Blocks:
 
Reported: 2013-12-01 02:30 UTC by Yuta SATOH
Modified: 2016-11-03 21:04 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sample patch for kbuild-0.1.9998_pre20131130.ebuild (492994.patch,1.08 KB, patch)
2013-12-01 02:32 UTC, Yuta SATOH
Details | Diff
sample patch for kbuild-0.1.9998_pre20131130.ebuild (492994.patch,735 bytes, patch)
2013-12-04 11:02 UTC, Yuta SATOH
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta SATOH 2013-12-01 02:30:00 UTC
The following message is displayed and fails to compile on amd64-fbsd.


>>> Source configured.
>>> Compiling source in /var/tmp/portage/dev-util/kbuild-0.1.9998_pre20131130/work/kBuild-0.1.9998-pre20131130 ...
kBuild/env.sh: warning: The bin directory for this platform doesn't exist. (/var/tmp/portage/dev-util/kbuild-0.1.9998_pre20131130/work/kBuild-0.1.9998-pre20131130/kBuild/bin/freebsd.amd64/)
kBuild/env.sh: info: Executing command: make -f bootstrap.gmk AUTORECONF=true AR=x86_64-gentoo-freebsd10.0-ar
make: "/var/tmp/portage/dev-util/kbuild-0.1.9998_pre20131130/work/kBuild-0.1.9998-pre20131130/bootstrap.gmk" line 57: Need an operator
make: "/var/tmp/portage/dev-util/kbuild-0.1.9998_pre20131130/work/kBuild-0.1.9998-pre20131130/bootstrap.gmk" line 59: Need an operator
make: "/var/tmp/portage/dev-util/kbuild-0.1.9998_pre20131130/work/kBuild-0.1.9998-pre20131130/bootstrap.gmk" line 60: Need an operator
<snip>
make: Fatal errors encountered -- cannot continue
make: stopped in /var/tmp/portage/dev-util/kbuild-0.1.9998_pre20131130/work/kBuild-0.1.9998-pre20131130
kBuild/env.sh: info: rc=1: make -f bootstrap.gmk AUTORECONF=true AR=x86_64-gentoo-freebsd10.0-ar
 * ERROR: dev-util/kbuild-0.1.9998_pre20131130::gentoo failed (compile phase):
 *   bootstrap failed


Reproducible: Always

Steps to Reproduce:
1. emerge =dev-util/kbuild-0.1.9998_pre20131130
2.
3.
Comment 1 Yuta SATOH 2013-12-01 02:32:39 UTC
Created attachment 364312 [details, diff]
sample patch for kbuild-0.1.9998_pre20131130.ebuild

Fixed two issues.
* call emake instead of make.
  make is BSD's make on Gentoo/FreeBSD.
* added MY_ARCH="${ARCH/-*}". and, replaced from ${ARCH} to ${MY_ARCH}.
  Gentoo/FreeBSD's ${ARCH} is amd64-fbsd or x86-fbsd. It must be amd64 or x86.


FYI,
# make --help
usage: make [-BeikNnqrstWwX]
            [-C directory] [-D variable] [-d flags] [-f makefile]
            [-I directory] [-J private] [-j max_jobs] [-m directory] [-T file]
            [-V variable] [variable=value] [target ...]
# gmake --help
Usage: gmake [options] [target] ...
Options:
  -b, -m                      Ignored for compatibility.
  -B, --always-make           Unconditionally make all targets.
<snip>
# emerge --info -v | grep ARCH
ARCH="amd64-fbsd"
Comment 2 Naohiro Aota gentoo-dev 2013-12-03 16:36:24 UTC
(In reply to Yuta SATOH from comment #1)
> * added MY_ARCH="${ARCH/-*}". and, replaced from ${ARCH} to ${MY_ARCH}.
>   Gentoo/FreeBSD's ${ARCH} is amd64-fbsd or x86-fbsd. It must be amd64 or
> x86.

tc-arch would work here?
Comment 3 Yuta SATOH 2013-12-04 11:02:42 UTC
Created attachment 364586 [details, diff]
sample patch for kbuild-0.1.9998_pre20131130.ebuild

(In reply to Naohiro Aota from comment #2)
> (In reply to Yuta SATOH from comment #1)
> > * added MY_ARCH="${ARCH/-*}". and, replaced from ${ARCH} to ${MY_ARCH}.
> >   Gentoo/FreeBSD's ${ARCH} is amd64-fbsd or x86-fbsd. It must be amd64 or
> > x86.
> 
> tc-arch would work here?

Thank you for your comment.
I've updated to the patch, and it work correctly.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-12-06 10:20:55 UTC
Gentoo/BSD Team: feel free to commit.
Comment 5 Patrice Clement (RETIRED) gentoo-dev 2016-11-03 21:04:03 UTC
commit 121ff2a18a55ea4c02c2bae1197e26a708a653d6 (HEAD -> master, origin/master, origin/HEAD)
Author:     Yuta Satoh <nigoro.dev@gmail.com>
AuthorDate: Wed Nov 2 20:49:08 2016 +0900
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Thu Nov 3 22:03:28 2016 +0100

dev-util/kbuild: add ~amd64-fbsd, ~x86-fbsd KEYWORDS.

Gentoo-Bug: https://bugs.gentoo.org/492994
Closes: https://github.com/gentoo/gentoo/pull/2719

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

dev-util/kbuild/kbuild-0.1.9998_pre20131130-r1.ebuild | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Merged! Thanks.